You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/07/17 04:48:06 UTC

[GitHub] [camel] oscerd commented on a change in pull request #4010: CAMEL-15266: Contributing guide cleanup

oscerd commented on a change in pull request #4010:
URL: https://github.com/apache/camel/pull/4010#discussion_r456215994



##########
File path: docs/user-manual/modules/ROOT/pages/contributing.adoc
##########
@@ -169,7 +170,7 @@ We gladly accept patches if you can find ways to improve, tune or fix Camel in s
 
 We recommend using github PRs instead of manual patch files. Especially for bigger patches.
 
-Most IDEs can create nice patches now very easily. e.g. in Eclipse just right click on a file/directory and select Team \-> Create Patch. Then just save the patch as a file and attach it to the corresponding issue on our https://issues.apache.org/jira/browse/CAMEL[JIRA issue tracker].
+Most IDEs can create nice patches now very easily. e.g. in Eclipse just right click on a file/directory and select Team \-> Create Patch. Then just save the patch as a file and attach it to the corresponding issue on our https://issues.apache.org/jira/browse/CAMEL[JIRA issue tracker]. (You may have to click on Team -> Share... first to enable the Subversion options).

Review comment:
       I think there is anybody out there still using subversion for Apache Camel.

##########
File path: docs/user-manual/modules/ROOT/pages/contributing.adoc
##########
@@ -86,6 +86,7 @@ For more information see xref:faq:how-does-the-website-work.adoc[How does the we
 
 Please raise a new issue on our https://issues.apache.org/jira/browse/CAMEL[JIRA issue tracker]. This way we’ll know when it’s really fixed and we can ensure that the problem stays fixed in future releases. Please describe the bug/issue clearly, and add pictures/screenshots if necessary. If you can create a JUnit test case then your issue is more likely to be resolved quicker.
 e.g. take a look at some of the existing https://svn.apache.org/repos/asf/camel/trunk/camel-core/src/test/java/[unit tests cases]
+Then we can add your issue to Subversion and then we'll know when its really fixed and we can ensure that the problem stays fixed in future releases.

Review comment:
       Ditto




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org