You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/05/15 12:25:57 UTC
[GitHub] [lucene-solr] ErickErickson opened a new pull request #1519: SOLR-14482: Fix compile-time warnings in solr/core/search/facet
ErickErickson opened a new pull request #1519:
URL: https://github.com/apache/lucene-solr/pull/1519
The facet code has a lot of classes declared in a file with a different name. This tries to fix all the warnings in solr/core/search/facet. gradlew check passes. Here for comments.
Plus one log message I noticed that I'd checked in when I was debugging.
Make any comments by EOD Friday, I'll be pushing this over the weekend otherwise after verifying that it all works under ant precommit/test too and checking it over one more time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] ErickErickson closed pull request #1519: SOLR-14482: Fix compile-time warnings in solr/core/search/facet
Posted by GitBox <gi...@apache.org>.
ErickErickson closed pull request #1519:
URL: https://github.com/apache/lucene-solr/pull/1519
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] ErickErickson commented on pull request #1519: SOLR-14482: Fix compile-time warnings in solr/core/search/facet
Posted by GitBox <gi...@apache.org>.
ErickErickson commented on pull request #1519:
URL: https://github.com/apache/lucene-solr/pull/1519#issuecomment-630376772
Reworking, I'll put up another PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org