[GitHub] [ozone] bharatviswa504 commented on a change in pull request #2371: HDDS-5390. reconPipelineReportHandler don't retry when pipeline not found

[GitBox <gi...@apache.org>]

bharatviswa504 commented on a change in pull request #2371:
URL: https://github.com/apache/ozone/pull/2371#discussion_r658605496



##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelineReportHandler.java
##########
@@ -93,6 +93,9 @@ public void onMessage(PipelineReportFromDatanode pipelineReportFromDatanode,
       } catch(NotLeaderException ex) {
         // Avoid NotLeaderException logging which happens when processing
         // pipeline report on followers.
+      } catch(PipelineNotFoundException pnfe) {

Review comment:
       Does nt recon pipelineHandler processPipelineReport handled this already?
   
   
   ReconPipelineReportHandler.java
   ```
       Pipeline pipeline = null;
       try {
         pipeline = reconPipelineManager.getPipeline(pipelineID);
       } catch (PipelineNotFoundException ex) {
         LOG.warn("Pipeline {} not found in Recon.", pipelineID);
         return;
       }
   ````

##########
File path: hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/client/HddsClientUtils.java
##########
@@ -70,6 +71,9 @@ private HddsClientUtils() {
           // Not Replicated Exception will be thrown if watch For commit
           // does not succeed
           .add(NotReplicatedException.class)
+          // for reconPipelineReportHandler , if could not find pipeline

Review comment:
       And also I see this list is being used in KeyOutputStream and XceiverClientRatis.
   Not understood why we need this to be added here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org