[GitHub] [iceberg] RussellSpitzer commented on a change in pull request #3914: Hive: Add table UUID to HMS table properties.

[GitBox <gi...@apache.org>]

RussellSpitzer commented on a change in pull request #3914:
URL: https://github.com/apache/iceberg/pull/3914#discussion_r790769233



##########
File path: hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java
##########
@@ -262,7 +262,8 @@ protected void doCommit(TableMetadata base, TableMetadata metadata) {
       Map<String, String> summary = Optional.ofNullable(metadata.currentSnapshot())
           .map(Snapshot::summary)
           .orElseGet(ImmutableMap::of);
-      setHmsTableParameters(newMetadataLocation, tbl, metadata.properties(), removedProps, hiveEngineEnabled, summary);
+      setHmsTableParameters(newMetadataLocation, tbl, metadata.properties(), removedProps, hiveEngineEnabled, summary,

Review comment:
       I wonder if we should be passing through the metadata here instead of `"tbl, metadata.properties and uuid"`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org