You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/03/07 21:35:38 UTC
[jira] [Commented] (NIFI-3565) TransformersTest fails when building
under different locales
[ https://issues.apache.org/jira/browse/NIFI-3565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15900212#comment-15900212 ]
ASF GitHub Bot commented on NIFI-3565:
--------------------------------------
GitHub user pvillard31 opened a pull request:
https://github.com/apache/nifi/pull/1571
NIFI-3565 - Fixed BigDecimal instantiation and unit tests for specifi…
…c locales
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [X] Have you written or updated unit tests to verify your changes?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pvillard31/nifi NIFI-3565
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1571.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1571
----
commit c0ce99244915f35e26b76bee8598aec02fa9a870
Author: Pierre Villard <pi...@gmail.com>
Date: 2017-03-07T21:28:13Z
NIFI-3565 - Fixed BigDecimal instantiation and unit tests for specific locales
----
> TransformersTest fails when building under different locales
> ------------------------------------------------------------
>
> Key: NIFI-3565
> URL: https://issues.apache.org/jira/browse/NIFI-3565
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions, Tools and Build
> Affects Versions: 1.2.0
> Reporter: Aldrin Piri
> Assignee: Pierre Villard
>
> Running a build with the following
> {code}
> mvn clean install -Dmaven.surefire.arguments="-Duser.language=FR -Duser.region=fr"
> {code}
> results in failures with the TransformersTest for presumably similar reasons to NIFI-3483.
> {code}
> Tests run: 14, Failures: 0, Errors: 3, Skipped: 0, Time elapsed: 5.314 sec <<< FAILURE! - in org.apache.nifi.schemaregistry.processors.TransformersTest
> [5] input_csv/decimal_logicalType.txt,input_avro/decimal_logicalType_valid_scale_with_no_default.txt,expected_ouput_csv/decimal_logicalType.txt (testCSVRoundtrip)(org.apache.nifi.schemaregistry.processors.TransformersTest) Time elapsed: 0.762 sec <<< ERROR!
> java.lang.NumberFormatException: null
> at java.math.BigDecimal.<init>(BigDecimal.java:494)
> at java.math.BigDecimal.<init>(BigDecimal.java:383)
> at java.math.BigDecimal.<init>(BigDecimal.java:806)
> at org.apache.nifi.schemaregistry.processors.CSVUtils.write(CSVUtils.java:161)
> at org.apache.nifi.schemaregistry.processors.TransformersTest.testCSVRoundtrip(TransformersTest.java:149)
> [6] input_csv/decimal_logicalType.txt,input_avro/decimal_logicalType_invalid_scale_with_default.txt,expected_ouput_csv/decimal_logicalType_invalid_scale.txt (testCSVRoundtrip)(org.apache.nifi.schemaregistry.processors.TransformersTest) Time elapsed: 0 sec <<< ERROR!
> java.lang.NumberFormatException: null
> at java.math.BigDecimal.<init>(BigDecimal.java:494)
> at java.math.BigDecimal.<init>(BigDecimal.java:383)
> at java.math.BigDecimal.<init>(BigDecimal.java:806)
> at org.apache.nifi.schemaregistry.processors.CSVUtils.write(CSVUtils.java:161)
> at org.apache.nifi.schemaregistry.processors.TransformersTest.testCSVRoundtrip(TransformersTest.java:149)
> [7] input_csv/decimal_logicalType_missing_value.txt,input_avro/decimal_logicalType_valid_scale_with_default.txt,expected_ouput_csv/decimal_logicalType_valid_scale_with_default.txt (testCSVRoundtrip)(org.apache.nifi.schemaregistry.processors.TransformersTest) Time elapsed: 0 sec <<< ERROR!
> java.lang.NumberFormatException: null
> at java.math.BigDecimal.<init>(BigDecimal.java:494)
> at java.math.BigDecimal.<init>(BigDecimal.java:383)
> at java.math.BigDecimal.<init>(BigDecimal.java:806)
> at org.apache.nifi.schemaregistry.processors.CSVUtils.write(CSVUtils.java:161)
> at org.apache.nifi.schemaregistry.processors.TransformersTest.testCSVRoundtrip(TransformersTest.java:149)
> Results :
> Tests in error:
> TransformersTest.testCSVRoundtrip:149 » NumberFormat
> TransformersTest.testCSVRoundtrip:149 » NumberFormat
> TransformersTest.testCSVRoundtrip:149 » NumberFormat
> Tests run: 14, Failures: 0, Errors: 3, Skipped: 0
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)