[GitHub] [beam] sirenbyte commented on pull request #23577: [Tour of Beam] Learning content for "Common-transforms" module

["sirenbyte (via GitHub)" <gi...@apache.org>]

sirenbyte commented on PR #23577:
URL: https://github.com/apache/beam/pull/23577#issuecomment-1442158895

   > Partial review. Please update the following everywhere: For Java, all inputs should be in a variable named 'input', not 'numbers' For python, always use 'with beam.Pipeline() as p:', never with beam.Pipeline() as pipeline: For python, be consistent with code snippets. Favor this pattern: '(p | beam.Create(range(1, 11))' for the initial line of the pipeline code. For Go, make sure KV collections are created for examples.
   > 
   > In general, always make sure the variables etc are consistent across the playground code and the code examples in the learning materials. Users should be able to cut and paste code from the learning materials into the playground without renaming things where possible.
   > 
   > Grammar: Look at 'replace X with Y' sentences. Sometimes you have 'replace X on Y'
   
   > Comments are applied to all modules. Fixed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org