You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/02/07 16:44:55 UTC

[GitHub] [cordova-docs] breautek opened a new pull request #1162: blog: Deprecate WKWebView Engine plugin announcement

breautek opened a new pull request #1162:
URL: https://github.com/apache/cordova-docs/pull/1162


   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   
   Blog
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   
   Annoucement of wkwebview plugin deprecation
   
   ### Description
   <!-- Describe your changes in detail -->
   
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   
   N/A
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [x] I added automated test coverage as appropriate for this change
   - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [x] I've updated the documentation if necessary
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-docs] dpogue commented on a change in pull request #1162: blog: Deprecate WKWebView Engine plugin announcement

Posted by GitBox <gi...@apache.org>.
dpogue commented on a change in pull request #1162:
URL: https://github.com/apache/cordova-docs/pull/1162#discussion_r571715277



##########
File path: www/_posts/2021-02-07-deprecate-wkwebview-engine.md
##########
@@ -0,0 +1,16 @@
+---
+layout: post
+author:
+    name: Norman Breau
+    url: https://twitter.com/NormanBreau
+---
+
+## Deprecation of the Cordova WKWebView Engine Plugin
+
+We are hereby annoucing the deprecation of [cordova-plugin-wkwebview-engine](https://github.com/apache/cordova-plugin-wkwebview-engine/blob/master/README.md#deprecation-notice).

Review comment:
       I think we need at least one more sentence of explanation here, saying that the plugin is built-in to cordova-ios 6 and no longer necessary, and that's why it's being deprecated.
   
   We probably also want to encourage upgrading to cordova-ios 6 rather than just recommending the removal of the plugin after upgrading.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-docs] breautek merged pull request #1162: blog: Deprecate WKWebView Engine plugin announcement

Posted by GitBox <gi...@apache.org>.
breautek merged pull request #1162:
URL: https://github.com/apache/cordova-docs/pull/1162


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-docs] breautek commented on a change in pull request #1162: blog: Deprecate WKWebView Engine plugin announcement

Posted by GitBox <gi...@apache.org>.
breautek commented on a change in pull request #1162:
URL: https://github.com/apache/cordova-docs/pull/1162#discussion_r571724947



##########
File path: www/_posts/2021-02-07-deprecate-wkwebview-engine.md
##########
@@ -0,0 +1,16 @@
+---
+layout: post
+author:
+    name: Norman Breau
+    url: https://twitter.com/NormanBreau
+---
+
+## Deprecation of the Cordova WKWebView Engine Plugin
+
+We are hereby annoucing the deprecation of [cordova-plugin-wkwebview-engine](https://github.com/apache/cordova-plugin-wkwebview-engine/blob/master/README.md#deprecation-notice).

Review comment:
       I added some more details, but I didn't do it here, I did it in the 3rd paragraph. I felt like the post was a bit unorganised otherwise.
   
   Please let me know what you think.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org