You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/18 07:25:41 UTC

[GitHub] [airflow] potiuk commented on pull request #9368: Adds GCP Secret Manager Hook

potiuk commented on pull request #9368:
URL: https://github.com/apache/airflow/pull/9368#issuecomment-645833163


   @ashb and @kaxil  - I'd love to get that one and the #8974 to be included in the first release of backports. I implemented the GCP Secret Manager Hook following what we agreed with HashiCorp. 
   
   Note that I renamed the secrets_manager into secret_manager (and SecretsManager into SecretManager) as this is the name of the GCP Service (no plural). I left Plural in the contrib folder for backwards compatibility (but deprecation warning points to singular name now). 
   
   @mik-laj @turbaszek -> would love if you take a look as well (I added hook  System Tests as well and it works nicely with the real GCP SecretManager).
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org