[Hadoop Wiki] Update of "Hive/HowToContribute" by CarlSteinbach

[Apache Wiki <wi...@apache.org>]

Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Hadoop Wiki" for change notification.

The "Hive/HowToContribute" page has been changed by CarlSteinbach.
http://wiki.apache.org/hadoop/Hive/HowToContribute?action=diff&rev1=32&rev2=33

--------------------------------------------------

  In order to create a patch, type (from the base directory of hive):
  
  {{{
- svn diff > HIVE-1234.patch
+ svn diff > HIVE-1234.1.patch.txt
  }}}
- This will report all modifications done on Hive sources on your local disk and save them into the ''HIVE-1234.patch'' file.  Read the patch file.   Make sure it includes ONLY the modifications required to fix a single issue.
+ This will report all modifications done on Hive sources on your local disk and save them into the ''HIVE-1234.1.patch.txt'' file.  Read the patch file. Make sure it includes ONLY the modifications required to fix a single issue.
  
  Please do not:
  
@@ -150, +150 @@

  
  === Updating a patch ===
  
- For patch updates, our convention is to number them like HIVE-1856.1.patch, HIVE-1856.2.patch, etc. And then click the "Submit Patch" button again when a new one is uploaded; this makes sure it gets back into the review queue.
+ For patch updates, our convention is to number them like HIVE-1856.1.patch.txt, HIVE-1856.2.patch.txt, etc. And then click the "Submit Patch" button again when a new one is uploaded; this makes sure it gets back into the review queue. Appending '.txt' to the patch file name makes it easy to quickly view the contents of the patch in a web browser.
  
  === Applying a patch ===
  To apply a patch either you generated or found from JIRA, you can issue
@@ -212, +212 @@

  Here are the steps relevant to {{{hive_metastore.thrift}}}:
  
   1. Don't make any changes to {{{hive_metastore.thrift}}} until instructed below.
-  1. Use the approved version of thrift.  This is currently {{{thrift-instant-r790732}}}, which you can obtain from http://instant.thrift-rpc.org.  (If that site is down, use [[http://ansible.eigenbase.org/download/thrift-instant-r790732.tar.gz|this alternate location]].)
+  1. Use the approved version of thrift.  This is currently {{{thrift-0.5.0}}}, which you can obtain from http://thrift.apache.org/.
   1. Build the thrift compiler from its sources, then install it:
-  1. {{{cd /path/to/thrift-instant-rXYZ}}}
+  1. {{{cd /path/to/thrift-0.5.0}}}
   1. {{{./configure --without-csharp --without-ruby}}}
   1. {{{make}}}
   1. {{{sudo make install}}}
-  1. Before proceeding, verify that {{{which thrift}}} returns the build of thrift you just installed (typically {{{/usr/local/bin}}} on Linux); if not, edit your PATH and repeat the verification.
+  1. Before proceeding, verify that {{{which thrift}}} returns the build of thrift you just installed (typically {{{/usr/local/bin}}} on Linux); if not, edit your PATH and repeat the verification. Also verify that the command 'thrift -version' returns the expected version number of Thrift.
-  1. Now you can run the thrift compiler to generate code:
+  1. Now you can run the ant 'thriftif' target to generate the Thrift code:
   1. {{{cd /path/to/hive-trunk/metastore}}}
-  1. {{{ant thriftif}}}
+  1. {{{ant thriftif -Dthrift.home=/path/to/thrift-0.5.0}}}
   1. Use {{{svn status}}} to verify that the code generation was a no-op, which should be the case if you have the correct thrift version and everyone has been following these instructions.  If you can't figure out what is going wrong, ask for help from a committer.
   1. Now make your changes to {{{hive_metastore.thrift}}}, and then run the compiler again:
   1. {{{ant thriftif}}}