Revision 397980 changes MessageId to ClientMessageId

["David W. Van Couvering" <Da...@Sun.COM>]

Hi, all.  It turns out I needed iapi/reference/MessageId.java on the 
client side, so I moved it to shared/common/reference.  Then, to avoid 
class name confusion, I renamed client/am/MessageId to 
client/am/ClientMessageId.  I just checked this change in (passes 
derbynetclientmats cleanly).  This may cause some conflicts in your sandbox.

David

Re: Revision 397980 changes MessageId to ClientMessageId

["David W. Van Couvering" <Da...@Sun.COM>]

Yes, that's right, this change was in preparation for my next i18n patch 
where the client will start referring to it.

But engine/org/apache/derby/iapi/reference/MessageId was modified to be 
an empty class that extends 
shared/org/apache/derby/shared/common/reference/MessageId.  How did 
*that* compile correctly?

I just looked at it right now in the sandbox where I made this change, 
and I see the error in NetBeans:

"cannot access org.apache.derby.shared.common.reference.MessageId: bad 
class file."

So, I'm a bit stumped - it shouldn't have compiled, right?

I feel cursed - every time I try to run a smaller test suite something 
goes wrong.  I feel like I should run derbyall even if I change 
BUILDING.txt.

Anyway, thanks for fixing the bug.

David

Andrew McIntyre wrote:
> On 4/28/06, David W. Van Couvering <Da...@sun.com> wrote:
>> Thanks, Andrew.
>>
>> Now tell me how I could possibly have gotten this to build and pass
>> tests with this mistake.
> 
> Well, ClientMessageId doesn't import or extend MessageId. It's
> initialized with values that are all static final strings from
> SQLState.
> 
> MessageId doesn't seem to be referenced anywhere in java/client?
> 
> ~/derby andrewm$ grep --recursive 'MessageId\.[ACDIJLM]' java/client
> ~/derby andrewm$
> 
> andrew

Re: Revision 397980 changes MessageId to ClientMessageId

[Andrew McIntyre <mc...@gmail.com>]

On 4/28/06, David W. Van Couvering <Da...@sun.com> wrote:
> Thanks, Andrew.
>
> Now tell me how I could possibly have gotten this to build and pass
> tests with this mistake.

Well, ClientMessageId doesn't import or extend MessageId. It's
initialized with values that are all static final strings from
SQLState.

MessageId doesn't seem to be referenced anywhere in java/client?

~/derby andrewm$ grep --recursive 'MessageId\.[ACDIJLM]' java/client
~/derby andrewm$

andrew

Re: Revision 397980 changes MessageId to ClientMessageId

["David W. Van Couvering" <Da...@Sun.COM>]

Thanks, Andrew.

Now tell me how I could possibly have gotten this to build and pass 
tests with this mistake.

David

Andrew McIntyre wrote:
> On 4/28/06, David W. Van Couvering <Da...@sun.com> wrote:
>> Hi, all.  It turns out I needed iapi/reference/MessageId.java on the
>> client side, so I moved it to shared/common/reference.  Then, to avoid
>> class name confusion, I renamed client/am/MessageId to
>> client/am/ClientMessageId.  I just checked this change in (passes
>> derbynetclientmats cleanly).  This may cause some conflicts in your 
>> sandbox.
> 
> I think you forgot to update the package name in the MessageId in
> java/shared. Fixed with revision 398017.
> 
> andrew

Re: Revision 397980 changes MessageId to ClientMessageId

[Andrew McIntyre <mc...@gmail.com>]

On 4/28/06, David W. Van Couvering <Da...@sun.com> wrote:
> Hi, all.  It turns out I needed iapi/reference/MessageId.java on the
> client side, so I moved it to shared/common/reference.  Then, to avoid
> class name confusion, I renamed client/am/MessageId to
> client/am/ClientMessageId.  I just checked this change in (passes
> derbynetclientmats cleanly).  This may cause some conflicts in your sandbox.

I think you forgot to update the package name in the MessageId in
java/shared. Fixed with revision 398017.

andrew