You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/09/18 01:46:18 UTC
[GitHub] [druid] vogievetsky opened a new pull request #10406: Web console: fix lookup edit dialog, allow column renaming
vogievetsky opened a new pull request #10406:
URL: https://github.com/apache/druid/pull/10406
This PR fixes an issue introduced in https://github.com/apache/druid/pull/10360/files#diff-bf9dd2e02fb9a363490ddc495577810dR60 where the lookup edit dialog does not function correctly.
The fundamental issue is that the types here https://github.com/apache/druid/compare/master...implydata:edit-fix?expand=1#diff-ba8558b9ae27105139ba0090510c5395R79 were too loose
This PR also adds a convenient way to rename output columns in a SQL query output.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vogievetsky merged pull request #10406: Web console: fix lookup edit dialog, allow column renaming
Posted by GitBox <gi...@apache.org>.
vogievetsky merged pull request #10406:
URL: https://github.com/apache/druid/pull/10406
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vogievetsky commented on pull request #10406: Web console: fix lookup edit dialog, allow column renaming
Posted by GitBox <gi...@apache.org>.
vogievetsky commented on pull request #10406:
URL: https://github.com/apache/druid/pull/10406#issuecomment-695836785
(first) CI failure was legit... empty scss blocks are not allowed by the linter. TY for the review!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vogievetsky commented on pull request #10406: Web console: fix lookup edit dialog, allow column renaming
Posted by GitBox <gi...@apache.org>.
vogievetsky commented on pull request #10406:
URL: https://github.com/apache/druid/pull/10406#issuecomment-695836785
(first) CI failure was legit... empty scss blocks are not allowed by the linter. TY for the review!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vogievetsky merged pull request #10406: Web console: fix lookup edit dialog, allow column renaming
Posted by GitBox <gi...@apache.org>.
vogievetsky merged pull request #10406:
URL: https://github.com/apache/druid/pull/10406
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org