You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@eagle.apache.org by ha...@apache.org on 2016/09/01 03:31:29 UTC
incubator-eagle git commit: [EAGLE-498] overwrite equals method for PolicyDefinition should not con…
Repository: incubator-eagle
Updated Branches:
refs/heads/develop c940f56c2 -> e77877518
[EAGLE-498] overwrite equals method for PolicyDefinition should not con\u2026
EAGLE-498 overwrite equals method for PolicyDefinition should not contain field description
- Delete the equals for description in method equals.
- Delete append description in method hashCode.
https://issues.apache.org/jira/browse/EAGLE-498
Author: chitin <ch...@gmail.com>
Closes #384 from chitin/EAGLE498.
Project: http://git-wip-us.apache.org/repos/asf/incubator-eagle/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-eagle/commit/e7787751
Tree: http://git-wip-us.apache.org/repos/asf/incubator-eagle/tree/e7787751
Diff: http://git-wip-us.apache.org/repos/asf/incubator-eagle/diff/e7787751
Branch: refs/heads/develop
Commit: e77877518ba0cba6cbd3c20ccd0d040c5a3cd86b
Parents: c940f56
Author: chitin <ch...@gmail.com>
Authored: Thu Sep 1 11:31:19 2016 +0800
Committer: Hao Chen <ha...@apache.org>
Committed: Thu Sep 1 11:31:19 2016 +0800
----------------------------------------------------------------------
.../apache/eagle/alert/engine/coordinator/PolicyDefinition.java | 2 --
1 file changed, 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-eagle/blob/e7787751/eagle-core/eagle-alert-parent/eagle-alert/alert-common/src/main/java/org/apache/eagle/alert/engine/coordinator/PolicyDefinition.java
----------------------------------------------------------------------
diff --git a/eagle-core/eagle-alert-parent/eagle-alert/alert-common/src/main/java/org/apache/eagle/alert/engine/coordinator/PolicyDefinition.java b/eagle-core/eagle-alert-parent/eagle-alert/alert-common/src/main/java/org/apache/eagle/alert/engine/coordinator/PolicyDefinition.java
index e2dfb6f..0dca247 100644
--- a/eagle-core/eagle-alert-parent/eagle-alert/alert-common/src/main/java/org/apache/eagle/alert/engine/coordinator/PolicyDefinition.java
+++ b/eagle-core/eagle-alert-parent/eagle-alert/alert-common/src/main/java/org/apache/eagle/alert/engine/coordinator/PolicyDefinition.java
@@ -129,7 +129,6 @@ public class PolicyDefinition implements Serializable{
public int hashCode() {
return new HashCodeBuilder().
append(name).
- append(description).
append(inputStreams).
append(outputStreams).
append(definition).
@@ -146,7 +145,6 @@ public class PolicyDefinition implements Serializable{
return false;
PolicyDefinition another = (PolicyDefinition)that;
if(another.name.equals(this.name) &&
- another.description.equals(this.description) &&
CollectionUtils.isEqualCollection(another.inputStreams, this.inputStreams) &&
CollectionUtils.isEqualCollection(another.outputStreams, this.outputStreams) &&
another.definition.equals(this.definition) &&