You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/10 00:45:45 UTC
[GitHub] [flink] paul8263 opened a new pull request #18308: [FLINK-25471][streaming-java] Wrong result if table transforms to Dat…
paul8263 opened a new pull request #18308:
URL: https://github.com/apache/flink/pull/18308
…aStream and then keyBy sum in Batch Mode
## What is the purpose of the change
Fix BatchGroupedReduceOperator does not output latest value right before task manager exits.
## Brief change log
- flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/BatchGroupedReduceOperator.java
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18308: [FLINK-25471][streaming-java] Wrong result if table transforms to Dat…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18308:
URL: https://github.com/apache/flink/pull/18308#issuecomment-1008462604
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 54fc3f36107a6afabffb7d62a9034e0c60429a12 (Mon Jan 10 00:50:29 UTC 2022)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18308: [FLINK-25471][streaming-java] Wrong result if table transforms to Dat…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18308:
URL: https://github.com/apache/flink/pull/18308#issuecomment-1008462182
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "54fc3f36107a6afabffb7d62a9034e0c60429a12",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29152",
"triggerID" : "54fc3f36107a6afabffb7d62a9034e0c60429a12",
"triggerType" : "PUSH"
}, {
"hash" : "08443e0b37df7cae26379309ce99954a531b422f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29154",
"triggerID" : "08443e0b37df7cae26379309ce99954a531b422f",
"triggerType" : "PUSH"
}, {
"hash" : "1192049c76b9c5648ebc13f422b48098ad442a14",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1192049c76b9c5648ebc13f422b48098ad442a14",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 08443e0b37df7cae26379309ce99954a531b422f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29154)
* 1192049c76b9c5648ebc13f422b48098ad442a14 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18308: [FLINK-25471][streaming-java] Wrong result if table transforms to Dat…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18308:
URL: https://github.com/apache/flink/pull/18308#issuecomment-1008462182
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "54fc3f36107a6afabffb7d62a9034e0c60429a12",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29152",
"triggerID" : "54fc3f36107a6afabffb7d62a9034e0c60429a12",
"triggerType" : "PUSH"
}, {
"hash" : "08443e0b37df7cae26379309ce99954a531b422f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29154",
"triggerID" : "08443e0b37df7cae26379309ce99954a531b422f",
"triggerType" : "PUSH"
}, {
"hash" : "1192049c76b9c5648ebc13f422b48098ad442a14",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29286",
"triggerID" : "1192049c76b9c5648ebc13f422b48098ad442a14",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 08443e0b37df7cae26379309ce99954a531b422f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29154)
* 1192049c76b9c5648ebc13f422b48098ad442a14 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29286)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18308: [FLINK-25471][streaming-java] Wrong result if table transforms to Dat…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18308:
URL: https://github.com/apache/flink/pull/18308#issuecomment-1008462182
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "54fc3f36107a6afabffb7d62a9034e0c60429a12",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "54fc3f36107a6afabffb7d62a9034e0c60429a12",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 54fc3f36107a6afabffb7d62a9034e0c60429a12 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18308: [FLINK-25471][streaming-java] Wrong result if table transforms to Dat…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18308:
URL: https://github.com/apache/flink/pull/18308#issuecomment-1008462182
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "54fc3f36107a6afabffb7d62a9034e0c60429a12",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29152",
"triggerID" : "54fc3f36107a6afabffb7d62a9034e0c60429a12",
"triggerType" : "PUSH"
}, {
"hash" : "08443e0b37df7cae26379309ce99954a531b422f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "08443e0b37df7cae26379309ce99954a531b422f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 54fc3f36107a6afabffb7d62a9034e0c60429a12 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29152)
* 08443e0b37df7cae26379309ce99954a531b422f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18308: [FLINK-25471][streaming-java] Wrong result if table transforms to Dat…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18308:
URL: https://github.com/apache/flink/pull/18308#issuecomment-1008462182
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "54fc3f36107a6afabffb7d62a9034e0c60429a12",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29152",
"triggerID" : "54fc3f36107a6afabffb7d62a9034e0c60429a12",
"triggerType" : "PUSH"
}, {
"hash" : "08443e0b37df7cae26379309ce99954a531b422f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29154",
"triggerID" : "08443e0b37df7cae26379309ce99954a531b422f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 54fc3f36107a6afabffb7d62a9034e0c60429a12 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29152)
* 08443e0b37df7cae26379309ce99954a531b422f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29154)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18308: [FLINK-25471][streaming-java] Wrong result if table transforms to Dat…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18308:
URL: https://github.com/apache/flink/pull/18308#issuecomment-1008462182
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "54fc3f36107a6afabffb7d62a9034e0c60429a12",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29152",
"triggerID" : "54fc3f36107a6afabffb7d62a9034e0c60429a12",
"triggerType" : "PUSH"
}, {
"hash" : "08443e0b37df7cae26379309ce99954a531b422f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29154",
"triggerID" : "08443e0b37df7cae26379309ce99954a531b422f",
"triggerType" : "PUSH"
}, {
"hash" : "1192049c76b9c5648ebc13f422b48098ad442a14",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29286",
"triggerID" : "1192049c76b9c5648ebc13f422b48098ad442a14",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1192049c76b9c5648ebc13f422b48098ad442a14 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29286)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18308: [FLINK-25471][streaming-java] Wrong result if table transforms to Dat…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18308:
URL: https://github.com/apache/flink/pull/18308#issuecomment-1008462182
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "54fc3f36107a6afabffb7d62a9034e0c60429a12",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29152",
"triggerID" : "54fc3f36107a6afabffb7d62a9034e0c60429a12",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 54fc3f36107a6afabffb7d62a9034e0c60429a12 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29152)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18308: [FLINK-25471][streaming-java] Wrong result if table transforms to Dat…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18308:
URL: https://github.com/apache/flink/pull/18308#issuecomment-1008462182
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "54fc3f36107a6afabffb7d62a9034e0c60429a12",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29152",
"triggerID" : "54fc3f36107a6afabffb7d62a9034e0c60429a12",
"triggerType" : "PUSH"
}, {
"hash" : "08443e0b37df7cae26379309ce99954a531b422f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29154",
"triggerID" : "08443e0b37df7cae26379309ce99954a531b422f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 54fc3f36107a6afabffb7d62a9034e0c60429a12 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29152)
* 08443e0b37df7cae26379309ce99954a531b422f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29154)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18308: [FLINK-25471][streaming-java] Wrong result if table transforms to Dat…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18308:
URL: https://github.com/apache/flink/pull/18308#issuecomment-1008462182
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "54fc3f36107a6afabffb7d62a9034e0c60429a12",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29152",
"triggerID" : "54fc3f36107a6afabffb7d62a9034e0c60429a12",
"triggerType" : "PUSH"
}, {
"hash" : "08443e0b37df7cae26379309ce99954a531b422f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29154",
"triggerID" : "08443e0b37df7cae26379309ce99954a531b422f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 08443e0b37df7cae26379309ce99954a531b422f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29154)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org