[kafka] branch 3.0 updated: HOTFIX: fix compilation error in StreamThreadTest (#12887)

[ab...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

ableegoldman pushed a commit to branch 3.0
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/3.0 by this push:
     new 8425daf92db HOTFIX: fix compilation error in StreamThreadTest (#12887)
8425daf92db is described below

commit 8425daf92db54e87727600c0a42323f46e52cfc0
Author: A. Sophie Blee-Goldman <so...@confluent.io>
AuthorDate: Tue Nov 22 01:32:32 2022 -0800

    HOTFIX: fix compilation error in StreamThreadTest (#12887)
    
    When I was cherrypicking the fix for
    KAFKA-14382 back to older branches, I had been running the StreamThreadTest on all versions before pushing the fix -- but when I got to 3.0, I began to hit some kind of problem with parsing the settings.gradle file and was unable to build in my local env. Since everything from 3.3 to 3.1 had passed so far I foolishly assumed
    the fix on 3.0 was fine as well and just pushed it.
    
    Clearly that was rash, as it turned out a method used in the new test did not exist back in 3.0, causing this commit to break the 3.0 branch. I was only able to figure this out when I opened a PR to sync this commit across other forks and the PR build failed due to the real compilation error rather than whatever was going on with my local gradle build.
    
    Anyways that's the story, and this is the fix.
---
 .../apache/kafka/streams/processor/internals/StreamThreadTest.java  | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamThreadTest.java b/streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamThreadTest.java
index f6496567d8b..51358260701 100644
--- a/streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamThreadTest.java
+++ b/streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamThreadTest.java
@@ -488,10 +488,8 @@ public class StreamThreadTest {
         final EasyMockConsumerClientSupplier mockClientSupplier = new EasyMockConsumerClientSupplier(mockConsumer);
         mockClientSupplier.setCluster(createCluster());
 
-        final TopologyMetadata topologyMetadata = new TopologyMetadata(internalTopologyBuilder, config);
-        topologyMetadata.buildAndRewriteTopology();
         final StreamThread thread = StreamThread.create(
-            topologyMetadata,
+            internalTopologyBuilder,
             config,
             mockClientSupplier,
             mockClientSupplier.getAdmin(config.getAdminConfigs(CLIENT_ID)),
@@ -548,8 +546,6 @@ public class StreamThreadTest {
         final EasyMockConsumerClientSupplier mockClientSupplier = new EasyMockConsumerClientSupplier(mockConsumer);
         mockClientSupplier.setCluster(createCluster());
 
-        final TopologyMetadata topologyMetadata = new TopologyMetadata(internalTopologyBuilder, config);
-        topologyMetadata.buildAndRewriteTopology();
         final StreamThread thread = StreamThread.create(
             internalTopologyBuilder,
             config,