You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by "Sönke Liebau (JIRA)" <ji...@apache.org> on 2018/12/05 10:15:00 UTC

[jira] [Commented] (KAFKA-7707) Some code is not necessary

    [ https://issues.apache.org/jira/browse/KAFKA-7707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16709870#comment-16709870 ] 

Sönke Liebau commented on KAFKA-7707:
-------------------------------------

Hi [~huangyiminghappy@163.com],

thanks for looking into this and opening a ticket!

I've taken the liberty of replacing your Intellij screenshot by a link to the relevant code on github, I hope that is ok with you.

 

Also, could you please explain why it is that you think this code will never be executed?

 

 

> Some code is not necessary
> --------------------------
>
>                 Key: KAFKA-7707
>                 URL: https://issues.apache.org/jira/browse/KAFKA-7707
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: huangyiming
>            Priority: Minor
>         Attachments: image-2018-12-05-18-01-46-886.png
>
>
> In the trunk branch in [BufferPool.java|https://github.com/apache/kafka/blob/578205cadd0bf64d671c6c162229c4975081a9d6/clients/src/main/java/org/apache/kafka/clients/producer/internals/BufferPool.java#L174], i think the code can clean,is not necessary,it will never execute
> {code:java}
> if (!(this.nonPooledAvailableMemory == 0 && this.free.isEmpty()) && !this.waiters.isEmpty())
>     this.waiters.peekFirst().signal();
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)