[GitHub] [pulsar] HQebupt commented on a diff in pull request #17394: [fix][storage]fix OpAddEntry release error when exception in ManagedLedgerInterceptor

[GitBox <gi...@apache.org>]

HQebupt commented on code in PR #17394:
URL: https://github.com/apache/pulsar/pull/17394#discussion_r963195717


##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/intercept/MangedLedgerInterceptorImplTest.java:
##########
@@ -256,6 +257,29 @@ public void testFindPositionByIndex() throws Exception {
         ledger.close();
     }
 
+    @Test
+    public void testBeforeAddEntryWithException() throws Exception {

Review Comment:
   There is no such error log with the bug fix in the test. Since the following error can not interrupt the normal execution, so it is hard to cover the error in a test case. Do you have any idea?
   ```
   ERROR - [test-OrderedScheduler-1-0:SafeRunnable@38] - Unexpected throwable caught 
   io.netty.util.IllegalReferenceCountException: refCnt: 0, decrement: 1
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org