You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/06/14 07:36:24 UTC
[GitHub] [superset] jinghua-qa opened a new issue #15129: [native filter] native filter on different datasets can take take effect on the dataset not in configuration when 'apply to all panel' is selected.
jinghua-qa opened a new issue #15129:
URL: https://github.com/apache/superset/issues/15129
native filter on different data sets can take take effect on the dataset not in configuration when 'apply to all panel' is selected
For example, i have 2 charts in a dashboard:
time gain filter control chart from dataset: cleaned_sales_data
### How to reproduce the bug
1, create Time column filter test:
a. use 'FCC survey 2018' data set, edit dataset, select is temporal for 'time_end'
b, create time series chart using time column 'time end', metric 'MAX(month_job_search)User create time series chart using time column 'time end', metric 'MAX(month_job_search) add to dashboard
c. create time column native filter in dashboard and set dataset to be 'FCC survey 2018', apply to all panel
2, create Time grain filter test:
a, use 'cleaned_sales_data' and create time-series chart on sum (sales)
b, create time grain native filter on 'cleaned_sales_data' dataset and apply to all panel
3, apply time column filter and time grain filter to observe change
### Expected results
time column filter only take effect on the 'FCC survey 2018' time series chart and time grain filter only take effect on 'clean_sales_data' time series chart
### Actual results
time column filter and time grain filter take effect on both chart
#### Screenshots
<img width="1792" alt="Screen Shot 2021-06-10 at 8 53 07 PM" src="https://user-images.githubusercontent.com/81597121/121756837-54d22a80-cad0-11eb-8281-8d5031b63cb7.png">
<img width="1787" alt="Screen Shot 2021-06-10 at 8 53 17 PM" src="https://user-images.githubusercontent.com/81597121/121756839-57348480-cad0-11eb-8bbe-b45d9182ce2e.png">
https://user-images.githubusercontent.com/81597121/121756866-73d0bc80-cad0-11eb-8571-67e7bc8acfc3.mov
### Environment
superset master
### Checklist
Make sure to follow these steps before submitting your issue - thank you!
- [x] I have checked the issue tracker for the same issue and I haven't found one similar.
### Additional context
Add any other context about the problem here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] simcha90 commented on issue #15129: [native filter] native filter on different datasets can take effect on the dataset not in configuration when 'apply to all panel' is selected.
Posted by GitBox <gi...@apache.org>.
simcha90 commented on issue #15129:
URL: https://github.com/apache/superset/issues/15129#issuecomment-873557471
@junlincc I'll take a look this issue
About 2. I don't think that we need restrict it on scoping side, because of 2 reasons:
a. We apply scoping per chart and not per data in chart, so if in explore some chart will be changed it will not affect saved metadata in other filters
b. It more similar to rejected columns, so we need copy this behavior I think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jinghua-qa closed issue #15129: [native filter] native filter on different datasets can take effect on the dataset not in configuration when 'apply to all panel' is selected.
Posted by GitBox <gi...@apache.org>.
jinghua-qa closed issue #15129:
URL: https://github.com/apache/superset/issues/15129
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] simcha90 commented on issue #15129: [native filter] native filter on different datasets can take effect on the dataset not in configuration when 'apply to all panel' is selected.
Posted by GitBox <gi...@apache.org>.
simcha90 commented on issue #15129:
URL: https://github.com/apache/superset/issues/15129#issuecomment-873557690
Also we have such notification for some cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jinghua-qa removed a comment on issue #15129: [native filter] native filter on different datasets can take effect on the dataset not in configuration when 'apply to all panel' is selected.
Posted by GitBox <gi...@apache.org>.
jinghua-qa removed a comment on issue #15129:
URL: https://github.com/apache/superset/issues/15129#issuecomment-879518315
Checked on the latest master, the current behavior is : on the scope tab, filter only apply to the chart with the dataset selected in filter configuration by default, but i still be able to change to ‘apply all’ and then i will be able to repro this issue. My question is : should we disable 'Apply all' or give warning when select 'Apply all' if filter A is configured to dataset A and filter B is configured to dataset B?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jinghua-qa commented on issue #15129: [native filter] native filter on different datasets can take effect on the dataset not in configuration when 'apply to all panel' is selected.
Posted by GitBox <gi...@apache.org>.
jinghua-qa commented on issue #15129:
URL: https://github.com/apache/superset/issues/15129#issuecomment-879537870
Checked with the latest master, do see filters configured to different dataset is apply to specific panels and also saw the warning sign. Thank you for the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jinghua-qa commented on issue #15129: [native filter] native filter on different datasets can take effect on the dataset not in configuration when 'apply to all panel' is selected.
Posted by GitBox <gi...@apache.org>.
jinghua-qa commented on issue #15129:
URL: https://github.com/apache/superset/issues/15129#issuecomment-879518315
Checked on the latest master, the current behavior is : on the scope tab, filter only apply to the chart with the dataset selected in filter configuration by default, but i still be able to change to ‘apply all’ and then i will be able to repro this issue. My question is : should we disable 'Apply all' or give warning when select 'Apply all' if filter A is configured to dataset A and filter B is configured to dataset B?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #15129: [native filter] native filter on different datasets can take take effect on the dataset not in configuration when 'apply to all panel' is selected.
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #15129:
URL: https://github.com/apache/superset/issues/15129#issuecomment-859976750
question for the team:
1. time range filter doesn't need to specify dataset and temporal column, what about time grain?
2. also, when charts on a dashboard are powered by multiple datasets, one/some of the charts are powered by a dataset that have multiple time columns -> time column filter, what should other charts behave? should we restrict on the scoping side? if not, should we show errors on charts that can't be overwriten?
@villebro @zhaoyongjie
@jinghua-qa 2nd is quite an extreme case and possibly lead to scope creep) getting # 1 figured out is good enough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org