You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by Jay Vyas <ja...@gmail.com> on 2014/05/10 02:27:10 UTC

commons logging : should we get rid of it?

Hi bigtop !

Shall we work to start getting rid of commons logging, as hadoop is doing
?  I see its a dependency of itest.

+--- org.apache.bigtop.itest:itest-common:0.7.0
|    +--- org.codehaus.groovy:groovy-all:1.8.6
|    +--- junit:junit:4.11
|    |    \--- org.hamcrest:hamcrest-core:1.3
|    +--- commons-logging:commons-logging:1.1 -> 1.1.1
|    +--- org.apache.ant:ant:1.8.2
|    |    \--- org.apache.ant:ant-launcher:1.8.2
|    \--- org.apache.ant:ant-junit:1.8.2
|         +--- org.apache.ant:ant:1.8.2 (*)
|         \--- junit:junit:3.8.2 -> 4.11 (*)

I personally dont like the way that it figures out how to log (there is
complex hierarchy of logic to it).

-- 
Jay Vyas
http://jayunit100.blogspot.com

Re: commons logging : should we get rid of it?

Posted by Mark Grover <ma...@apache.org>.
Hey Jay,
I am not sure what we as Bigtop can do here. We can perhaps use Bigtop as a
forcing function to encourage individual projects to move to slf4j (which
like you aptly put makes sense for various reasons) but I don't know how we
can do that work just by ourselves since we integrate what they (i.e.
'upstream' projects) ship.


On Mon, May 12, 2014 at 12:54 AM, Jay Vyas <ja...@gmail.com> wrote:

> Hi' folks... Okay here is my pitch for why we should move to slf4j.
>
> 1) hadoop is moving to use slf4j bindings asap,
>
> 2) hive actually is moving also to use slf4j: it's a known "bug" that hive
> has commons-logging bits floating around.
>
> Why so much fuss about logging? Because slf4j is easy to debug and manage,
> whereas commons logging is very tricky to debug (it is biased to log4j, has
> magic ways of setting up logging that can be tricky to unify on a large
> cluster, etc.
>
> > On May 11, 2014, at 11:44 PM, Mark Grover <ma...@apache.org> wrote:
> >
> > There are also other components in the stack that use it. See Hive for
> > example:
> > https://github.com/apache/hive/blob/trunk/pom.xml#L299
> >
> > Unless I am missing a good reason to remove it, I am personally happy
> with
> > the status-quo w.r.t. commons-logging.
> >
> >
> >> On Sat, May 10, 2014 at 9:32 PM, Konstantin Boudnik <co...@apache.org>
> wrote:
> >>
> >> What we are going to replace it with?
> >>
> >>> On Fri, May 09, 2014 at 08:27PM, Jay Vyas wrote:
> >>> Hi bigtop !
> >>>
> >>> Shall we work to start getting rid of commons logging, as hadoop is
> doing
> >>> ?  I see its a dependency of itest.
> >>>
> >>> +--- org.apache.bigtop.itest:itest-common:0.7.0
> >>> |    +--- org.codehaus.groovy:groovy-all:1.8.6
> >>> |    +--- junit:junit:4.11
> >>> |    |    \--- org.hamcrest:hamcrest-core:1.3
> >>> |    +--- commons-logging:commons-logging:1.1 -> 1.1.1
> >>> |    +--- org.apache.ant:ant:1.8.2
> >>> |    |    \--- org.apache.ant:ant-launcher:1.8.2
> >>> |    \--- org.apache.ant:ant-junit:1.8.2
> >>> |         +--- org.apache.ant:ant:1.8.2 (*)
> >>> |         \--- junit:junit:3.8.2 -> 4.11 (*)
> >>>
> >>> I personally dont like the way that it figures out how to log (there is
> >>> complex hierarchy of logic to it).
> >>>
> >>> --
> >>> Jay Vyas
> >>> http://jayunit100.blogspot.com
> >>
>

Re: commons logging : should we get rid of it?

Posted by Jay Vyas <ja...@gmail.com>.
Hi' folks... Okay here is my pitch for why we should move to slf4j.

1) hadoop is moving to use slf4j bindings asap, 

2) hive actually is moving also to use slf4j: it's a known "bug" that hive has commons-logging bits floating around.

Why so much fuss about logging? Because slf4j is easy to debug and manage, whereas commons logging is very tricky to debug (it is biased to log4j, has magic ways of setting up logging that can be tricky to unify on a large cluster, etc.

> On May 11, 2014, at 11:44 PM, Mark Grover <ma...@apache.org> wrote:
> 
> There are also other components in the stack that use it. See Hive for
> example:
> https://github.com/apache/hive/blob/trunk/pom.xml#L299
> 
> Unless I am missing a good reason to remove it, I am personally happy with
> the status-quo w.r.t. commons-logging.
> 
> 
>> On Sat, May 10, 2014 at 9:32 PM, Konstantin Boudnik <co...@apache.org> wrote:
>> 
>> What we are going to replace it with?
>> 
>>> On Fri, May 09, 2014 at 08:27PM, Jay Vyas wrote:
>>> Hi bigtop !
>>> 
>>> Shall we work to start getting rid of commons logging, as hadoop is doing
>>> ?  I see its a dependency of itest.
>>> 
>>> +--- org.apache.bigtop.itest:itest-common:0.7.0
>>> |    +--- org.codehaus.groovy:groovy-all:1.8.6
>>> |    +--- junit:junit:4.11
>>> |    |    \--- org.hamcrest:hamcrest-core:1.3
>>> |    +--- commons-logging:commons-logging:1.1 -> 1.1.1
>>> |    +--- org.apache.ant:ant:1.8.2
>>> |    |    \--- org.apache.ant:ant-launcher:1.8.2
>>> |    \--- org.apache.ant:ant-junit:1.8.2
>>> |         +--- org.apache.ant:ant:1.8.2 (*)
>>> |         \--- junit:junit:3.8.2 -> 4.11 (*)
>>> 
>>> I personally dont like the way that it figures out how to log (there is
>>> complex hierarchy of logic to it).
>>> 
>>> --
>>> Jay Vyas
>>> http://jayunit100.blogspot.com
>> 

Re: commons logging : should we get rid of it?

Posted by Mark Grover <ma...@apache.org>.
There are also other components in the stack that use it. See Hive for
example:
https://github.com/apache/hive/blob/trunk/pom.xml#L299

Unless I am missing a good reason to remove it, I am personally happy with
the status-quo w.r.t. commons-logging.


On Sat, May 10, 2014 at 9:32 PM, Konstantin Boudnik <co...@apache.org> wrote:

> What we are going to replace it with?
>
> On Fri, May 09, 2014 at 08:27PM, Jay Vyas wrote:
> > Hi bigtop !
> >
> > Shall we work to start getting rid of commons logging, as hadoop is doing
> > ?  I see its a dependency of itest.
> >
> > +--- org.apache.bigtop.itest:itest-common:0.7.0
> > |    +--- org.codehaus.groovy:groovy-all:1.8.6
> > |    +--- junit:junit:4.11
> > |    |    \--- org.hamcrest:hamcrest-core:1.3
> > |    +--- commons-logging:commons-logging:1.1 -> 1.1.1
> > |    +--- org.apache.ant:ant:1.8.2
> > |    |    \--- org.apache.ant:ant-launcher:1.8.2
> > |    \--- org.apache.ant:ant-junit:1.8.2
> > |         +--- org.apache.ant:ant:1.8.2 (*)
> > |         \--- junit:junit:3.8.2 -> 4.11 (*)
> >
> > I personally dont like the way that it figures out how to log (there is
> > complex hierarchy of logic to it).
> >
> > --
> > Jay Vyas
> > http://jayunit100.blogspot.com
>

Re: commons logging : should we get rid of it?

Posted by Konstantin Boudnik <co...@apache.org>.
What we are going to replace it with?

On Fri, May 09, 2014 at 08:27PM, Jay Vyas wrote:
> Hi bigtop !
> 
> Shall we work to start getting rid of commons logging, as hadoop is doing
> ?  I see its a dependency of itest.
> 
> +--- org.apache.bigtop.itest:itest-common:0.7.0
> |    +--- org.codehaus.groovy:groovy-all:1.8.6
> |    +--- junit:junit:4.11
> |    |    \--- org.hamcrest:hamcrest-core:1.3
> |    +--- commons-logging:commons-logging:1.1 -> 1.1.1
> |    +--- org.apache.ant:ant:1.8.2
> |    |    \--- org.apache.ant:ant-launcher:1.8.2
> |    \--- org.apache.ant:ant-junit:1.8.2
> |         +--- org.apache.ant:ant:1.8.2 (*)
> |         \--- junit:junit:3.8.2 -> 4.11 (*)
> 
> I personally dont like the way that it figures out how to log (there is
> complex hierarchy of logic to it).
> 
> -- 
> Jay Vyas
> http://jayunit100.blogspot.com