[GitHub] [spark] HyukjinKwon commented on a change in pull request #26866: [WIP][SPARK-30237][SQL] Move `sql()` method from DataType to AbstractTypemv sql method

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #26866: [WIP][SPARK-30237][SQL] Move `sql()` method from DataType to AbstractTypemv sql method
URL: https://github.com/apache/spark/pull/26866#discussion_r357462903
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/AbstractDataType.scala
 ##########
 @@ -47,6 +49,8 @@ private[sql] abstract class AbstractDataType {
 
   /** Readable string representation for the type. */
   private[sql] def simpleString: String
+
+  def sql: String = simpleString.toUpperCase(Locale.ROOT)
 
 Review comment:
   Should use catalogString. Otherwise, it truncates if it's long in, for instance, struct type.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org