You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/03 06:32:19 UTC

[GitHub] [spark] c21 edited a comment on pull request #31708: [SPARK-34593][SQL] Preserve broadcast nested loop join partitioning and ordering

c21 edited a comment on pull request #31708:
URL: https://github.com/apache/spark/pull/31708#issuecomment-789474307


   @cloud-fan - thanks for review.
   
   > Can you help to improve the test framework to include the number of shuffles, reused shuffles, subqueries, and reused subqueries in the golden files?
   
   Sure. I agree this it, and I also found plan check during test failure is quite hard for complicated query. I am actually thinking to add information for ALL physical operators.
   
   The added content like:
   
   ```
   Total number of operators: 6
   HashAggregate: 3
   Exchange: 2
   Scan: 1
   ```
   
   WDYT?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org