You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Niklas Quarfot Nielsen (JIRA)" <ji...@apache.org> on 2015/06/17 23:42:00 UTC
[jira] [Commented] (MESOS-2673) Follow Google Style Guide for
header file include order completely.
[ https://issues.apache.org/jira/browse/MESOS-2673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14590666#comment-14590666 ]
Niklas Quarfot Nielsen commented on MESOS-2673:
-----------------------------------------------
[~js84] Are you getting reviews on this? I was a bit confused about the proposal directory - is that new?
> Follow Google Style Guide for header file include order completely.
> -------------------------------------------------------------------
>
> Key: MESOS-2673
> URL: https://issues.apache.org/jira/browse/MESOS-2673
> Project: Mesos
> Issue Type: Improvement
> Reporter: Joerg Schad
> Assignee: Joerg Schad
> Priority: Minor
> Fix For: 0.23.0
>
>
> The header include order for Mesos actually follows the Google Styleguide but omits step 1 without mentioning this exception in the Mesos styleguide. This proposal suggests to adapt to the include order explained in the Google Styleguide i.e. include the direct headers first in the .cpp files implementing them.
> A gist of the proposal can be found here:
> https://gist.github.com/joerg84/65cb9611d24b2e35b69b
> The corresponding Review Board review can be found here:
> https://reviews.apache.org/r/33646/
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)