You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/08/24 12:41:05 UTC
[GitHub] [shardingsphere] azexcy opened a new pull request, #20498: Reopen openGauss IT and fix the problem at IT cases.
azexcy opened a new pull request, #20498:
URL: https://github.com/apache/shardingsphere/pull/20498
Changes proposed in this pull request:
- Reopen opengauss IT and fix the problem at IT cases.
- openGauss check privilege add SYSADMIN
- Improve data source prepare
- reopen openGauss ci
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #20498: Reopen openGauss IT and fix the problem at IT cases.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #20498:
URL: https://github.com/apache/shardingsphere/pull/20498#issuecomment-1225807504
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/20498?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#20498](https://codecov.io/gh/apache/shardingsphere/pull/20498?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cba0b65) into [master](https://codecov.io/gh/apache/shardingsphere/commit/84917c3bc33a6fd4e716eb75891eae7ac04b61c9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (84917c3) will **decrease** coverage by `0.01%`.
> The diff coverage is `25.14%`.
```diff
@@ Coverage Diff @@
## master #20498 +/- ##
============================================
- Coverage 60.63% 60.61% -0.02%
+ Complexity 2415 2409 -6
============================================
Files 3918 3917 -1
Lines 54812 54740 -72
Branches 9282 9300 +18
============================================
- Hits 33235 33181 -54
+ Misses 18746 18728 -18
Partials 2831 2831
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/20498?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...engine/dml/ShadowUpdateStatementRoutingEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/20498/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvcm91dGUvZW5naW5lL2RtbC9TaGFkb3dVcGRhdGVTdGF0ZW1lbnRSb3V0aW5nRW5naW5lLmphdmE=) | `16.66% <0.00%> (+3.03%)` | :arrow_up: |
| [...ception/UnsupportedShadowInsertValueException.java](https://codecov.io/gh/apache/shardingsphere/pull/20498/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvcm91dGUvZXhjZXB0aW9uL1Vuc3VwcG9ydGVkU2hhZG93SW5zZXJ0VmFsdWVFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../parser/core/MigrationDistSQLStatementVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/20498/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1zaGFyZGluZy1kaXN0c3FsLXBhcnNlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvbWlncmF0aW9uL2Rpc3RzcWwvcGFyc2VyL2NvcmUvTWlncmF0aW9uRGlzdFNRTFN0YXRlbWVudFZpc2l0b3IuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...phere/infra/binder/SQLStatementContextFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/20498/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtYmluZGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9iaW5kZXIvU1FMU3RhdGVtZW50Q29udGV4dEZhY3RvcnkuamF2YQ==) | `15.95% <0.00%> (-0.35%)` | :arrow_down: |
| [...fra/binder/statement/dal/KillStatementContext.java](https://codecov.io/gh/apache/shardingsphere/pull/20498/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtYmluZGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9iaW5kZXIvc3RhdGVtZW50L2RhbC9LaWxsU3RhdGVtZW50Q29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...nfra/database/type/dialect/OracleDatabaseType.java](https://codecov.io/gh/apache/shardingsphere/pull/20498/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9kYXRhYmFzZS90eXBlL2RpYWxlY3QvT3JhY2xlRGF0YWJhc2VUeXBlLmphdmE=) | `91.66% <0.00%> (-8.34%)` | :arrow_down: |
| [...cutor/sql/prepare/driver/jdbc/StatementOption.java](https://codecov.io/gh/apache/shardingsphere/pull/20498/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9wcmVwYXJlL2RyaXZlci9qZGJjL1N0YXRlbWVudE9wdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...jdbc/core/connection/ShardingSphereConnection.java](https://codecov.io/gh/apache/shardingsphere/pull/20498/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9qZGJjL2NvcmUvY29ubmVjdGlvbi9TaGFyZGluZ1NwaGVyZUNvbm5lY3Rpb24uamF2YQ==) | `73.25% <0.00%> (ø)` | |
| [.../pipeline/api/metadata/PipelineColumnMetaData.java](https://codecov.io/gh/apache/shardingsphere/pull/20498/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGEvcGlwZWxpbmUvYXBpL21ldGFkYXRhL1BpcGVsaW5lQ29sdW1uTWV0YURhdGEuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...core/check/consistency/DataConsistencyChecker.java](https://codecov.io/gh/apache/shardingsphere/pull/20498/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL2NvcmUvY2hlY2svY29uc2lzdGVuY3kvRGF0YUNvbnNpc3RlbmN5Q2hlY2tlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| ... and [75 more](https://codecov.io/gh/apache/shardingsphere/pull/20498/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz commented on a diff in pull request #20498: Reopen openGauss IT and fix the problem at IT cases.
Posted by GitBox <gi...@apache.org>.
sandynz commented on code in PR #20498:
URL: https://github.com/apache/shardingsphere/pull/20498#discussion_r953770829
##########
shardingsphere-kernel/shardingsphere-data-pipeline/shardingsphere-data-pipeline-core/src/main/java/org/apache/shardingsphere/data/pipeline/scenario/migration/MigrationJobPreparer.java:
##########
@@ -100,15 +100,18 @@ private void prepareAndCheckTargetWithLock(final MigrationJobItemContext jobItem
String lockName = "prepare-" + jobConfig.getJobId();
LockContext lockContext = PipelineContext.getContextManager().getInstanceContext().getLockContext();
LockDefinition lockDefinition = new ExclusiveLockDefinition(lockName);
- JOB_API.persistJobItemProgress(jobItemContext);
if (lockContext.tryLock(lockDefinition, 180000)) {
log.info("try lock success, jobId={}, shardingItem={}", jobConfig.getJobId(), jobItemContext.getShardingItem());
+ if (null == JOB_API.getJobProgress(jobItemContext.getJobId())) {
+ JOB_API.persistJobItemProgress(jobItemContext);
+ }
Review Comment:
1, Seems `getJobProgress` won't return null.
2, Could we just check jobItemProgress?
##########
shardingsphere-kernel/shardingsphere-data-pipeline/shardingsphere-data-pipeline-dialect/shardingsphere-data-pipeline-postgresql/src/main/java/org/apache/shardingsphere/data/pipeline/postgresql/check/datasource/PostgreSQLDataSourceChecker.java:
##########
@@ -54,9 +54,11 @@ private void checkPrivilege(final DataSource dataSource) {
throw new PipelineJobPrepareFailedException(String.format("No role exists, rolname: %s.", metaData.getUserName()));
}
String isSuperRole = resultSet.getString("rolsuper");
+ // compatible openGauss database, role name is SYSADMIN;
+ String isSystemAdminRole = resultSet.getString("rolsystemadmin");
String isReplicationRole = resultSet.getString("rolreplication");
- log.info("checkPrivilege: isSuperRole: {}, isReplicationRole: {}", isSuperRole, isReplicationRole);
- if (StringUtils.equalsIgnoreCase(isSuperRole, "f") && StringUtils.equalsIgnoreCase(isReplicationRole, "f")) {
+ log.info("checkPrivilege: isSuperRole: {}, isReplicationRole: {}, isSystemAdminRole:{}", isSuperRole, isReplicationRole, isSystemAdminRole);
Review Comment:
Is it just available in openGauss? If it's, could we create a openGauss impl of DataSourceChecker?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz merged pull request #20498: Reopen openGauss IT and fix the problem at IT cases.
Posted by GitBox <gi...@apache.org>.
sandynz merged PR #20498:
URL: https://github.com/apache/shardingsphere/pull/20498
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org