You are viewing a plain text version of this content. The canonical link for it is here.

Posted to hdfs-issues@hadoop.apache.org by "Jason Lowe (JIRA)" <ji...@apache.org> on 2012/10/05 23:36:03 UTC

[jira] [Updated] (HDFS-3224) Bug in check for DN re-registration with different storage ID

     [ https://issues.apache.org/jira/browse/HDFS-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Lowe updated HDFS-3224:
-----------------------------

    Attachment: HDFS-3224.patch

Here's a quick-n-dirty patch that fixes the issue in my limited testing.  Host2NodeMap.getDatanodeByName was recently removed, so I added it back in.  It seems appropriate here although the name is unfortunate re: confusion about host vs. name.

Still needs a unit test, but posting now for feedback on whether we really should be using ip (host) vs ip:port (name).
                
> Bug in check for DN re-registration with different storage ID
> -------------------------------------------------------------
>
>                 Key: HDFS-3224
>                 URL: https://issues.apache.org/jira/browse/HDFS-3224
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Eli Collins
>            Priority: Minor
>         Attachments: HDFS-3224.patch
>
>
> DatanodeManager#registerDatanode checks the host to node map using an IP:port key, however the map is keyed on IP, so this check will always fail. It's performing the check to determine if a DN with the same IP and storage ID has already registered, and if so to remove this DN from the map and indicate that eg it's no longer hosting these blocks. This bug has been here forever.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira