[GitHub] [beam] suztomo commented on a diff in pull request #25724: [No need to review] Checking Beam 2.44.0 with Google Auth 1.12.2

["suztomo (via GitHub)" <gi...@apache.org>]

suztomo commented on code in PR #25724:
URL: https://github.com/apache/beam/pull/25724#discussion_r1127329360


##########
.test-infra/jenkins/CommonJobProperties.groovy:
##########
@@ -193,7 +193,7 @@ class CommonJobProperties {
     context.switches("-Dorg.gradle.vfs.watch=false")
 
     // Include dependency licenses when build docker images on Jenkins, see https://s.apache.org/zt68q
-    context.switches("-Pdocker-pull-licenses")

Review Comment:
   This has no effect. Probably Jenkins uses the file in the master branch (or somewhere not specific to branches)



##########
sdks/java/container/license_scripts/license_script.sh:
##########
@@ -16,6 +16,10 @@
 
 set -e
 
+echo "Hello, license_script.sh. Returning 0 for troubleshooting"
+exit 0

Review Comment:
   It worked:
   
   ```
   22:57:03 > Task :sdks:java:container:pullLicenses
   22:57:03 Hello, license_script.sh. Returning 0 for troubleshooting
   22:57:03 
   22:57:03 > Task :sdks:java:container:java8:copyJavaThirdPartyLicenses NO-SOURCE
   ```
   
   https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch_PR/244/console



##########
sdks/python/container/license_scripts/dep_urls_py.yaml:
##########
@@ -65,7 +65,7 @@ pip_dependencies:
     license: "https://raw.githubusercontent.com/fastavro/fastavro/master/LICENSE"
     notice: "https://raw.githubusercontent.com/fastavro/fastavro/master/NOTICE.txt"
   flatbuffers:
-    license: "https://raw.githubusercontent.com/google/flatbuffers/master/LICENSE.txt"
+    license: "https://raw.githubusercontent.com/google/flatbuffers/master/LICENSE"

Review Comment:
   Somehow this didn't resolve the license check failure.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org