You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by se...@apache.org on 2013/09/22 02:31:28 UTC
svn commit: r1525304 - in /jmeter/trunk:
src/core/org/apache/jmeter/swing/HtmlPane.java xdocs/changes.xml
Author: sebb
Date: Sun Sep 22 00:31:28 2013
New Revision: 1525304
URL: http://svn.apache.org/r1525304
Log:
Help pane does not scroll to start for <a href="#"> links
Bugzilla Id: 55580
Modified:
jmeter/trunk/src/core/org/apache/jmeter/swing/HtmlPane.java
jmeter/trunk/xdocs/changes.xml
Modified: jmeter/trunk/src/core/org/apache/jmeter/swing/HtmlPane.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/swing/HtmlPane.java?rev=1525304&r1=1525303&r2=1525304&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/swing/HtmlPane.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/swing/HtmlPane.java Sun Sep 22 00:31:28 2013
@@ -18,6 +18,8 @@
package org.apache.jmeter.swing;
+import java.awt.Rectangle;
+
import javax.swing.JTextPane;
import javax.swing.event.HyperlinkEvent;
import javax.swing.event.HyperlinkListener;
@@ -39,9 +41,13 @@ public class HtmlPane extends JTextPane
public void hyperlinkUpdate(HyperlinkEvent e) {
if (e.getEventType() == HyperlinkEvent.EventType.ACTIVATED) {
String ref = e.getURL().getRef();
- if (ref != null && ref.length() > 0) {
- log.debug("reference to scroll to = " + ref);
- scrollToReference(ref);
+ if (ref != null) {
+ log.debug("reference to scroll to = '" + ref + "'");
+ if (ref.length() > 0) {
+ scrollToReference(ref);
+ } else { // href="#"
+ scrollRectToVisible(new Rectangle(1,1,1,1));
+ }
}
}
}
Modified: jmeter/trunk/xdocs/changes.xml
URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.xml?rev=1525304&r1=1525303&r2=1525304&view=diff
==============================================================================
--- jmeter/trunk/xdocs/changes.xml (original)
+++ jmeter/trunk/xdocs/changes.xml Sun Sep 22 00:31:28 2013
@@ -354,6 +354,7 @@ To revert to previous behaviour, set the
<li><bugzilla>54152</bugzilla> - In distributed testing : activeThreads always show 0 in GUI and Summariser</li>
<li><bugzilla>55509</bugzilla> - Allow Plugins to be notified of remote thread number progression</li>
<li><bugzilla>55572</bugzilla> - Detail popup of parameter does not show a Scrollbar when content exceeds display</li>
+<li><bugzilla>55580</bugzilla> - Help pane does not scroll to start for <a href="#"> links</li>
</ul>
<!-- =================== Improvements =================== -->