You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2019/03/06 01:30:45 UTC
[Impala-ASF-CR] IMPALA-8286: fix accounting error on stress client exit
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12675
Change subject: IMPALA-8286: fix accounting error on stress client exit
......................................................................
IMPALA-8286: fix accounting error on stress client exit
Testing:
Ran some cluster stress tests with this change.
Change-Id: I389eb3a439f3c33dd192814cb80c9ca2bd8c5790
---
M tests/stress/concurrent_select.py
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/75/12675/1
--
To view, visit http://gerrit.cloudera.org:8080/12675
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I389eb3a439f3c33dd192814cb80c9ca2bd8c5790
Gerrit-Change-Number: 12675
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8286: fix accounting error on stress client exit
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12675 )
Change subject: IMPALA-8286: fix accounting error on stress client exit
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12675
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I389eb3a439f3c33dd192814cb80c9ca2bd8c5790
Gerrit-Change-Number: 12675
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 16 Mar 2019 02:29:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8286: fix accounting error on stress client exit
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12675 )
Change subject: IMPALA-8286: fix accounting error on stress client exit
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3916/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12675
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I389eb3a439f3c33dd192814cb80c9ca2bd8c5790
Gerrit-Change-Number: 12675
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 Mar 2019 22:23:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8286: fix accounting error on stress client exit
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/12675 )
Change subject: IMPALA-8286: fix accounting error on stress client exit
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12675
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I389eb3a439f3c33dd192814cb80c9ca2bd8c5790
Gerrit-Change-Number: 12675
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 Mar 2019 21:42:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8286: fix accounting error on stress client exit
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12675 )
Change subject: IMPALA-8286: fix accounting error on stress client exit
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2368/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12675
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I389eb3a439f3c33dd192814cb80c9ca2bd8c5790
Gerrit-Change-Number: 12675
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Mar 2019 01:54:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8286: fix accounting error on stress client exit
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12675 )
Change subject: IMPALA-8286: fix accounting error on stress client exit
......................................................................
IMPALA-8286: fix accounting error on stress client exit
Testing:
Ran some cluster stress tests with this change.
Change-Id: I389eb3a439f3c33dd192814cb80c9ca2bd8c5790
Reviewed-on: http://gerrit.cloudera.org:8080/12675
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/stress/concurrent_select.py
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/12675
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I389eb3a439f3c33dd192814cb80c9ca2bd8c5790
Gerrit-Change-Number: 12675
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-8286: fix accounting error on stress client exit
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12675 )
Change subject: IMPALA-8286: fix accounting error on stress client exit
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12675
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I389eb3a439f3c33dd192814cb80c9ca2bd8c5790
Gerrit-Change-Number: 12675
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 Mar 2019 22:23:58 +0000
Gerrit-HasComments: No