You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tez.apache.org by "Aggarwal-Raghav (via GitHub)" <gi...@apache.org> on 2026/07/31 16:02:22 UTC
[PR] TEZ-4747: Upgrade mockito to 5.23.0 [tez]
Aggarwal-Raghav opened a new pull request, #529:
URL: https://github.com/apache/tez/pull/529
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4747: Upgrade mockito to 5.23.0 [tez]
Posted by "Aggarwal-Raghav (via GitHub)" <gi...@apache.org>.
Aggarwal-Raghav commented on PR #529:
URL: https://github.com/apache/tez/pull/529#issuecomment-5152331332
CC @abstractdog , requesting review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4747: Upgrade mockito to 5.23.0 [tez]
Posted by "tez-yetus (via GitHub)" <gi...@apache.org>.
tez-yetus commented on PR #529:
URL: https://github.com/apache/tez/pull/529#issuecomment-5148322484
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 10m 46s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +0 :ok: | xmllint | 0m 0s | | xmllint was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 4 new or modified test files. |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 41s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 28s | | master passed |
| +1 :green_heart: | compile | 4m 1s | | master passed |
| +1 :green_heart: | checkstyle | 2m 56s | | master passed |
| +1 :green_heart: | javadoc | 3m 41s | | master passed |
| +0 :ok: | spotbugs | 1m 20s | | tez-api in master has 92 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 53s | | tez-runtime-internals in master has 92 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 1m 10s | | tez-runtime-library in master has 143 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 43s | | tez-plugins/tez-yarn-timeline-history in master has 2 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 6m 27s | | root in master has 1054 extant spotbugs warnings. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 45s | | the patch passed |
| +1 :green_heart: | codespell | 1m 36s | | No new issues. |
| +1 :green_heart: | compile | 3m 58s | | the patch passed |
| +1 :green_heart: | javac | 3m 58s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | checkstyle | 2m 52s | | the patch passed |
| +1 :green_heart: | javadoc | 3m 38s | | the patch passed |
| +1 :green_heart: | spotbugs | 11m 36s | | the patch passed |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 77m 33s | | root in the patch passed. |
| +1 :green_heart: | asflicense | 2m 39s | | The patch does not generate ASF License warnings. |
| | | 148m 45s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.55 ServerAPI=1.55 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-529/3/artifact/out/Dockerfile |
| Optional Tests | dupname compile unit asflicense javac javadoc codespell detsecrets xmllint spotbugs checkstyle |
| uname | Linux bcfbae048548 5.15.0-181-generic #191-Ubuntu SMP Fri May 22 19:09:02 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | tez-personality.sh |
| git revision | master / d348bf1f18a4fac1f3fc38710131b8df7a18be1a |
| Default Java | Eclipse Adoptium-21.0.11+10-LTS |
| Test Results | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-529/3/testReport/ |
| Max. process+thread count | 2121 (vs. ulimit of 5500) |
| modules | C: tez-api tez-runtime-internals tez-runtime-library tez-plugins/tez-yarn-timeline-history . U: . |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-529/3/console |
| versions | git=2.43.0 maven=3.9.15 spotbugs=4.9.3 codespell=2.4.1 |
| Powered by | Apache Yetus 0.15.1 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4747: Upgrade mockito to 5.23.0 [tez]
Posted by "Aggarwal-Raghav (via GitHub)" <gi...@apache.org>.
Aggarwal-Raghav commented on code in PR #529:
URL: https://github.com/apache/tez/pull/529#discussion_r3691779066
##########
tez-api/src/test/java/org/apache/tez/client/TestTezClient.java:
##########
@@ -382,7 +382,7 @@ public void testGetClient() throws Exception {
client2.stop();
verify(client2.sessionAmProxy, times(1)).shutdownSession(any(),
any());
- verify(client2.mockYarnClient, times(1)).stop();
+ verify(client2.mockYarnClient, times(1)).close();
Review Comment:
Mockito4 couldn't mock final methods and `yarnClient.close()` was final so it was checking for `stop()` in AbstractService.java
```
@Override
public final void close() throws IOException {
stop();
}
```
But in Mockito 5 it can mock final method so it will test for `close()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4747: Upgrade mockito to 5.23.0 [tez]
Posted by "tez-yetus (via GitHub)" <gi...@apache.org>.
tez-yetus commented on PR #529:
URL: https://github.com/apache/tez/pull/529#issuecomment-5145809355
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 3m 15s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +0 :ok: | xmllint | 0m 0s | | xmllint was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 2 new or modified test files. |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 39s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 54s | | master passed |
| +1 :green_heart: | compile | 2m 35s | | master passed |
| +1 :green_heart: | checkstyle | 1m 24s | | master passed |
| +1 :green_heart: | javadoc | 1m 54s | | master passed |
| +0 :ok: | spotbugs | 0m 51s | | tez-api in master has 92 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 42s | | tez-runtime-library in master has 143 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 3m 52s | | root in master has 1054 extant spotbugs warnings. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 23s | | the patch passed |
| +1 :green_heart: | codespell | 0m 49s | | No new issues. |
| +1 :green_heart: | compile | 2m 36s | | the patch passed |
| +1 :green_heart: | javac | 2m 36s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | checkstyle | 1m 12s | | the patch passed |
| +1 :green_heart: | javadoc | 1m 45s | | the patch passed |
| +1 :green_heart: | spotbugs | 5m 50s | | the patch passed |
|||| _ Other Tests _ |
| -1 :x: | unit | 61m 22s | [/patch-unit-root.txt](https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-529/1/artifact/out/patch-unit-root.txt) | root in the patch passed. |
| +1 :green_heart: | asflicense | 1m 15s | | The patch does not generate ASF License warnings. |
| | | 97m 43s | | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | tez.dag.history.logging.ats.TestATSHistoryLoggingService |
| | tez.runtime.api.impl.TestProcessorContext |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.55 ServerAPI=1.55 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-529/1/artifact/out/Dockerfile |
| Optional Tests | dupname compile unit asflicense javac javadoc codespell detsecrets xmllint spotbugs checkstyle |
| uname | Linux bed0c3626bb3 5.15.0-179-generic #189-Ubuntu SMP Tue May 5 18:20:56 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | tez-personality.sh |
| git revision | master / d348bf1f18a4fac1f3fc38710131b8df7a18be1a |
| Default Java | Eclipse Adoptium-21.0.11+10-LTS |
| Test Results | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-529/1/testReport/ |
| Max. process+thread count | 1408 (vs. ulimit of 5500) |
| modules | C: tez-api tez-runtime-library . U: . |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-529/1/console |
| versions | git=2.43.0 maven=3.9.15 spotbugs=4.9.3 codespell=2.4.1 |
| Powered by | Apache Yetus 0.15.1 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4747: Upgrade mockito to 5.23.0 [tez]
Posted by "Aggarwal-Raghav (via GitHub)" <gi...@apache.org>.
Aggarwal-Raghav commented on code in PR #529:
URL: https://github.com/apache/tez/pull/529#discussion_r3691712627
##########
tez-api/src/test/java/org/apache/tez/client/TestTezClient.java:
##########
@@ -382,7 +382,7 @@ public void testGetClient() throws Exception {
client2.stop();
verify(client2.sessionAmProxy, times(1)).shutdownSession(any(),
any());
- verify(client2.mockYarnClient, times(1)).stop();
+ verify(client2.mockYarnClient, times(1)).close();
Review Comment:
<img width="1512" height="755" alt="Image" src="https://github.com/user-attachments/assets/dbad001e-97ad-47c5-840e-f04b25feb4da" />
##########
tez-runtime-library/src/test/java/org/apache/tez/runtime/library/common/shuffle/TestShuffleUtils.java:
##########
@@ -398,14 +397,14 @@ public void testFetchStatsLogger() throws Exception {
logger.logIndividualFetchComplete(10, 100, 1000, "testType", ident);
}
verify(activeLogger, times(0)).info(anyString());
- verify(aggregateLogger, times(1)).info(anyString(), ArgumentMatchers.<Object[]>any());
+ verify(aggregateLogger, times(1)).info(anyString(), any(), any(), any(), any(), any());
Review Comment:
<img width="1155" height="520" alt="Image" src="https://github.com/user-attachments/assets/543057dd-916b-4e66-90b0-0401a16ecb08" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4747: Upgrade mockito to 5.23.0 [tez]
Posted by "Aggarwal-Raghav (via GitHub)" <gi...@apache.org>.
Aggarwal-Raghav commented on PR #529:
URL: https://github.com/apache/tez/pull/529#issuecomment-5414651703
gentle ping for review @abstractdog
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org