You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/10/25 18:49:28 UTC
[GitHub] [camel-k] dmarrazzo opened a new issue, #3775: KameletBinding in Error when prometheus trait is enabled
dmarrazzo opened a new issue, #3775:
URL: https://github.com/apache/camel-k/issues/3775
Hi all,
I'm trying to deploy a Kamelets which exposes custom metrics based on messages coming from kafka.
The KameletBinding works fine without the prometheus trait: the logs shows the expected behavior, but it does not expose the metric endpoint for scraping.
In this repository (ocp branch), you can find all the artifacts to reproduce the problem:
https://github.com/dmarrazzo/camel-quarkus-examples-metrics/tree/ocp
You can try the successful deployment commenting out those lines:
https://github.com/dmarrazzo/camel-quarkus-examples-metrics/blob/ocp/k8s/03-kafka-metrics-binding.yaml#L5-L6
Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] dmarrazzo commented on issue #3775: KameletBinding in Error when prometheus trait is enabled
Posted by GitBox <gi...@apache.org>.
dmarrazzo commented on issue #3775:
URL: https://github.com/apache/camel-k/issues/3775#issuecomment-1291751776
Hello, I've tested in `1.8.2` and I have the same behavior.
In that case if I remove the `trait` the build starts but it fails at runtime because the kamelet logic include that `jq` operand which is not supported in `1.8.2`.
I also did a different test applying the trait on a different KameletBinding (a very simple one: timer-log). In that case, the image build (integration kit) works and the kamelet exposes the metric endpoint without issues.
I suspect that this specific Kamelet fails because of the metric feature:
```yaml
dependencies:
- "camel:micrometer"
```
CC @lburgazzoli
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on issue #3775: KameletBinding in Error when prometheus trait is enabled
Posted by GitBox <gi...@apache.org>.
squakez commented on issue #3775:
URL: https://github.com/apache/camel-k/issues/3775#issuecomment-1291819588
> The reason is that the kamelet logic relies on that dependency: it adds a custom metric. However, I believe that if someone else add that dependency a possible workaround could be removing it from the Kamelet. I gonna test it and let you know soon.
Okey, thanks. Could the custom metric be implemented with mp metrics while we don't move to micrometric?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on issue #3775: KameletBinding in Error when prometheus trait is enabled
Posted by GitBox <gi...@apache.org>.
squakez commented on issue #3775:
URL: https://github.com/apache/camel-k/issues/3775#issuecomment-1291763804
Yes, we have an issue open about that: https://github.com/apache/camel-k/issues/1773. Is that dependency included in any of the Kamelet used? I wonder why we want to have it specified in the Kamelet instead of letting the operator in charge to manage that aspect accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] lburgazzoli commented on issue #3775: KameletBinding in Error when prometheus trait is enabled
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on issue #3775:
URL: https://github.com/apache/camel-k/issues/3775#issuecomment-1291760043
I think @dmarrazzo is right and the issue is related with the micrometer dependency because as today, if I'm not mistaking, we use mp-metrics for the prometheus trait hence there may be conflicts.
since mp-metrics is deprecated in favor of micrometer we should probably switch in camel k too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on issue #3775: KameletBinding in Error when prometheus trait is enabled
Posted by GitBox <gi...@apache.org>.
squakez commented on issue #3775:
URL: https://github.com/apache/camel-k/issues/3775#issuecomment-1291606613
Thanks for reporting. Tested on Camel K version `10.2`, likely a bug. Can you check if the same works against previous versions? ie, version `1.8`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] dmarrazzo commented on issue #3775: KameletBinding in Error when prometheus trait is enabled
Posted by GitBox <gi...@apache.org>.
dmarrazzo commented on issue #3775:
URL: https://github.com/apache/camel-k/issues/3775#issuecomment-1291771850
The reason is that the kamelet logic relies on that dependency: it adds a custom metric.
However, I believe that if someone else add that dependency a possible workaround could be removing it from the Kamelet.
I gonna test it and let you know soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] dmarrazzo commented on issue #3775: KameletBinding in Error when prometheus trait is enabled
Posted by GitBox <gi...@apache.org>.
dmarrazzo commented on issue #3775:
URL: https://github.com/apache/camel-k/issues/3775#issuecomment-1291825595
Hello @squakez, I confirm the workaround works:
https://github.com/dmarrazzo/camel-quarkus-examples-metrics/compare/ocp...dmarrazzo:camel-quarkus-examples-metrics:issue-3775-workaround
Thank you
I solved my specific use case, however, I believe this specific situation highlighted a weakness of the camel operator: the image build fails without a clue on the root cause (in this case a dependency clash).
Should I open a different issue or re-phrase this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on issue #3775: KameletBinding in Error when prometheus trait is enabled
Posted by GitBox <gi...@apache.org>.
squakez commented on issue #3775:
URL: https://github.com/apache/camel-k/issues/3775#issuecomment-1291834614
Yes, please, if the problem related to this issue is addressed, feel free to close it and open a new follow up issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] dmarrazzo closed issue #3775: KameletBinding in Error when prometheus trait is enabled
Posted by GitBox <gi...@apache.org>.
dmarrazzo closed issue #3775: KameletBinding in Error when prometheus trait is enabled
URL: https://github.com/apache/camel-k/issues/3775
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org