You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/02/02 04:11:46 UTC

[GitHub] jiazhai closed pull request #1098: Run checkstyle plugin at validate phase

jiazhai closed pull request #1098: Run checkstyle plugin at validate phase
URL: https://github.com/apache/bookkeeper/pull/1098
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/tests/bookkeeper-server-shaded-artifact-test/pom.xml b/tests/bookkeeper-server-shaded-artifact-test/pom.xml
index aa40a121c..73352afba 100644
--- a/tests/bookkeeper-server-shaded-artifact-test/pom.xml
+++ b/tests/bookkeeper-server-shaded-artifact-test/pom.xml
@@ -85,7 +85,8 @@
         </configuration>
         <executions>
           <execution>
-            <phase>test-compile</phase>
+            <id>checkstyle</id>
+            <phase>validate</phase>
             <goals>
               <goal>check</goal>
             </goals>
diff --git a/tests/bookkeeper-server-shaded-test/pom.xml b/tests/bookkeeper-server-shaded-test/pom.xml
index ec75a5384..d72d6caba 100644
--- a/tests/bookkeeper-server-shaded-test/pom.xml
+++ b/tests/bookkeeper-server-shaded-test/pom.xml
@@ -84,7 +84,8 @@
         </configuration>
         <executions>
           <execution>
-            <phase>test-compile</phase>
+            <id>checkstyle</id>
+            <phase>validate</phase>
             <goals>
               <goal>check</goal>
             </goals>
diff --git a/tests/bookkeeper-server-tests-shaded-test/pom.xml b/tests/bookkeeper-server-tests-shaded-test/pom.xml
index 3ee3fdf1e..5418f5a0b 100644
--- a/tests/bookkeeper-server-tests-shaded-test/pom.xml
+++ b/tests/bookkeeper-server-tests-shaded-test/pom.xml
@@ -104,7 +104,8 @@
         </configuration>
         <executions>
           <execution>
-            <phase>test-compile</phase>
+            <id>checkstyle</id>
+            <phase>validate</phase>
             <goals>
               <goal>check</goal>
             </goals>


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services