[jira] [Commented] (TEZ-3238) Shuffle service name should be configureable and should not be hardcoded to ‘mapreduce_shuffle’

["Kuhu Shukla (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-3238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15417956#comment-15417956 ] 

Kuhu Shukla commented on TEZ-3238:
----------------------------------

Thank you [~jeagles] for the patch!

Nit: The config field uses task_prefix for the variable value but uses TEZ_AM in the variable name,  {{TEZ_AM_SHUFFLE_AUXILIARY_SERVICE_ID(_DEFAULT)}}. May be changing the name to {{TEZ_SHUFFLE_AUXILIARY_SERVICE_ID}} or something similar would be better?

Other than that patch looks good.

> Shuffle service name should be configureable and should not be hardcoded to ‘mapreduce_shuffle’
> -----------------------------------------------------------------------------------------------
>
>                 Key: TEZ-3238
>                 URL: https://issues.apache.org/jira/browse/TEZ-3238
>             Project: Apache Tez
>          Issue Type: Sub-task
>    Affects Versions: 0.5.0
>            Reporter: Rob Leidle
>            Assignee: Jonathan Eagles
>         Attachments: TEZ-3238.1.patch
>
>
> In YARN there are no guarantees that a shuffle service with a specific name exists. The setting '
> yarn.nodemanager.aux-services’ can be filled with a list of names that can be defined by the Hadoop cluster administrator. It is merely by convention that many clusters have their MapReduce shuffle service named ‘mapreduce_shuffle’.
> Tez is hard-coded to use a shuffle service named ‘mapreduce_shuffle’: 
> https://github.com/apache/tez/blob/TEZ-8/tez-api/src/main/java/org/apache/tez/dag/api/TezConstants.java#L75. This name should be configureable. Also, this is a hidden dependency of Tez, we should add that the shuffle service is a dependency to the Tez documentation. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)