You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@iotdb.apache.org by 孙泽嵩 <sz...@mails.tsinghua.edu.cn> on 2020/10/16 01:58:45 UTC
[DISCUSS] Sync module with Mlog Snapshot
Hi all,
I have realized that sync module would encounter problems when mlog snapshot is opened and created, since it syncs mlog.txt one line by another.
I noticed that another PR [1] is related to mlog snapshot (and it also needs further tests ...),
So I wonder whether this bug should be fixed before or after this PR is merged.
What do you think? And is there anyone familiar with sync module?
[1] https://github.com/apache/iotdb/pull/1721
Best,
-----------------------------------
Zesong Sun
School of Software, Tsinghua University
孙泽嵩
清华大学 软件学院
Re: [DISCUSS] Sync module with Mlog Snapshot
Posted by Jialin Qiao <qj...@mails.tsinghua.edu.cn>.
Hi,
Better to disable the mlog snapshot by default before fixing it.
Thanks,
--
Jialin Qiao
School of Software, Tsinghua University
乔嘉林
清华大学 软件学院
> -----原始邮件-----
> 发件人: "孙泽嵩" <sz...@mails.tsinghua.edu.cn>
> 发送时间: 2020-10-19 10:42:50 (星期一)
> 收件人: dev@iotdb.apache.org
> 抄送:
> 主题: Re: [DISCUSS] Sync module with Mlog Snapshot
>
> Thanks, Chao! That’s reasonable : )
>
>
> Best,
> -----------------------------------
> Zesong Sun
> School of Software, Tsinghua University
>
> 孙泽嵩
> 清华大学 软件学院
>
> > 2020年10月18日 21:13，runhuster@foxmail.com 写道：
> >
> > hi Zesong,
> >
> > I think maybe we could just add warning before the fix it. I can try to fix it after we release version 0.11.0.
> >
> > How do you think?
> >
> >
> >
> > Thanks.
> >
> > Chao Wang
> > BONC Ltd
> >
> >
> > From: 孙泽嵩
> > Date: 2020-10-16 09:58
> > To: dev
> > Subject: [DISCUSS] Sync module with Mlog Snapshot
> > Hi all,
> >
> > I have realized that sync module would encounter problems when mlog snapshot is opened and created, since it syncs mlog.txt one line by another.
> >
> > I noticed that another PR [1] is related to mlog snapshot (and it also needs further tests ...),
> >
> > So I wonder whether this bug should be fixed before or after this PR is merged.
> >
> > What do you think? And is there anyone familiar with sync module?
> >
> >
> > [1] https://github.com/apache/iotdb/pull/1721
> >
> >
> > Best,
> > -----------------------------------
> > Zesong Sun
> > School of Software, Tsinghua University
> >
> > 孙泽嵩
> > 清华大学 软件学院
> >
>
Re: [DISCUSS] Sync module with Mlog Snapshot
Posted by 孙泽嵩 <sz...@mails.tsinghua.edu.cn>.
Thanks, Chao! That’s reasonable : )
Best,
-----------------------------------
Zesong Sun
School of Software, Tsinghua University
孙泽嵩
清华大学 软件学院
> 2020年10月18日 21:13，runhuster@foxmail.com 写道：
>
> hi Zesong,
>
> I think maybe we could just add warning before the fix it. I can try to fix it after we release version 0.11.0.
>
> How do you think?
>
>
>
> Thanks.
>
> Chao Wang
> BONC Ltd
>
>
> From: 孙泽嵩
> Date: 2020-10-16 09:58
> To: dev
> Subject: [DISCUSS] Sync module with Mlog Snapshot
> Hi all,
>
> I have realized that sync module would encounter problems when mlog snapshot is opened and created, since it syncs mlog.txt one line by another.
>
> I noticed that another PR [1] is related to mlog snapshot (and it also needs further tests ...),
>
> So I wonder whether this bug should be fixed before or after this PR is merged.
>
> What do you think? And is there anyone familiar with sync module?
>
>
> [1] https://github.com/apache/iotdb/pull/1721
>
>
> Best,
> -----------------------------------
> Zesong Sun
> School of Software, Tsinghua University
>
> 孙泽嵩
> 清华大学 软件学院
>
Re: [DISCUSS] Sync module with Mlog Snapshot
Posted by "runhuster@foxmail.com" <ru...@foxmail.com>.
hi Zesong,
I think maybe we could just add warning before the fix it. I can try to fix it after we release version 0.11.0.
How do you think?
Thanks.
Chao Wang
BONC Ltd
From: 孙泽嵩
Date: 2020-10-16 09:58
To: dev
Subject: [DISCUSS] Sync module with Mlog Snapshot
Hi all,
I have realized that sync module would encounter problems when mlog snapshot is opened and created, since it syncs mlog.txt one line by another.
I noticed that another PR [1] is related to mlog snapshot (and it also needs further tests ...),
So I wonder whether this bug should be fixed before or after this PR is merged.
What do you think? And is there anyone familiar with sync module?
[1] https://github.com/apache/iotdb/pull/1721
Best,
-----------------------------------
Zesong Sun
School of Software, Tsinghua University
孙泽嵩
清华大学 软件学院