You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by px...@apache.org on 2015/09/02 02:57:09 UTC
hive git commit: HIVE-11024: Error inserting a date value via
parameter marker (PreparedStatement.setDate) (Yongzhi Chen,
reviewed by Sergio Pena)
Repository: hive
Updated Branches:
refs/heads/branch-1.2 7a3e79fc0 -> dc121c72b
HIVE-11024: Error inserting a date value via parameter marker (PreparedStatement.setDate) (Yongzhi Chen, reviewed by Sergio Pena)
Project: http://git-wip-us.apache.org/repos/asf/hive/repo
Commit: http://git-wip-us.apache.org/repos/asf/hive/commit/dc121c72
Tree: http://git-wip-us.apache.org/repos/asf/hive/tree/dc121c72
Diff: http://git-wip-us.apache.org/repos/asf/hive/diff/dc121c72
Branch: refs/heads/branch-1.2
Commit: dc121c72b35693c61179f15115f3215a20ec7996
Parents: 7a3e79f
Author: Sergio Pena <se...@cloudera.com>
Authored: Thu Jul 16 07:28:16 2015 -0500
Committer: Pengcheng Xiong <px...@apache.org>
Committed: Tue Sep 1 17:48:38 2015 -0700
----------------------------------------------------------------------
.../java/org/apache/hive/jdbc/TestJdbcDriver2.java | 16 ++++++++++++++++
.../org/apache/hive/jdbc/HivePreparedStatement.java | 2 +-
2 files changed, 17 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hive/blob/dc121c72/itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java
----------------------------------------------------------------------
diff --git a/itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java b/itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java
index c0823b6..34ae18c 100644
--- a/itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java
+++ b/itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java
@@ -2346,4 +2346,20 @@ public void testParseUrlHttpMode() throws SQLException, JdbcUriParseException,
assertTrue(accumulatedLogs.contains(expectedLog));
}
}
+ @Test
+ public void testPrepareSetDate() throws Exception {
+ try {
+ String sql = "select * from " + dataTypeTableName + " where c20 = ?";
+ PreparedStatement ps = con.prepareStatement(sql);
+ java.sql.Date dtValue = java.sql.Date.valueOf("2013-01-01");
+ ps.setDate(1, dtValue);
+ ResultSet res = ps.executeQuery();
+ assertTrue(res.next());
+ assertEquals("2013-01-01", res.getString(20));
+ ps.close();
+ } catch (Exception e) {
+ e.printStackTrace();
+ fail(e.toString());
+ }
+ }
}
http://git-wip-us.apache.org/repos/asf/hive/blob/dc121c72/jdbc/src/java/org/apache/hive/jdbc/HivePreparedStatement.java
----------------------------------------------------------------------
diff --git a/jdbc/src/java/org/apache/hive/jdbc/HivePreparedStatement.java b/jdbc/src/java/org/apache/hive/jdbc/HivePreparedStatement.java
index 8a0671f..cb42f78 100644
--- a/jdbc/src/java/org/apache/hive/jdbc/HivePreparedStatement.java
+++ b/jdbc/src/java/org/apache/hive/jdbc/HivePreparedStatement.java
@@ -436,7 +436,7 @@ public class HivePreparedStatement extends HiveStatement implements PreparedStat
*/
public void setDate(int parameterIndex, Date x) throws SQLException {
- this.parameters.put(parameterIndex, x.toString());
+ this.parameters.put(parameterIndex, "'" + x.toString() + "'");
}
/*