You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by Matt Sicker <bo...@gmail.com> on 2016/09/01 02:45:25 UTC

Going to merge the AsyncAppender changes soon (LOG4J2-1430)

I've been pretty busy lately with work and life, so I haven't been able to
do much outside of responding to random emails, so I haven't been able to
finish that branch yet. However, the code is complete there, and the
documentation I wanted to add is there in theory (all the info I need is in
the ticket's comments). I should have some free time again soon, so I'm
going to finish all that and merge it to master hopefully this weekend.

If anyone would like to review the code, it's in the feature/LOG4J2-1430
branch.

Also, if you have any advice on generating all the neat charts that we have
in the performance docs, that'd be great as there's a decent about of
performance test data in the ticket that I could use to make the charts.
I'm also curious if anyone still has access to server infrastructure to run
the benchmarks on again. It'd be nice if the benchmarks are run on the same
machine as the existing benchmarks, but I guess it's not too big a deal if
they're not.

-- 
Matt Sicker <bo...@gmail.com>

Re: Going to merge the AsyncAppender changes soon (LOG4J2-1430)

Posted by Matt Sicker <bo...@gmail.com>.
By hours I meant minutes.

On 1 September 2016 at 11:28, Matt Sicker <bo...@gmail.com> wrote:

> Got a couple merge conflicts, I'll update in a couple hours.
>
> On 1 September 2016 at 11:27, Matt Sicker <bo...@gmail.com> wrote:
>
>> Sure, I'll update it. Incoming 50 emails.
>>
>> On 1 September 2016 at 11:24, Mikael Ståldal <mi...@magine.com>
>> wrote:
>>
>>> I think you need to merge master into that branch, otherwise it will be
>>> hard to review.
>>>
>>> On Thu, Sep 1, 2016 at 4:45 AM, Matt Sicker <bo...@gmail.com> wrote:
>>>
>>>> I've been pretty busy lately with work and life, so I haven't been able
>>>> to do much outside of responding to random emails, so I haven't been able
>>>> to finish that branch yet. However, the code is complete there, and the
>>>> documentation I wanted to add is there in theory (all the info I need is in
>>>> the ticket's comments). I should have some free time again soon, so I'm
>>>> going to finish all that and merge it to master hopefully this weekend.
>>>>
>>>> If anyone would like to review the code, it's in
>>>> the feature/LOG4J2-1430 branch.
>>>>
>>>> Also, if you have any advice on generating all the neat charts that we
>>>> have in the performance docs, that'd be great as there's a decent about of
>>>> performance test data in the ticket that I could use to make the charts.
>>>> I'm also curious if anyone still has access to server infrastructure to run
>>>> the benchmarks on again. It'd be nice if the benchmarks are run on the same
>>>> machine as the existing benchmarks, but I guess it's not too big a deal if
>>>> they're not.
>>>>
>>>> --
>>>> Matt Sicker <bo...@gmail.com>
>>>>
>>>
>>>
>>>
>>> --
>>> [image: MagineTV]
>>>
>>> *Mikael Ståldal*
>>> Senior software developer
>>>
>>> *Magine TV*
>>> mikael.staldal@magine.com
>>> Grev Turegatan 3  | 114 46 Stockholm, Sweden  |   www.magine.com
>>>
>>> Privileged and/or Confidential Information may be contained in this
>>> message. If you are not the addressee indicated in this message
>>> (or responsible for delivery of the message to such a person), you may
>>> not copy or deliver this message to anyone. In such case,
>>> you should destroy this message and kindly notify the sender by reply
>>> email.
>>>
>>
>>
>>
>> --
>> Matt Sicker <bo...@gmail.com>
>>
>
>
>
> --
> Matt Sicker <bo...@gmail.com>
>



-- 
Matt Sicker <bo...@gmail.com>

Re: Going to merge the AsyncAppender changes soon (LOG4J2-1430)

Posted by Matt Sicker <bo...@gmail.com>.
Got a couple merge conflicts, I'll update in a couple hours.

On 1 September 2016 at 11:27, Matt Sicker <bo...@gmail.com> wrote:

> Sure, I'll update it. Incoming 50 emails.
>
> On 1 September 2016 at 11:24, Mikael Ståldal <mi...@magine.com>
> wrote:
>
>> I think you need to merge master into that branch, otherwise it will be
>> hard to review.
>>
>> On Thu, Sep 1, 2016 at 4:45 AM, Matt Sicker <bo...@gmail.com> wrote:
>>
>>> I've been pretty busy lately with work and life, so I haven't been able
>>> to do much outside of responding to random emails, so I haven't been able
>>> to finish that branch yet. However, the code is complete there, and the
>>> documentation I wanted to add is there in theory (all the info I need is in
>>> the ticket's comments). I should have some free time again soon, so I'm
>>> going to finish all that and merge it to master hopefully this weekend.
>>>
>>> If anyone would like to review the code, it's in the feature/LOG4J2-1430
>>> branch.
>>>
>>> Also, if you have any advice on generating all the neat charts that we
>>> have in the performance docs, that'd be great as there's a decent about of
>>> performance test data in the ticket that I could use to make the charts.
>>> I'm also curious if anyone still has access to server infrastructure to run
>>> the benchmarks on again. It'd be nice if the benchmarks are run on the same
>>> machine as the existing benchmarks, but I guess it's not too big a deal if
>>> they're not.
>>>
>>> --
>>> Matt Sicker <bo...@gmail.com>
>>>
>>
>>
>>
>> --
>> [image: MagineTV]
>>
>> *Mikael Ståldal*
>> Senior software developer
>>
>> *Magine TV*
>> mikael.staldal@magine.com
>> Grev Turegatan 3  | 114 46 Stockholm, Sweden  |   www.magine.com
>>
>> Privileged and/or Confidential Information may be contained in this
>> message. If you are not the addressee indicated in this message
>> (or responsible for delivery of the message to such a person), you may
>> not copy or deliver this message to anyone. In such case,
>> you should destroy this message and kindly notify the sender by reply
>> email.
>>
>
>
>
> --
> Matt Sicker <bo...@gmail.com>
>



-- 
Matt Sicker <bo...@gmail.com>

Re: Going to merge the AsyncAppender changes soon (LOG4J2-1430)

Posted by Matt Sicker <bo...@gmail.com>.
Sure, I'll update it. Incoming 50 emails.

On 1 September 2016 at 11:24, Mikael Ståldal <mi...@magine.com>
wrote:

> I think you need to merge master into that branch, otherwise it will be
> hard to review.
>
> On Thu, Sep 1, 2016 at 4:45 AM, Matt Sicker <bo...@gmail.com> wrote:
>
>> I've been pretty busy lately with work and life, so I haven't been able
>> to do much outside of responding to random emails, so I haven't been able
>> to finish that branch yet. However, the code is complete there, and the
>> documentation I wanted to add is there in theory (all the info I need is in
>> the ticket's comments). I should have some free time again soon, so I'm
>> going to finish all that and merge it to master hopefully this weekend.
>>
>> If anyone would like to review the code, it's in the feature/LOG4J2-1430
>> branch.
>>
>> Also, if you have any advice on generating all the neat charts that we
>> have in the performance docs, that'd be great as there's a decent about of
>> performance test data in the ticket that I could use to make the charts.
>> I'm also curious if anyone still has access to server infrastructure to run
>> the benchmarks on again. It'd be nice if the benchmarks are run on the same
>> machine as the existing benchmarks, but I guess it's not too big a deal if
>> they're not.
>>
>> --
>> Matt Sicker <bo...@gmail.com>
>>
>
>
>
> --
> [image: MagineTV]
>
> *Mikael Ståldal*
> Senior software developer
>
> *Magine TV*
> mikael.staldal@magine.com
> Grev Turegatan 3  | 114 46 Stockholm, Sweden  |   www.magine.com
>
> Privileged and/or Confidential Information may be contained in this
> message. If you are not the addressee indicated in this message
> (or responsible for delivery of the message to such a person), you may not
> copy or deliver this message to anyone. In such case,
> you should destroy this message and kindly notify the sender by reply
> email.
>



-- 
Matt Sicker <bo...@gmail.com>

Re: Going to merge the AsyncAppender changes soon (LOG4J2-1430)

Posted by Mikael Ståldal <mi...@magine.com>.
I think you need to merge master into that branch, otherwise it will be
hard to review.

On Thu, Sep 1, 2016 at 4:45 AM, Matt Sicker <bo...@gmail.com> wrote:

> I've been pretty busy lately with work and life, so I haven't been able to
> do much outside of responding to random emails, so I haven't been able to
> finish that branch yet. However, the code is complete there, and the
> documentation I wanted to add is there in theory (all the info I need is in
> the ticket's comments). I should have some free time again soon, so I'm
> going to finish all that and merge it to master hopefully this weekend.
>
> If anyone would like to review the code, it's in the feature/LOG4J2-1430
> branch.
>
> Also, if you have any advice on generating all the neat charts that we
> have in the performance docs, that'd be great as there's a decent about of
> performance test data in the ticket that I could use to make the charts.
> I'm also curious if anyone still has access to server infrastructure to run
> the benchmarks on again. It'd be nice if the benchmarks are run on the same
> machine as the existing benchmarks, but I guess it's not too big a deal if
> they're not.
>
> --
> Matt Sicker <bo...@gmail.com>
>



-- 
[image: MagineTV]

*Mikael Ståldal*
Senior software developer

*Magine TV*
mikael.staldal@magine.com
Grev Turegatan 3  | 114 46 Stockholm, Sweden  |   www.magine.com

Privileged and/or Confidential Information may be contained in this
message. If you are not the addressee indicated in this message
(or responsible for delivery of the message to such a person), you may not
copy or deliver this message to anyone. In such case,
you should destroy this message and kindly notify the sender by reply
email.