You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/02 11:57:05 UTC

[GitHub] [incubator-nuttx] a-lunev commented on pull request #5102: net/tcp(unbuffered): removed excessive overwrites of conn->sndseq

a-lunev commented on pull request #5102:
URL: https://github.com/apache/incubator-nuttx/pull/5102#issuecomment-1003704185


   > @a-lunev
   > 
   > I noticed this PR has a side effect. For example, if I try the wget command with spresnse:rndis + CONFIG_NET_TCP_WRITE_BUFFERS=n, it failed. Actually, it works if I revert this PR.
   > 
   > Please see the wireshark logs.
   > 
   > [spresense-rndis-wget-logs-20220102.zip](https://github.com/apache/incubator-nuttx/files/7798596/spresense-rndis-wget-logs-20220102.zip)
   
   Thank you for letting me know. I was able to reproduce the issue based on ftpc command. As I can see, tcp_sendfile is affected in unbuffered mode. I'm investigating the issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org