You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "fengcharly (via GitHub)" <gi...@apache.org> on 2023/05/25 09:43:08 UTC

[GitHub] [rocketmq] fengcharly opened a new issue, #6813: In controller mode, the master's BrokerRole will be set to SYNC_ MASTER

fengcharly opened a new issue, #6813:
URL: https://github.com/apache/rocketmq/issues/6813

   ### Before Creating the Enhancement Request
   
   - [X] I have confirmed that this should be classified as an enhancement rather than a bug/feature.
   
   
   ### Summary
   
   ![image](https://github.com/apache/rocketmq/assets/35131874/8ade10c0-f051-4dd5-9cf4-88f7474b05e5)
   
   org.apache.rocketmq.broker.controller.ReplicasManager#changeToMaster:
   
   In controller mode, the master's BrokerRole will be set to SYNC_ MASTER
   But this will cause my BrokerRole configuration to fail, such as setting it to ASYNC_ MASTER, how can I forcibly change my BrokerRole to SYNC_ MASTER, I don't think it's reasonable
   
   ### Motivation
   
   In controller mode, the master's BrokerRole will be set to SYNC_ MASTER
   But this will cause my BrokerRole configuration to fail, such as setting it to ASYNC_ MASTER, how can I forcibly change my BrokerRole to SYNC_ MASTER, I don't think it's reasonable
   
   ### Describe the Solution You'd Like
   
   Delete the following line of code for changeToMaster:
   this.brokerController.getMessageStoreConfig().setBrokerRole(BrokerRole.SYNC_MASTER);
   
   ### Describe Alternatives You've Considered
   
   not have
   
   ### Additional Context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq] fengcharly closed issue #6813: [Enhancement] In controller mode, the master's BrokerRole will be set to SYNC_ MASTER

Posted by "fengcharly (via GitHub)" <gi...@apache.org>.
fengcharly closed issue #6813: [Enhancement] In controller mode, the master's BrokerRole will be set to SYNC_ MASTER
URL: https://github.com/apache/rocketmq/issues/6813


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq] fengcharly commented on issue #6813: [Enhancement] In controller mode, the master's BrokerRole will be set to SYNC_ MASTER

Posted by "fengcharly (via GitHub)" <gi...@apache.org>.
fengcharly commented on issue #6813:
URL: https://github.com/apache/rocketmq/issues/6813#issuecomment-1567868465

   In election mode, the parameters brokerRole and brokerId become invalid, and the controller ultimately determines the master-slave relationship.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org