[jira] [Commented] (YARN-1389) ApplicationClientProtocol and ApplicationHistoryProtocol should expose analogous APIs

["Mayank Bansal (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13920669#comment-13920669 ] 

Mayank Bansal commented on YARN-1389:
-------------------------------------

Thanks [~zjshen] for the review.
bq. 1. I still see "<code>ApplicationHistoryServer</code>" in ApplicationClientProtocol. And some description sounds not accurate. For example,
Done

bq. ApplicationHistoryProtocol's javadoc has been wrongly modified.
Done

bq. Is it better to simplify the following condition? Same for all the similar conditions in the patch
Done

bq.  Please match the XXXXNotFoundException that will be thrown in ClientRMService, and that is analyzed in YarnClientImpl.
Done

bq.  It is still an in-progress patch, isn't it? The test cases are still missing.
Done

bq. Didn't see the change to allow user to get the application list from the history
We decided not to get completed list from history, it will be just rm apps as before.

bq. Please see what RMApp does
Done


> ApplicationClientProtocol and ApplicationHistoryProtocol should expose analogous APIs
> -------------------------------------------------------------------------------------
>
>                 Key: YARN-1389
>                 URL: https://issues.apache.org/jira/browse/YARN-1389
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Mayank Bansal
>            Assignee: Mayank Bansal
>         Attachments: YARN-1389-1.patch, YARN-1389-2.patch, YARN-1389-3.patch, YARN-1389-4.patch
>
>
> As we plan to have the APIs in ApplicationHistoryProtocol to expose the reports of *finished* application attempts and containers, we should do the same for ApplicationClientProtocol, which will return the reports of *running* attempts and containers.
> Later on, we can improve YarnClient to direct the query of running instance to ApplicationClientProtocol, while that of finished instance to ApplicationHistoryProtocol, making it transparent to the users.



--
This message was sent by Atlassian JIRA
(v6.2#6252)