You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/01/11 09:22:31 UTC
[GitHub] [rocketmq-client-cpp] ShannonDing opened a new pull request #225:
fix(send): try to use command v2 to send messages
ShannonDing opened a new pull request #225: fix(send): try to use command v2 to send messages
URL: https://github.com/apache/rocketmq-client-cpp/pull/225
## What is the purpose of the change
[fix #189] fix(send): try to use command v2 to send messages
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-cpp] codecov-io edited a comment on issue #225:
fix(send): try to use command v2 to send messages
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #225: fix(send): try to use command v2 to send messages
URL: https://github.com/apache/rocketmq-client-cpp/pull/225#issuecomment-573302825
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/225?src=pr&el=h1) Report
> Merging [#225](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/225?src=pr&el=desc) into [master](https://codecov.io/gh/apache/rocketmq-client-cpp/commit/54a38788908d48f9abbb1969e46b7c47d06bb716?src=pr&el=desc) will **increase** coverage by `0.86%`.
> The diff coverage is `98.85%`.
[](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/225?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #225 +/- ##
==========================================
+ Coverage 51.01% 51.88% +0.86%
==========================================
Files 173 174 +1
Lines 10701 10857 +156
==========================================
+ Hits 5459 5633 +174
+ Misses 5242 5224 -18
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/225?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/common/AsyncCallbackWrap.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/225/diff?src=pr&el=tree#diff-c3JjL2NvbW1vbi9Bc3luY0NhbGxiYWNrV3JhcC5jcHA=) | `9.58% <ø> (ø)` | :arrow_up: |
| [src/common/AsyncCallbackWrap.h](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/225/diff?src=pr&el=tree#diff-c3JjL2NvbW1vbi9Bc3luY0NhbGxiYWNrV3JhcC5o) | `33.33% <ø> (ø)` | :arrow_up: |
| [src/MQClientFactory.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/225/diff?src=pr&el=tree#diff-c3JjL01RQ2xpZW50RmFjdG9yeS5jcHA=) | `18.45% <0%> (ø)` | :arrow_up: |
| [src/producer/DefaultMQProducer.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/225/diff?src=pr&el=tree#diff-c3JjL3Byb2R1Y2VyL0RlZmF1bHRNUVByb2R1Y2VyLmNwcA==) | `5.46% <0%> (-0.02%)` | :arrow_down: |
| [src/MQClientAPIImpl.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/225/diff?src=pr&el=tree#diff-c3JjL01RQ2xpZW50QVBJSW1wbC5jcHA=) | `16.49% <100%> (+0.35%)` | :arrow_up: |
| [test/src/protocol/CommandHeaderTest.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/225/diff?src=pr&el=tree#diff-dGVzdC9zcmMvcHJvdG9jb2wvQ29tbWFuZEhlYWRlclRlc3QuY3Bw) | `100% <100%> (ø)` | :arrow_up: |
| [test/src/common/MQVersionTest.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/225/diff?src=pr&el=tree#diff-dGVzdC9zcmMvY29tbW9uL01RVmVyc2lvblRlc3QuY3Bw) | `100% <100%> (ø)` | |
| [src/protocol/CommandHeader.h](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/225/diff?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL0NvbW1hbmRIZWFkZXIuaA==) | `76.82% <100%> (+6.06%)` | :arrow_up: |
| [src/common/MQVersion.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/225/diff?src=pr&el=tree#diff-c3JjL2NvbW1vbi9NUVZlcnNpb24uY3Bw) | `100% <100%> (+100%)` | :arrow_up: |
| [src/common/VirtualEnvUtil.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/225/diff?src=pr&el=tree#diff-c3JjL2NvbW1vbi9WaXJ0dWFsRW52VXRpbC5jcHA=) | `100% <100%> (+100%)` | :arrow_up: |
| ... and [6 more](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/225/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/225?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/225?src=pr&el=footer). Last update [54a3878...8ce4bd5](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/225?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-cpp] ShannonDing merged pull request #225:
fix(send): try to use command v2 to send messages
Posted by GitBox <gi...@apache.org>.
ShannonDing merged pull request #225: fix(send): try to use command v2 to send messages
URL: https://github.com/apache/rocketmq-client-cpp/pull/225
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-cpp] codecov-io commented on issue #225:
fix(send): try to use command v2 to send messages
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #225: fix(send): try to use command v2 to send messages
URL: https://github.com/apache/rocketmq-client-cpp/pull/225#issuecomment-573302825
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/225?src=pr&el=h1) Report
> Merging [#225](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/225?src=pr&el=desc) into [master](https://codecov.io/gh/apache/rocketmq-client-cpp/commit/54a38788908d48f9abbb1969e46b7c47d06bb716?src=pr&el=desc) will **increase** coverage by `0.07%`.
> The diff coverage is `98.86%`.
[](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/225?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #225 +/- ##
==========================================
+ Coverage 51.01% 51.09% +0.07%
==========================================
Files 173 174 +1
Lines 10701 10857 +156
==========================================
+ Hits 5459 5547 +88
- Misses 5242 5310 +68
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/225?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/common/AsyncCallbackWrap.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/225/diff?src=pr&el=tree#diff-c3JjL2NvbW1vbi9Bc3luY0NhbGxiYWNrV3JhcC5jcHA=) | `9.58% <ø> (ø)` | :arrow_up: |
| [src/common/AsyncCallbackWrap.h](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/225/diff?src=pr&el=tree#diff-c3JjL2NvbW1vbi9Bc3luY0NhbGxiYWNrV3JhcC5o) | `33.33% <ø> (ø)` | :arrow_up: |
| [src/MQClientFactory.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/225/diff?src=pr&el=tree#diff-c3JjL01RQ2xpZW50RmFjdG9yeS5jcHA=) | `18.45% <0%> (ø)` | :arrow_up: |
| [src/producer/DefaultMQProducer.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/225/diff?src=pr&el=tree#diff-c3JjL3Byb2R1Y2VyL0RlZmF1bHRNUVByb2R1Y2VyLmNwcA==) | `5.46% <0%> (-0.02%)` | :arrow_down: |
| [src/MQClientAPIImpl.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/225/diff?src=pr&el=tree#diff-c3JjL01RQ2xpZW50QVBJSW1wbC5jcHA=) | `9.81% <100%> (-6.34%)` | :arrow_down: |
| [test/src/protocol/CommandHeaderTest.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/225/diff?src=pr&el=tree#diff-dGVzdC9zcmMvcHJvdG9jb2wvQ29tbWFuZEhlYWRlclRlc3QuY3Bw) | `100% <100%> (ø)` | :arrow_up: |
| [test/src/common/MQVersionTest.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/225/diff?src=pr&el=tree#diff-dGVzdC9zcmMvY29tbW9uL01RVmVyc2lvblRlc3QuY3Bw) | `100% <100%> (ø)` | |
| [src/protocol/CommandHeader.h](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/225/diff?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL0NvbW1hbmRIZWFkZXIuaA==) | `71.95% <100%> (+1.18%)` | :arrow_up: |
| [src/common/MQVersion.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/225/diff?src=pr&el=tree#diff-c3JjL2NvbW1vbi9NUVZlcnNpb24uY3Bw) | `100% <100%> (+100%)` | :arrow_up: |
| [src/common/VirtualEnvUtil.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/225/diff?src=pr&el=tree#diff-c3JjL2NvbW1vbi9WaXJ0dWFsRW52VXRpbC5jcHA=) | `100% <100%> (+100%)` | :arrow_up: |
| ... and [11 more](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/225/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/225?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/225?src=pr&el=footer). Last update [54a3878...8ce4bd5](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/225?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services