You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/05/13 12:41:13 UTC
[GitHub] [rocketmq] areyouok opened a new pull request #2889: [ISSUE #2883] [Part E] Improve produce performance in M/S mode.
areyouok opened a new pull request #2889:
URL: https://github.com/apache/rocketmq/pull/2889
1. Change log level to debug: "Half offset {} has been committed/rolled back"
2. Optimise lock in WaitNotifyObject
3. Remove lock in HAService
4. Remove lock in GroupCommitService
5. Eliminate array copy in HA
6. **Remove putMessage/putMessages method in CommitLog which has too many duplicated code.**
7. Change default value of some parameters: sendMessageThreadPoolNums/useReentrantLockWhenPutMessage/flushCommitLogTimed/endTransactionThreadPoolNums
8. **Optimise performance of asyncPutMessage (extract some code out of putMessage lock)**
9. **extract generation of msgId out of lock in CommitLog (now only for single message processor) **
10. **extract generation of topicQueueTable key out of sync code **
11. **extract generation of msgId out of lock in CommitLog (for batch) **
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #2889: [ISSUE #2883] [Part E] Improve produce performance in M/S mode.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2889:
URL: https://github.com/apache/rocketmq/pull/2889#issuecomment-840541576
# [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2889?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2889](https://codecov.io/gh/apache/rocketmq/pull/2889?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8f3f199) into [develop](https://codecov.io/gh/apache/rocketmq/commit/fe78d1826f1bbf640ca0ec0fe0892e1419f17a14?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fe78d18) will **increase** coverage by `0.04%`.
> The diff coverage is `89.65%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq/pull/2889/graphs/tree.svg?width=650&height=150&src=pr&token=4w0sxP1wZv&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/rocketmq/pull/2889?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #2889 +/- ##
=============================================
+ Coverage 46.49% 46.54% +0.04%
+ Complexity 4407 4395 -12
=============================================
Files 552 552
Lines 36500 36258 -242
Branches 4828 4778 -50
=============================================
- Hits 16972 16877 -95
+ Misses 17405 17288 -117
+ Partials 2123 2093 -30
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/2889?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/rocketmq/store/dledger/DLedgerCommitLog.java](https://codecov.io/gh/apache/rocketmq/pull/2889/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL2RsZWRnZXIvRExlZGdlckNvbW1pdExvZy5qYXZh) | `76.02% <ø> (+2.32%)` | `63.00 <0.00> (-9.00)` | :arrow_up: |
| [...org/apache/rocketmq/store/DefaultMessageStore.java](https://codecov.io/gh/apache/rocketmq/pull/2889/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0RlZmF1bHRNZXNzYWdlU3RvcmUuamF2YQ==) | `55.74% <33.33%> (+0.13%)` | `110.00 <2.00> (ø)` | |
| [...org/apache/rocketmq/store/AppendMessageResult.java](https://codecov.io/gh/apache/rocketmq/pull/2889/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0FwcGVuZE1lc3NhZ2VSZXN1bHQuamF2YQ==) | `60.00% <90.90%> (+8.71%)` | `11.00 <2.00> (+1.00)` | |
| [...main/java/org/apache/rocketmq/store/CommitLog.java](https://codecov.io/gh/apache/rocketmq/pull/2889/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0NvbW1pdExvZy5qYXZh) | `73.47% <91.06%> (+7.04%)` | `77.00 <1.00> (-2.00)` | :arrow_up: |
| [...ain/java/org/apache/rocketmq/store/MappedFile.java](https://codecov.io/gh/apache/rocketmq/pull/2889/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL01hcHBlZEZpbGUuamF2YQ==) | `50.54% <100.00%> (ø)` | `51.00 <2.00> (ø)` | |
| [...g/apache/rocketmq/store/MessageExtBrokerInner.java](https://codecov.io/gh/apache/rocketmq/pull/2889/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL01lc3NhZ2VFeHRCcm9rZXJJbm5lci5qYXZh) | `76.92% <100.00%> (+6.92%)` | `7.00 <2.00> (+2.00)` | |
| [...a/org/apache/rocketmq/logging/inner/SysLogger.java](https://codecov.io/gh/apache/rocketmq/pull/2889/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bG9nZ2luZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbG9nZ2luZy9pbm5lci9TeXNMb2dnZXIuamF2YQ==) | `28.57% <0.00%> (-5.72%)` | `5.00% <0.00%> (-2.00%)` | |
| [...ketmq/client/impl/consumer/PullMessageService.java](https://codecov.io/gh/apache/rocketmq/pull/2889/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9QdWxsTWVzc2FnZVNlcnZpY2UuamF2YQ==) | `75.55% <0.00%> (-4.45%)` | `9.00% <0.00%> (-1.00%)` | |
| [...java/org/apache/rocketmq/logging/inner/Logger.java](https://codecov.io/gh/apache/rocketmq/pull/2889/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bG9nZ2luZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbG9nZ2luZy9pbm5lci9Mb2dnZXIuamF2YQ==) | `52.63% <0.00%> (-3.35%)` | `28.00% <0.00%> (-1.00%)` | |
| [...a/org/apache/rocketmq/store/StoreStatsService.java](https://codecov.io/gh/apache/rocketmq/pull/2889/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL1N0b3JlU3RhdHNTZXJ2aWNlLmphdmE=) | `29.50% <0.00%> (-1.97%)` | `26.00% <0.00%> (-3.00%)` | |
| ... and [13 more](https://codecov.io/gh/apache/rocketmq/pull/2889/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/2889?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2889?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fe78d18...8f3f199](https://codecov.io/gh/apache/rocketmq/pull/2889?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #2889: [ISSUE #2883] [Part E] Improve produce performance in M/S mode.
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #2889:
URL: https://github.com/apache/rocketmq/pull/2889#issuecomment-840535326
[![Coverage Status](https://coveralls.io/builds/39658138/badge)](https://coveralls.io/builds/39658138)
Coverage decreased (-0.09%) to 52.399% when pulling **8f3f199394f772497c73c983bc1ce3ff3aa32383 on areyouok:dev_speed_E** into **fe78d1826f1bbf640ca0ec0fe0892e1419f17a14 on apache:develop**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls edited a comment on pull request #2889: [ISSUE #2883] [Part E] Improve produce performance in M/S mode.
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #2889:
URL: https://github.com/apache/rocketmq/pull/2889#issuecomment-840535326
[![Coverage Status](https://coveralls.io/builds/39856083/badge)](https://coveralls.io/builds/39856083)
Coverage increased (+0.2%) to 54.032% when pulling **7b68d74ed5884ecdb1a3ec0dd4110a4a45d42d78 on areyouok:dev_speed_E** into **4e73ba0ee374d6a5484eb6184bbc8ff3829a7075 on apache:develop**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls edited a comment on pull request #2889: [ISSUE #2883] [Part E] Improve produce performance in M/S mode.
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #2889:
URL: https://github.com/apache/rocketmq/pull/2889#issuecomment-840535326
[![Coverage Status](https://coveralls.io/builds/39772444/badge)](https://coveralls.io/builds/39772444)
Coverage decreased (-0.1%) to 52.385% when pulling **9d34d1395c45a119409c8291213745be6282fe59 on areyouok:dev_speed_E** into **fe78d1826f1bbf640ca0ec0fe0892e1419f17a14 on apache:develop**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] zongtanghu commented on pull request #2889: [ISSUE #2883] [Part E] Improve produce performance in M/S mode.
Posted by GitBox <gi...@apache.org>.
zongtanghu commented on pull request #2889:
URL: https://github.com/apache/rocketmq/pull/2889#issuecomment-874418315
@areyouok Please resolve the code's conflicts. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-commenter edited a comment on pull request #2889: [ISSUE #2883] [Part E] Improve produce performance in M/S mode.
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2889:
URL: https://github.com/apache/rocketmq/pull/2889#issuecomment-840541576
# [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2889?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2889](https://codecov.io/gh/apache/rocketmq/pull/2889?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8f3f199) into [develop](https://codecov.io/gh/apache/rocketmq/commit/fe78d1826f1bbf640ca0ec0fe0892e1419f17a14?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fe78d18) will **increase** coverage by `0.04%`.
> The diff coverage is `89.65%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq/pull/2889/graphs/tree.svg?width=650&height=150&src=pr&token=4w0sxP1wZv&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/rocketmq/pull/2889?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #2889 +/- ##
=============================================
+ Coverage 46.49% 46.54% +0.04%
+ Complexity 4407 4395 -12
=============================================
Files 552 552
Lines 36500 36258 -242
Branches 4828 4778 -50
=============================================
- Hits 16972 16877 -95
+ Misses 17405 17288 -117
+ Partials 2123 2093 -30
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/2889?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/rocketmq/store/dledger/DLedgerCommitLog.java](https://codecov.io/gh/apache/rocketmq/pull/2889/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL2RsZWRnZXIvRExlZGdlckNvbW1pdExvZy5qYXZh) | `76.02% <ø> (+2.32%)` | `63.00 <0.00> (-9.00)` | :arrow_up: |
| [...org/apache/rocketmq/store/DefaultMessageStore.java](https://codecov.io/gh/apache/rocketmq/pull/2889/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0RlZmF1bHRNZXNzYWdlU3RvcmUuamF2YQ==) | `55.74% <33.33%> (+0.13%)` | `110.00 <2.00> (ø)` | |
| [...org/apache/rocketmq/store/AppendMessageResult.java](https://codecov.io/gh/apache/rocketmq/pull/2889/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0FwcGVuZE1lc3NhZ2VSZXN1bHQuamF2YQ==) | `60.00% <90.90%> (+8.71%)` | `11.00 <2.00> (+1.00)` | |
| [...main/java/org/apache/rocketmq/store/CommitLog.java](https://codecov.io/gh/apache/rocketmq/pull/2889/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0NvbW1pdExvZy5qYXZh) | `73.47% <91.06%> (+7.04%)` | `77.00 <1.00> (-2.00)` | :arrow_up: |
| [...ain/java/org/apache/rocketmq/store/MappedFile.java](https://codecov.io/gh/apache/rocketmq/pull/2889/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL01hcHBlZEZpbGUuamF2YQ==) | `50.54% <100.00%> (ø)` | `51.00 <2.00> (ø)` | |
| [...g/apache/rocketmq/store/MessageExtBrokerInner.java](https://codecov.io/gh/apache/rocketmq/pull/2889/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL01lc3NhZ2VFeHRCcm9rZXJJbm5lci5qYXZh) | `76.92% <100.00%> (+6.92%)` | `7.00 <2.00> (+2.00)` | |
| [...a/org/apache/rocketmq/logging/inner/SysLogger.java](https://codecov.io/gh/apache/rocketmq/pull/2889/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bG9nZ2luZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbG9nZ2luZy9pbm5lci9TeXNMb2dnZXIuamF2YQ==) | `28.57% <0.00%> (-5.72%)` | `5.00% <0.00%> (-2.00%)` | |
| [...ketmq/client/impl/consumer/PullMessageService.java](https://codecov.io/gh/apache/rocketmq/pull/2889/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9QdWxsTWVzc2FnZVNlcnZpY2UuamF2YQ==) | `75.55% <0.00%> (-4.45%)` | `9.00% <0.00%> (-1.00%)` | |
| [...java/org/apache/rocketmq/logging/inner/Logger.java](https://codecov.io/gh/apache/rocketmq/pull/2889/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bG9nZ2luZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbG9nZ2luZy9pbm5lci9Mb2dnZXIuamF2YQ==) | `52.63% <0.00%> (-3.35%)` | `28.00% <0.00%> (-1.00%)` | |
| [...a/org/apache/rocketmq/store/StoreStatsService.java](https://codecov.io/gh/apache/rocketmq/pull/2889/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL1N0b3JlU3RhdHNTZXJ2aWNlLmphdmE=) | `29.50% <0.00%> (-1.97%)` | `26.00% <0.00%> (-3.00%)` | |
| ... and [13 more](https://codecov.io/gh/apache/rocketmq/pull/2889/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/2889?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2889?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fe78d18...8f3f199](https://codecov.io/gh/apache/rocketmq/pull/2889?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] zongtanghu commented on pull request #2889: [ISSUE #2883] [Part E] Improve produce performance in M/S mode.
Posted by GitBox <gi...@apache.org>.
zongtanghu commented on pull request #2889:
URL: https://github.com/apache/rocketmq/pull/2889#issuecomment-874418315
@areyouok Please resolve the code's conflicts. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls edited a comment on pull request #2889: [ISSUE #2883] [Part E] Improve produce performance in M/S mode.
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #2889:
URL: https://github.com/apache/rocketmq/pull/2889#issuecomment-840535326
[![Coverage Status](https://coveralls.io/builds/40967367/badge)](https://coveralls.io/builds/40967367)
Coverage increased (+0.2%) to 54.249% when pulling **1469d76eaf4260aabd542622f8170951be5e9f8c on areyouok:dev_speed_E** into **df35edf3d5cc9b5b497c5158912dd81f3e6e2104 on apache:develop**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls edited a comment on pull request #2889: [ISSUE #2883] [Part E] Improve produce performance in M/S mode.
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #2889:
URL: https://github.com/apache/rocketmq/pull/2889#issuecomment-840535326
[![Coverage Status](https://coveralls.io/builds/41144974/badge)](https://coveralls.io/builds/41144974)
Coverage decreased (-0.02%) to 54.064% when pulling **9047af76ed31e2cb546cab5026783a8448bdb223 on areyouok:dev_speed_E** into **cba3e05d69da63238b95d6b47aaacd5c5f8a78a9 on apache:develop**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] zongtanghu merged pull request #2889: [ISSUE #2883] [Part E] Improve produce performance in M/S mode.
Posted by GitBox <gi...@apache.org>.
zongtanghu merged pull request #2889:
URL: https://github.com/apache/rocketmq/pull/2889
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org