You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/06/04 02:31:06 UTC

[GitHub] [cloudstack] ustcweizhou opened a new pull request #4001: server: Dedicated hosts should be 'Not Suitable' while find host for m migration

ustcweizhou opened a new pull request #4001:
URL: https://github.com/apache/cloudstack/pull/4001


   ## Description
   <!--- Describe your changes in detail -->
   
   While migrate a vm, in the popup, the host dedicated to other accounts/domains are also 'Suitable" for migration, which is obviously wrong.
   
   The same issue happens with api findHostsForMigration
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   with this PR, the hosts dedicated to other domains/accounts are marked as 'Not Suitable'.
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4001: server: Dedicated hosts should be 'Not Suitable' while find host for m migration

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4001:
URL: https://github.com/apache/cloudstack/pull/4001#issuecomment-642598944


   Ping @ustcweizhou - can you respond to Daan's comment?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd merged pull request #4001: server: Dedicated hosts should be 'Not Suitable' while find host for m migration

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4001:
URL: https://github.com/apache/cloudstack/pull/4001


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #4001: server: Dedicated hosts should be 'Not Suitable' while find host for m migration

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4001:
URL: https://github.com/apache/cloudstack/pull/4001#issuecomment-642603642


   @rhtyd @DaanHoogland 
   I missed Daan's comment.
   steps for manual test
   (1) login as root admin,
   (2) dedicate a host H to account A
   (3) migrate a vm of account B, the host H is suitable. it should be "Not Suitable"
   it is an issue with api findHostsForMigration.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd closed pull request #4001: server: Dedicated hosts should be 'Not Suitable' while find host for m migration

Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #4001:
URL: https://github.com/apache/cloudstack/pull/4001


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4001: server: Dedicated hosts should be 'Not Suitable' while find host for m migration

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4001:
URL: https://github.com/apache/cloudstack/pull/4001#issuecomment-653724074


   FWIW LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4001: server: Dedicated hosts should be 'Not Suitable' while find host for m migration

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4001:
URL: https://github.com/apache/cloudstack/pull/4001#issuecomment-638564921


   (Did not test it)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on a change in pull request #4001: server: Dedicated hosts should be 'Not Suitable' while find host for m migration

Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4001:
URL: https://github.com/apache/cloudstack/pull/4001#discussion_r439205308



##########
File path: server/src/main/java/com/cloud/server/ManagementServerImpl.java
##########
@@ -1321,6 +1321,11 @@ private HypervisorType getHypervisorType(VMInstanceVO vm, StoragePool srcVolumeP
             }
         }
 
+        if (vm.getType() == VirtualMachine.Type.User || vm.getType() == VirtualMachine.Type.DomainRouter) {

Review comment:
       @ustcweizhou what about other systemvms? CPVM, SSVM, ILB etc?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on a change in pull request #4001: server: Dedicated hosts should be 'Not Suitable' while find host for m migration

Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4001:
URL: https://github.com/apache/cloudstack/pull/4001#discussion_r439205308



##########
File path: server/src/main/java/com/cloud/server/ManagementServerImpl.java
##########
@@ -1321,6 +1321,11 @@ private HypervisorType getHypervisorType(VMInstanceVO vm, StoragePool srcVolumeP
             }
         }
 
+        if (vm.getType() == VirtualMachine.Type.User || vm.getType() == VirtualMachine.Type.DomainRouter) {

Review comment:
       @ustcweizhou what about other systemvms? CPVM, SSVM, ILB etc?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org