You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by "Emmanuel Lecharny (JIRA)" <di...@incubator.apache.org> on 2007/02/03 00:38:05 UTC
[jira] Created: (DIR-202) Double modification on a modify ?
Double modification on a modify ?
---------------------------------
Key: DIR-202
URL: https://issues.apache.org/jira/browse/DIR-202
Project: Directory
Issue Type: Improvement
Reporter: Emmanuel Lecharny
Assigned To: Alex Karasulu
We have had a convo with alex about the OperationalService. I saw that when doing a modification on an entry, we first call the next interceptor (and this will modify the entry on the backend), then we add two new attributes (modifiers name and date) and store again the data into the backend. This does not seems to be very efficient, but we don't remember the reason why it's done like that ...
Here is the convo
elecharny in OperationalService
akarasulu yep
elecharny when doing a modify,
akarasulu ahha
elecharny you first call the next interceptor, then you update the nexus with the entry with
elecharny two new attributes
elecharny why don't you add the attrs into the entry and then call the netx interceptors ?
akarasulu hmmm I had some reason for this
elecharny this is a simple modify instead of two
akarasulu don't remember
akarasulu yeah yeah I see what you mean
akarasulu can't remember now
elecharny this seems to cost the double
akarasulu yes it does
akarasulu can you put this in JIRA
elecharny yeah
akarasulu just past this info
akarasulu from IRC
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRSERVER-840) Double modification on a modify ?
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12520818 ]
Emmanuel Lecharny commented on DIRSERVER-840:
---------------------------------------------
This is still an existing problem.
> Double modification on a modify ?
> ---------------------------------
>
> Key: DIRSERVER-840
> URL: https://issues.apache.org/jira/browse/DIRSERVER-840
> Project: Directory ApacheDS
> Issue Type: Improvement
> Reporter: Emmanuel Lecharny
> Assignee: Alex Karasulu
> Fix For: 1.5.1
>
>
> We have had a convo with alex about the OperationalService. I saw that when doing a modification on an entry, we first call the next interceptor (and this will modify the entry on the backend), then we add two new attributes (modifiers name and date) and store again the data into the backend. This does not seems to be very efficient, but we don't remember the reason why it's done like that ...
> Here is the convo
> elecharny in OperationalService
> akarasulu yep
> elecharny when doing a modify,
> akarasulu ahha
> elecharny you first call the next interceptor, then you update the nexus with the entry with
> elecharny two new attributes
> elecharny why don't you add the attrs into the entry and then call the netx interceptors ?
> akarasulu hmmm I had some reason for this
> elecharny this is a simple modify instead of two
> akarasulu don't remember
> akarasulu yeah yeah I see what you mean
> akarasulu can't remember now
> elecharny this seems to cost the double
> akarasulu yes it does
> akarasulu can you put this in JIRA
> elecharny yeah
> akarasulu just past this info
> akarasulu from IRC
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DIRSERVER-840) Double modification on a modify ?
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Lecharny resolved DIRSERVER-840.
-----------------------------------------
Resolution: Fixed
The modification has been reverted in bigBang branch :
http://svn.apache.org/viewvc?rev=581856&view=rev
http://svn.apache.org/viewvc?rev=581857&view=rev
http://svn.apache.org/viewvc?rev=581861&view=rev
> Double modification on a modify ?
> ---------------------------------
>
> Key: DIRSERVER-840
> URL: https://issues.apache.org/jira/browse/DIRSERVER-840
> Project: Directory ApacheDS
> Issue Type: Improvement
> Reporter: Emmanuel Lecharny
> Assignee: Alex Karasulu
> Fix For: 1.5.1
>
>
> We have had a convo with alex about the OperationalService. I saw that when doing a modification on an entry, we first call the next interceptor (and this will modify the entry on the backend), then we add two new attributes (modifiers name and date) and store again the data into the backend. This does not seems to be very efficient, but we don't remember the reason why it's done like that ...
> Here is the convo
> elecharny in OperationalService
> akarasulu yep
> elecharny when doing a modify,
> akarasulu ahha
> elecharny you first call the next interceptor, then you update the nexus with the entry with
> elecharny two new attributes
> elecharny why don't you add the attrs into the entry and then call the netx interceptors ?
> akarasulu hmmm I had some reason for this
> elecharny this is a simple modify instead of two
> akarasulu don't remember
> akarasulu yeah yeah I see what you mean
> akarasulu can't remember now
> elecharny this seems to cost the double
> akarasulu yes it does
> akarasulu can you put this in JIRA
> elecharny yeah
> akarasulu just past this info
> akarasulu from IRC
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DIRSERVER-840) Double modification on a modify ?
Posted by "Alex Karasulu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Karasulu closed DIRSERVER-840.
-----------------------------------
Resolution: Fixed
Fixed on commit revision 567238 here:
http://svn.apache.org/viewvc?view=rev&rev=567238
I'm not going to bother backport this to 1.0 unless someone wants me to.
> Double modification on a modify ?
> ---------------------------------
>
> Key: DIRSERVER-840
> URL: https://issues.apache.org/jira/browse/DIRSERVER-840
> Project: Directory ApacheDS
> Issue Type: Improvement
> Reporter: Emmanuel Lecharny
> Assignee: Alex Karasulu
> Fix For: 1.5.1
>
>
> We have had a convo with alex about the OperationalService. I saw that when doing a modification on an entry, we first call the next interceptor (and this will modify the entry on the backend), then we add two new attributes (modifiers name and date) and store again the data into the backend. This does not seems to be very efficient, but we don't remember the reason why it's done like that ...
> Here is the convo
> elecharny in OperationalService
> akarasulu yep
> elecharny when doing a modify,
> akarasulu ahha
> elecharny you first call the next interceptor, then you update the nexus with the entry with
> elecharny two new attributes
> elecharny why don't you add the attrs into the entry and then call the netx interceptors ?
> akarasulu hmmm I had some reason for this
> elecharny this is a simple modify instead of two
> akarasulu don't remember
> akarasulu yeah yeah I see what you mean
> akarasulu can't remember now
> elecharny this seems to cost the double
> akarasulu yes it does
> akarasulu can you put this in JIRA
> elecharny yeah
> akarasulu just past this info
> akarasulu from IRC
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRSERVER-840) Double modification on a modify ?
Posted by "Alex Karasulu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Karasulu updated DIRSERVER-840:
------------------------------------
Fix Version/s: (was: 1.5.3)
1.5.5
> Double modification on a modify ?
> ---------------------------------
>
> Key: DIRSERVER-840
> URL: https://issues.apache.org/jira/browse/DIRSERVER-840
> Project: Directory ApacheDS
> Issue Type: Improvement
> Affects Versions: 1.5.1
> Reporter: Emmanuel Lecharny
> Assignee: Emmanuel Lecharny
> Fix For: 1.5.5
>
>
> We have had a convo with alex about the OperationalService. I saw that when doing a modification on an entry, we first call the next interceptor (and this will modify the entry on the backend), then we add two new attributes (modifiers name and date) and store again the data into the backend. This does not seems to be very efficient, but we don't remember the reason why it's done like that ...
> Here is the convo
> elecharny in OperationalService
> akarasulu yep
> elecharny when doing a modify,
> akarasulu ahha
> elecharny you first call the next interceptor, then you update the nexus with the entry with
> elecharny two new attributes
> elecharny why don't you add the attrs into the entry and then call the netx interceptors ?
> akarasulu hmmm I had some reason for this
> elecharny this is a simple modify instead of two
> akarasulu don't remember
> akarasulu yeah yeah I see what you mean
> akarasulu can't remember now
> elecharny this seems to cost the double
> akarasulu yes it does
> akarasulu can you put this in JIRA
> elecharny yeah
> akarasulu just past this info
> akarasulu from IRC
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRSERVER-840) Double modification on a modify ?
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Lecharny updated DIRSERVER-840:
----------------------------------------
Fix Version/s: (was: 1.5.5)
1.5.9
It falls into the 'Optimization' phase. Postponed to 1.5.9
> Double modification on a modify ?
> ---------------------------------
>
> Key: DIRSERVER-840
> URL: https://issues.apache.org/jira/browse/DIRSERVER-840
> Project: Directory ApacheDS
> Issue Type: Improvement
> Affects Versions: 1.5.1
> Reporter: Emmanuel Lecharny
> Assignee: Emmanuel Lecharny
> Fix For: 1.5.9
>
>
> We have had a convo with alex about the OperationalService. I saw that when doing a modification on an entry, we first call the next interceptor (and this will modify the entry on the backend), then we add two new attributes (modifiers name and date) and store again the data into the backend. This does not seems to be very efficient, but we don't remember the reason why it's done like that ...
> Here is the convo
> elecharny in OperationalService
> akarasulu yep
> elecharny when doing a modify,
> akarasulu ahha
> elecharny you first call the next interceptor, then you update the nexus with the entry with
> elecharny two new attributes
> elecharny why don't you add the attrs into the entry and then call the netx interceptors ?
> akarasulu hmmm I had some reason for this
> elecharny this is a simple modify instead of two
> akarasulu don't remember
> akarasulu yeah yeah I see what you mean
> akarasulu can't remember now
> elecharny this seems to cost the double
> akarasulu yes it does
> akarasulu can you put this in JIRA
> elecharny yeah
> akarasulu just past this info
> akarasulu from IRC
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRSERVER-840) Double modification on a modify ?
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Lecharny updated DIRSERVER-840:
----------------------------------------
Fix Version/s: (was: 1.5.9)
2.0.0-RC1
Affected to 2.0.0-RC1, we won't release a 1.5.9
> Double modification on a modify ?
> ---------------------------------
>
> Key: DIRSERVER-840
> URL: https://issues.apache.org/jira/browse/DIRSERVER-840
> Project: Directory ApacheDS
> Issue Type: Improvement
> Affects Versions: 1.5.1
> Reporter: Emmanuel Lecharny
> Assignee: Emmanuel Lecharny
> Fix For: 2.0.0-RC1
>
>
> We have had a convo with alex about the OperationalService. I saw that when doing a modification on an entry, we first call the next interceptor (and this will modify the entry on the backend), then we add two new attributes (modifiers name and date) and store again the data into the backend. This does not seems to be very efficient, but we don't remember the reason why it's done like that ...
> Here is the convo
> elecharny in OperationalService
> akarasulu yep
> elecharny when doing a modify,
> akarasulu ahha
> elecharny you first call the next interceptor, then you update the nexus with the entry with
> elecharny two new attributes
> elecharny why don't you add the attrs into the entry and then call the netx interceptors ?
> akarasulu hmmm I had some reason for this
> elecharny this is a simple modify instead of two
> akarasulu don't remember
> akarasulu yeah yeah I see what you mean
> akarasulu can't remember now
> elecharny this seems to cost the double
> akarasulu yes it does
> akarasulu can you put this in JIRA
> elecharny yeah
> akarasulu just past this info
> akarasulu from IRC
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRSERVER-840) Double modification on a modify ?
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Lecharny updated DIRSERVER-840:
----------------------------------------
Fix Version/s: 1.5.1
> Double modification on a modify ?
> ---------------------------------
>
> Key: DIRSERVER-840
> URL: https://issues.apache.org/jira/browse/DIRSERVER-840
> Project: Directory ApacheDS
> Issue Type: Improvement
> Reporter: Emmanuel Lecharny
> Assigned To: Alex Karasulu
> Fix For: 1.5.1
>
>
> We have had a convo with alex about the OperationalService. I saw that when doing a modification on an entry, we first call the next interceptor (and this will modify the entry on the backend), then we add two new attributes (modifiers name and date) and store again the data into the backend. This does not seems to be very efficient, but we don't remember the reason why it's done like that ...
> Here is the convo
> elecharny in OperationalService
> akarasulu yep
> elecharny when doing a modify,
> akarasulu ahha
> elecharny you first call the next interceptor, then you update the nexus with the entry with
> elecharny two new attributes
> elecharny why don't you add the attrs into the entry and then call the netx interceptors ?
> akarasulu hmmm I had some reason for this
> elecharny this is a simple modify instead of two
> akarasulu don't remember
> akarasulu yeah yeah I see what you mean
> akarasulu can't remember now
> elecharny this seems to cost the double
> akarasulu yes it does
> akarasulu can you put this in JIRA
> elecharny yeah
> akarasulu just past this info
> akarasulu from IRC
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRSERVER-840) Double modification on a modify ?
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Lecharny updated DIRSERVER-840:
----------------------------------------
Affects Version/s: 1.5.1
Fix Version/s: (was: 1.5.1)
1.5.2
We can't affect a bug to a released version ! Rescheduled to 1.5.2
> Double modification on a modify ?
> ---------------------------------
>
> Key: DIRSERVER-840
> URL: https://issues.apache.org/jira/browse/DIRSERVER-840
> Project: Directory ApacheDS
> Issue Type: Improvement
> Affects Versions: 1.5.1
> Reporter: Emmanuel Lecharny
> Assignee: Emmanuel Lecharny
> Fix For: 1.5.2
>
>
> We have had a convo with alex about the OperationalService. I saw that when doing a modification on an entry, we first call the next interceptor (and this will modify the entry on the backend), then we add two new attributes (modifiers name and date) and store again the data into the backend. This does not seems to be very efficient, but we don't remember the reason why it's done like that ...
> Here is the convo
> elecharny in OperationalService
> akarasulu yep
> elecharny when doing a modify,
> akarasulu ahha
> elecharny you first call the next interceptor, then you update the nexus with the entry with
> elecharny two new attributes
> elecharny why don't you add the attrs into the entry and then call the netx interceptors ?
> akarasulu hmmm I had some reason for this
> elecharny this is a simple modify instead of two
> akarasulu don't remember
> akarasulu yeah yeah I see what you mean
> akarasulu can't remember now
> elecharny this seems to cost the double
> akarasulu yes it does
> akarasulu can you put this in JIRA
> elecharny yeah
> akarasulu just past this info
> akarasulu from IRC
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DIRSERVER-840) Double modification on a modify ?
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Lecharny closed DIRSERVER-840.
---------------------------------------
> Double modification on a modify ?
> ---------------------------------
>
> Key: DIRSERVER-840
> URL: https://issues.apache.org/jira/browse/DIRSERVER-840
> Project: Directory ApacheDS
> Issue Type: Improvement
> Affects Versions: 1.5.1
> Reporter: Emmanuel Lecharny
> Assignee: Emmanuel Lecharny
> Fix For: 2.0.0-RC1
>
>
> We have had a convo with alex about the OperationalService. I saw that when doing a modification on an entry, we first call the next interceptor (and this will modify the entry on the backend), then we add two new attributes (modifiers name and date) and store again the data into the backend. This does not seems to be very efficient, but we don't remember the reason why it's done like that ...
> Here is the convo
> elecharny in OperationalService
> akarasulu yep
> elecharny when doing a modify,
> akarasulu ahha
> elecharny you first call the next interceptor, then you update the nexus with the entry with
> elecharny two new attributes
> elecharny why don't you add the attrs into the entry and then call the netx interceptors ?
> akarasulu hmmm I had some reason for this
> elecharny this is a simple modify instead of two
> akarasulu don't remember
> akarasulu yeah yeah I see what you mean
> akarasulu can't remember now
> elecharny this seems to cost the double
> akarasulu yes it does
> akarasulu can you put this in JIRA
> elecharny yeah
> akarasulu just past this info
> akarasulu from IRC
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRSERVER-840) Double modification on a modify ?
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632186#action_12632186 ]
Emmanuel Lecharny commented on DIRSERVER-840:
---------------------------------------------
modifiersName and modifyTimestamp Operational Attributes are NO-USER-MODIFICATION attributes, so they should not be ruled out by the schema interceptor.
> Double modification on a modify ?
> ---------------------------------
>
> Key: DIRSERVER-840
> URL: https://issues.apache.org/jira/browse/DIRSERVER-840
> Project: Directory ApacheDS
> Issue Type: Improvement
> Affects Versions: 1.5.1
> Reporter: Emmanuel Lecharny
> Assignee: Emmanuel Lecharny
> Fix For: 1.5.5
>
>
> We have had a convo with alex about the OperationalService. I saw that when doing a modification on an entry, we first call the next interceptor (and this will modify the entry on the backend), then we add two new attributes (modifiers name and date) and store again the data into the backend. This does not seems to be very efficient, but we don't remember the reason why it's done like that ...
> Here is the convo
> elecharny in OperationalService
> akarasulu yep
> elecharny when doing a modify,
> akarasulu ahha
> elecharny you first call the next interceptor, then you update the nexus with the entry with
> elecharny two new attributes
> elecharny why don't you add the attrs into the entry and then call the netx interceptors ?
> akarasulu hmmm I had some reason for this
> elecharny this is a simple modify instead of two
> akarasulu don't remember
> akarasulu yeah yeah I see what you mean
> akarasulu can't remember now
> elecharny this seems to cost the double
> akarasulu yes it does
> akarasulu can you put this in JIRA
> elecharny yeah
> akarasulu just past this info
> akarasulu from IRC
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (DIRSERVER-840) Double modification on a modify ?
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Lecharny reopened DIRSERVER-840:
-----------------------------------------
Assignee: Emmanuel Lecharny (was: Alex Karasulu)
Still present in trunk...
> Double modification on a modify ?
> ---------------------------------
>
> Key: DIRSERVER-840
> URL: https://issues.apache.org/jira/browse/DIRSERVER-840
> Project: Directory ApacheDS
> Issue Type: Improvement
> Reporter: Emmanuel Lecharny
> Assignee: Emmanuel Lecharny
> Fix For: 1.5.1
>
>
> We have had a convo with alex about the OperationalService. I saw that when doing a modification on an entry, we first call the next interceptor (and this will modify the entry on the backend), then we add two new attributes (modifiers name and date) and store again the data into the backend. This does not seems to be very efficient, but we don't remember the reason why it's done like that ...
> Here is the convo
> elecharny in OperationalService
> akarasulu yep
> elecharny when doing a modify,
> akarasulu ahha
> elecharny you first call the next interceptor, then you update the nexus with the entry with
> elecharny two new attributes
> elecharny why don't you add the attrs into the entry and then call the netx interceptors ?
> akarasulu hmmm I had some reason for this
> elecharny this is a simple modify instead of two
> akarasulu don't remember
> akarasulu yeah yeah I see what you mean
> akarasulu can't remember now
> elecharny this seems to cost the double
> akarasulu yes it does
> akarasulu can you put this in JIRA
> elecharny yeah
> akarasulu just past this info
> akarasulu from IRC
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRSERVER-840) Double modification on a modify ?
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632232#action_12632232 ]
Emmanuel Lecharny commented on DIRSERVER-840:
---------------------------------------------
The big issue we have is that the ChangeLog interceptor is trying to revert the modification, and this include modification of operational attributes which have been added in the second pass.
IMO, we should create a second class of attributes : those who have been added by the server, w<hich shoul dbypass the Schema Interceptor.
> Double modification on a modify ?
> ---------------------------------
>
> Key: DIRSERVER-840
> URL: https://issues.apache.org/jira/browse/DIRSERVER-840
> Project: Directory ApacheDS
> Issue Type: Improvement
> Affects Versions: 1.5.1
> Reporter: Emmanuel Lecharny
> Assignee: Emmanuel Lecharny
> Fix For: 1.5.5
>
>
> We have had a convo with alex about the OperationalService. I saw that when doing a modification on an entry, we first call the next interceptor (and this will modify the entry on the backend), then we add two new attributes (modifiers name and date) and store again the data into the backend. This does not seems to be very efficient, but we don't remember the reason why it's done like that ...
> Here is the convo
> elecharny in OperationalService
> akarasulu yep
> elecharny when doing a modify,
> akarasulu ahha
> elecharny you first call the next interceptor, then you update the nexus with the entry with
> elecharny two new attributes
> elecharny why don't you add the attrs into the entry and then call the netx interceptors ?
> akarasulu hmmm I had some reason for this
> elecharny this is a simple modify instead of two
> akarasulu don't remember
> akarasulu yeah yeah I see what you mean
> akarasulu can't remember now
> elecharny this seems to cost the double
> akarasulu yes it does
> akarasulu can you put this in JIRA
> elecharny yeah
> akarasulu just past this info
> akarasulu from IRC
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (DIRSERVER-840) Double modification on a modify ?
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Lecharny reopened DIRSERVER-840:
-----------------------------------------
I reopen the issue, because the double modification _is_ necessary. The 'fix' had a very bad side effect, which was not exhibited because the way the operational attributes were added to the list of modified attributes was incorrect : the list was never modifed in fact...
Here is the reason why we need this double modification :
- the opAttr interceptor first call the schema interceptor
- the schema interceptor check for every modification, and if the modified attr is not modifable by user (and this is the case for modifiersName and modifyTimestamp), it generates an error
- as the opAttr interceptor was not correctly injecting those two attrs into the modification list, it worked well, except that we lost those modifications
- and at the end, the second modification was here to store those operational attribute directly into the nexus.
What was bad about this double modification (and still is) is that we cannot guarantee that the operation is atomic( we have 2 mods in a row for the same entry). Even from the perf perspective, it's far from being perect.
Now the problem is that we have no easy way to add the 2 opAttrs before calling the schema interceptor, because those attrs will be seen as invalid, and it will generate an error.
One possible solution would be to add a flag in the ModificationItem structure to signal an attribute which has been added by the server.
> Double modification on a modify ?
> ---------------------------------
>
> Key: DIRSERVER-840
> URL: https://issues.apache.org/jira/browse/DIRSERVER-840
> Project: Directory ApacheDS
> Issue Type: Improvement
> Reporter: Emmanuel Lecharny
> Assignee: Alex Karasulu
> Fix For: 1.5.1
>
>
> We have had a convo with alex about the OperationalService. I saw that when doing a modification on an entry, we first call the next interceptor (and this will modify the entry on the backend), then we add two new attributes (modifiers name and date) and store again the data into the backend. This does not seems to be very efficient, but we don't remember the reason why it's done like that ...
> Here is the convo
> elecharny in OperationalService
> akarasulu yep
> elecharny when doing a modify,
> akarasulu ahha
> elecharny you first call the next interceptor, then you update the nexus with the entry with
> elecharny two new attributes
> elecharny why don't you add the attrs into the entry and then call the netx interceptors ?
> akarasulu hmmm I had some reason for this
> elecharny this is a simple modify instead of two
> akarasulu don't remember
> akarasulu yeah yeah I see what you mean
> akarasulu can't remember now
> elecharny this seems to cost the double
> akarasulu yes it does
> akarasulu can you put this in JIRA
> elecharny yeah
> akarasulu just past this info
> akarasulu from IRC
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRSERVER-840) Double modification on a modify ?
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631860#action_12631860 ]
Emmanuel Lecharny commented on DIRSERVER-840:
---------------------------------------------
I just wonder why an operationnal attribute is checked against the schema ??? This sounds like a nonsense, as Op attr are managed by the server itself, so they are just always valid !
> Double modification on a modify ?
> ---------------------------------
>
> Key: DIRSERVER-840
> URL: https://issues.apache.org/jira/browse/DIRSERVER-840
> Project: Directory ApacheDS
> Issue Type: Improvement
> Affects Versions: 1.5.1
> Reporter: Emmanuel Lecharny
> Assignee: Emmanuel Lecharny
> Fix For: 1.5.5
>
>
> We have had a convo with alex about the OperationalService. I saw that when doing a modification on an entry, we first call the next interceptor (and this will modify the entry on the backend), then we add two new attributes (modifiers name and date) and store again the data into the backend. This does not seems to be very efficient, but we don't remember the reason why it's done like that ...
> Here is the convo
> elecharny in OperationalService
> akarasulu yep
> elecharny when doing a modify,
> akarasulu ahha
> elecharny you first call the next interceptor, then you update the nexus with the entry with
> elecharny two new attributes
> elecharny why don't you add the attrs into the entry and then call the netx interceptors ?
> akarasulu hmmm I had some reason for this
> elecharny this is a simple modify instead of two
> akarasulu don't remember
> akarasulu yeah yeah I see what you mean
> akarasulu can't remember now
> elecharny this seems to cost the double
> akarasulu yes it does
> akarasulu can you put this in JIRA
> elecharny yeah
> akarasulu just past this info
> akarasulu from IRC
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRSERVER-840) Double modification on a modify ?
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Lecharny updated DIRSERVER-840:
----------------------------------------
Fix Version/s: (was: 1.5.2)
1.5.3
Postponed.
> Double modification on a modify ?
> ---------------------------------
>
> Key: DIRSERVER-840
> URL: https://issues.apache.org/jira/browse/DIRSERVER-840
> Project: Directory ApacheDS
> Issue Type: Improvement
> Affects Versions: 1.5.1
> Reporter: Emmanuel Lecharny
> Assignee: Emmanuel Lecharny
> Fix For: 1.5.3
>
>
> We have had a convo with alex about the OperationalService. I saw that when doing a modification on an entry, we first call the next interceptor (and this will modify the entry on the backend), then we add two new attributes (modifiers name and date) and store again the data into the backend. This does not seems to be very efficient, but we don't remember the reason why it's done like that ...
> Here is the convo
> elecharny in OperationalService
> akarasulu yep
> elecharny when doing a modify,
> akarasulu ahha
> elecharny you first call the next interceptor, then you update the nexus with the entry with
> elecharny two new attributes
> elecharny why don't you add the attrs into the entry and then call the netx interceptors ?
> akarasulu hmmm I had some reason for this
> elecharny this is a simple modify instead of two
> akarasulu don't remember
> akarasulu yeah yeah I see what you mean
> akarasulu can't remember now
> elecharny this seems to cost the double
> akarasulu yes it does
> akarasulu can you put this in JIRA
> elecharny yeah
> akarasulu just past this info
> akarasulu from IRC
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DIRSERVER-840) Double modification on a modify ?
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Lecharny resolved DIRSERVER-840.
-----------------------------------------
Resolution: Fixed
Fixed in schema refactoring branch, as a side fix.
> Double modification on a modify ?
> ---------------------------------
>
> Key: DIRSERVER-840
> URL: https://issues.apache.org/jira/browse/DIRSERVER-840
> Project: Directory ApacheDS
> Issue Type: Improvement
> Affects Versions: 1.5.1
> Reporter: Emmanuel Lecharny
> Assignee: Emmanuel Lecharny
> Fix For: 2.0.0-RC1
>
>
> We have had a convo with alex about the OperationalService. I saw that when doing a modification on an entry, we first call the next interceptor (and this will modify the entry on the backend), then we add two new attributes (modifiers name and date) and store again the data into the backend. This does not seems to be very efficient, but we don't remember the reason why it's done like that ...
> Here is the convo
> elecharny in OperationalService
> akarasulu yep
> elecharny when doing a modify,
> akarasulu ahha
> elecharny you first call the next interceptor, then you update the nexus with the entry with
> elecharny two new attributes
> elecharny why don't you add the attrs into the entry and then call the netx interceptors ?
> akarasulu hmmm I had some reason for this
> elecharny this is a simple modify instead of two
> akarasulu don't remember
> akarasulu yeah yeah I see what you mean
> akarasulu can't remember now
> elecharny this seems to cost the double
> akarasulu yes it does
> akarasulu can you put this in JIRA
> elecharny yeah
> akarasulu just past this info
> akarasulu from IRC
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.