You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/10/08 02:29:05 UTC

[GitHub] [iotdb] Ring-k edited a comment on pull request #1795: [IOTDB-933] Fix antlr4 which caused benchmark throw exception

Ring-k edited a comment on pull request #1795:
URL: https://github.com/apache/iotdb/pull/1795#issuecomment-705292697


   Good job! By the way, it would be better if there were more tests for parsing, especially use cases similar to what is shown above in your discription, where the environment should be similar to the benchmark (e.g. running multiple threads). Someone may change the antlr file in future, and these tests will be helpful.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org