You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2017/08/14 12:52:07 UTC

[GitHub] flink pull request #4540: [FLINK-7444] [rpc] Make external calls non-blockin...

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/4540

    [FLINK-7444] [rpc] Make external calls non-blocking

    ## What is the purpose of the change
    
    Make all external calls from the RpcEndpoint's main thread non blocking by
    executing them as a runnable in an Executor.
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink makeEndpointsNonBlocking

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4540.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4540
    
----
commit ccaabc5c54fb91bdbadbc22191565e308c0f4c1b
Author: Till Rohrmann <tr...@apache.org>
Date:   2017-08-14T12:48:33Z

    [FLINK-7444] [rpc] Make external calls non-blocking
    
    Make all external calls from the RpcEndpoint's main thread non blocking by
    executing them as a runnable in an Executor.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4540: [FLINK-7444] [rpc] Make external calls non-blocking

Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/4540
  
    I've made the `FatalErrorHandler` calls non asynchronous. Rebasing and if Travis gives green light, I'll merge this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #4540: [FLINK-7444] [rpc] Make external calls non-blockin...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/4540


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---