You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by vi...@apache.org on 2015/04/24 03:31:29 UTC

[1/6] cordova-plugin-dialogs git commit: CB-8858 Updated version and RELEASENOTES.md for release 1.0.0

Repository: cordova-plugin-dialogs
Updated Branches:
  refs/heads/CB-8860cordova-plugin-dialogs 77f66f961 -> ee3b02b3c


CB-8858 Updated version and RELEASENOTES.md for release 1.0.0


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/commit/6e8948a8
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/tree/6e8948a8
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/diff/6e8948a8

Branch: refs/heads/CB-8860cordova-plugin-dialogs
Commit: 6e8948a8e93ef63abf425da106ab02313b91e019
Parents: 77f66f9
Author: Steve Gill <st...@gmail.com>
Authored: Wed Apr 15 11:06:38 2015 -0700
Committer: Steve Gill <st...@gmail.com>
Committed: Wed Apr 15 11:06:38 2015 -0700

----------------------------------------------------------------------
 RELEASENOTES.md  | 14 ++++++++++++++
 plugin.xml       |  2 +-
 tests/plugin.xml |  2 +-
 3 files changed, 16 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/blob/6e8948a8/RELEASENOTES.md
----------------------------------------------------------------------
diff --git a/RELEASENOTES.md b/RELEASENOTES.md
index a94676e..b55b494 100644
--- a/RELEASENOTES.md
+++ b/RELEASENOTES.md
@@ -115,3 +115,17 @@
 * Correct way to specify Windows platform in config.xml
 * CB-8351 ios: Use argumentForIndex rather than NSArray extension
 * CB-7955 Add support "browser" platform
+
+### 1.0.0 (Apr 15, 2015)
+* CB-8746 gave plugin major version bump
+* CB-8683 updated wp and bb specific references of old id to new id
+* CB-8683 changed plugin-id to pacakge-name
+* CB-8653 properly updated translated docs to use new id
+* CB-8653 updated translated docs to use new id
+* Use TRAVIS_BUILD_DIR, install paramedic by npm
+* CB-8653 Updated Readme
+* CB-8659: ios: 4.0.x Compatibility: Remove use of deprecated headers
+* CB-8565 Integrate TravisCI
+* CB-8438 cordova-plugin-dialogs documentation translation: cordova-plugin-dialogs
+* CB-8538 Added package.json file
+* CB-8367 [org.apache.cordova.dialogs] Add Prompt support on Windows

http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/blob/6e8948a8/plugin.xml
----------------------------------------------------------------------
diff --git a/plugin.xml b/plugin.xml
index 0c3b684..8a58818 100644
--- a/plugin.xml
+++ b/plugin.xml
@@ -20,7 +20,7 @@
 
 <plugin xmlns="http://apache.org/cordova/ns/plugins/1.0"
            id="cordova-plugin-dialogs"
-      version="1.0.0-dev">
+      version="1.0.0">
 
     <name>Notification</name>
     <description>Cordova Notification Plugin</description>

http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/blob/6e8948a8/tests/plugin.xml
----------------------------------------------------------------------
diff --git a/tests/plugin.xml b/tests/plugin.xml
index 5e79cd4..ae26324 100644
--- a/tests/plugin.xml
+++ b/tests/plugin.xml
@@ -20,7 +20,7 @@
 
 <plugin xmlns="http://apache.org/cordova/ns/plugins/1.0"
     id="cordova-plugin-dialogs-tests"
-    version="0.3.1-dev">
+    version="1.0.0">
     <name>Cordova Notification Plugin Tests</name>
     <license>Apache 2.0</license>
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


[4/6] cordova-plugin-dialogs git commit: CB-8858 Updated version in package.json for release 1.0.0

Posted by vi...@apache.org.
CB-8858 Updated version in package.json for release 1.0.0


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/commit/6b06471c
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/tree/6b06471c
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/diff/6b06471c

Branch: refs/heads/CB-8860cordova-plugin-dialogs
Commit: 6b06471cccbde5f679d1f68e2f664ea38d94367e
Parents: 943c91b
Author: Steve Gill <st...@gmail.com>
Authored: Wed Apr 15 15:50:47 2015 -0700
Committer: Steve Gill <st...@gmail.com>
Committed: Wed Apr 15 15:50:47 2015 -0700

----------------------------------------------------------------------
 package.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/blob/6b06471c/package.json
----------------------------------------------------------------------
diff --git a/package.json b/package.json
index 8814a99..cbb6194 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "cordova-plugin-dialogs",
-  "version": "1.0.0-dev",
+  "version": "1.0.0",
   "description": "Cordova Notification Plugin",
   "cordova": {
     "id": "cordova-plugin-dialogs",


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


[2/6] cordova-plugin-dialogs git commit: CB-8858 Incremented plugin version.

Posted by vi...@apache.org.
CB-8858 Incremented plugin version.


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/commit/27a30996
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/tree/27a30996
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/diff/27a30996

Branch: refs/heads/CB-8860cordova-plugin-dialogs
Commit: 27a309965b33dd5537a5fff4ee46d1d560ddac19
Parents: 6e8948a
Author: Steve Gill <st...@gmail.com>
Authored: Wed Apr 15 13:55:47 2015 -0700
Committer: Steve Gill <st...@gmail.com>
Committed: Wed Apr 15 13:55:47 2015 -0700

----------------------------------------------------------------------
 plugin.xml       | 2 +-
 tests/plugin.xml | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/blob/27a30996/plugin.xml
----------------------------------------------------------------------
diff --git a/plugin.xml b/plugin.xml
index 8a58818..48d881c 100644
--- a/plugin.xml
+++ b/plugin.xml
@@ -20,7 +20,7 @@
 
 <plugin xmlns="http://apache.org/cordova/ns/plugins/1.0"
            id="cordova-plugin-dialogs"
-      version="1.0.0">
+      version="1.0.1-dev">
 
     <name>Notification</name>
     <description>Cordova Notification Plugin</description>

http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/blob/27a30996/tests/plugin.xml
----------------------------------------------------------------------
diff --git a/tests/plugin.xml b/tests/plugin.xml
index ae26324..1cb171f 100644
--- a/tests/plugin.xml
+++ b/tests/plugin.xml
@@ -20,7 +20,7 @@
 
 <plugin xmlns="http://apache.org/cordova/ns/plugins/1.0"
     id="cordova-plugin-dialogs-tests"
-    version="1.0.0">
+    version="1.0.1-dev">
     <name>Cordova Notification Plugin Tests</name>
     <license>Apache 2.0</license>
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


[5/6] cordova-plugin-dialogs git commit: CB-8858 Incremented plugin version.

Posted by vi...@apache.org.
CB-8858 Incremented plugin version.


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/commit/f751b8e6
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/tree/f751b8e6
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/diff/f751b8e6

Branch: refs/heads/CB-8860cordova-plugin-dialogs
Commit: f751b8e6f99b93f0085000b85c703a936059e789
Parents: 6b06471
Author: Steve Gill <st...@gmail.com>
Authored: Wed Apr 15 16:00:22 2015 -0700
Committer: Steve Gill <st...@gmail.com>
Committed: Wed Apr 15 16:00:22 2015 -0700

----------------------------------------------------------------------
 package.json     | 2 +-
 plugin.xml       | 2 +-
 tests/plugin.xml | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/blob/f751b8e6/package.json
----------------------------------------------------------------------
diff --git a/package.json b/package.json
index cbb6194..863c62a 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "cordova-plugin-dialogs",
-  "version": "1.0.0",
+  "version": "1.0.1-dev",
   "description": "Cordova Notification Plugin",
   "cordova": {
     "id": "cordova-plugin-dialogs",

http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/blob/f751b8e6/plugin.xml
----------------------------------------------------------------------
diff --git a/plugin.xml b/plugin.xml
index 8a58818..48d881c 100644
--- a/plugin.xml
+++ b/plugin.xml
@@ -20,7 +20,7 @@
 
 <plugin xmlns="http://apache.org/cordova/ns/plugins/1.0"
            id="cordova-plugin-dialogs"
-      version="1.0.0">
+      version="1.0.1-dev">
 
     <name>Notification</name>
     <description>Cordova Notification Plugin</description>

http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/blob/f751b8e6/tests/plugin.xml
----------------------------------------------------------------------
diff --git a/tests/plugin.xml b/tests/plugin.xml
index ae26324..1cb171f 100644
--- a/tests/plugin.xml
+++ b/tests/plugin.xml
@@ -20,7 +20,7 @@
 
 <plugin xmlns="http://apache.org/cordova/ns/plugins/1.0"
     id="cordova-plugin-dialogs-tests"
-    version="1.0.0">
+    version="1.0.1-dev">
     <name>Cordova Notification Plugin Tests</name>
     <license>Apache 2.0</license>
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


[3/6] cordova-plugin-dialogs git commit: Revert "CB-8858 Incremented plugin version."

Posted by vi...@apache.org.
Revert "CB-8858 Incremented plugin version."

This reverts commit 27a309965b33dd5537a5fff4ee46d1d560ddac19.


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/commit/943c91bd
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/tree/943c91bd
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/diff/943c91bd

Branch: refs/heads/CB-8860cordova-plugin-dialogs
Commit: 943c91bdf71949b53f7da40e3ef0db85c44583a2
Parents: 27a3099
Author: Steve Gill <st...@gmail.com>
Authored: Wed Apr 15 14:31:03 2015 -0700
Committer: Steve Gill <st...@gmail.com>
Committed: Wed Apr 15 14:31:03 2015 -0700

----------------------------------------------------------------------
 plugin.xml       | 2 +-
 tests/plugin.xml | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/blob/943c91bd/plugin.xml
----------------------------------------------------------------------
diff --git a/plugin.xml b/plugin.xml
index 48d881c..8a58818 100644
--- a/plugin.xml
+++ b/plugin.xml
@@ -20,7 +20,7 @@
 
 <plugin xmlns="http://apache.org/cordova/ns/plugins/1.0"
            id="cordova-plugin-dialogs"
-      version="1.0.1-dev">
+      version="1.0.0">
 
     <name>Notification</name>
     <description>Cordova Notification Plugin</description>

http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/blob/943c91bd/tests/plugin.xml
----------------------------------------------------------------------
diff --git a/tests/plugin.xml b/tests/plugin.xml
index 1cb171f..ae26324 100644
--- a/tests/plugin.xml
+++ b/tests/plugin.xml
@@ -20,7 +20,7 @@
 
 <plugin xmlns="http://apache.org/cordova/ns/plugins/1.0"
     id="cordova-plugin-dialogs-tests"
-    version="1.0.1-dev">
+    version="1.0.0">
     <name>Cordova Notification Plugin Tests</name>
     <license>Apache 2.0</license>
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


[6/6] cordova-plugin-dialogs git commit: CB-7734 - "navigator.notification.alert" or "navigator.notification.confirm" seem have a "many words" issue. (closes #39)

Posted by vi...@apache.org.
CB-7734 - "navigator.notification.alert" or "navigator.notification.confirm" seem have a "many words" issue. (closes #39)

Changed plugin to use UIAlertController on iOS 8 and greater instead of
the UIAlertView.
It makes the message scrollable is the text is too long.

Fixes the crash on iOS 8.3 while fixing the too many works
problem on previous versions. The too many words problem is not present
on iOS 8.3

Fixes the problem on landscape mode.
The problem was still present on iPhone and iPod touch devices when the
dialog was shown on landscape mode, now it’s fixed


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/commit/ee3b02b3
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/tree/ee3b02b3
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/diff/ee3b02b3

Branch: refs/heads/CB-8860cordova-plugin-dialogs
Commit: ee3b02b3c78debe608263d847f7ac69bda1bfca0
Parents: f751b8e
Author: Julio César <jc...@gmail.com>
Authored: Sat Oct 25 00:38:06 2014 +0200
Committer: Shazron Abdullah <sh...@apache.org>
Committed: Mon Apr 20 15:28:34 2015 -0700

----------------------------------------------------------------------
 src/ios/CDVNotification.m | 106 +++++++++++++++++++++++++++++++++--------
 1 file changed, 86 insertions(+), 20 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/blob/ee3b02b3/src/ios/CDVNotification.m
----------------------------------------------------------------------
diff --git a/src/ios/CDVNotification.m b/src/ios/CDVNotification.m
index 441744f..1581ad3 100644
--- a/src/ios/CDVNotification.m
+++ b/src/ios/CDVNotification.m
@@ -38,28 +38,94 @@ static void soundCompletionCallback(SystemSoundID ssid, void* data);
  */
 - (void)showDialogWithMessage:(NSString*)message title:(NSString*)title buttons:(NSArray*)buttons defaultText:(NSString*)defaultText callbackId:(NSString*)callbackId dialogType:(NSString*)dialogType
 {
-    CDVAlertView* alertView = [[CDVAlertView alloc]
-        initWithTitle:title
-                  message:message
-                 delegate:self
-        cancelButtonTitle:nil
-        otherButtonTitles:nil];
-
-    alertView.callbackId = callbackId;
-
+    
     NSUInteger count = [buttons count];
-
-    for (int n = 0; n < count; n++) {
-        [alertView addButtonWithTitle:[buttons objectAtIndex:n]];
-    }
-
-    if ([dialogType isEqualToString:DIALOG_TYPE_PROMPT]) {
-        alertView.alertViewStyle = UIAlertViewStylePlainTextInput;
-        UITextField* textField = [alertView textFieldAtIndex:0];
-        textField.text = defaultText;
+#ifdef __IPHONE_8_0
+    if (NSClassFromString(@"UIAlertController")) {
+        
+        UIAlertController *alertController = [UIAlertController alertControllerWithTitle:title message:message preferredStyle:UIAlertControllerStyleAlert];
+        
+        if ([[[UIDevice currentDevice] systemVersion] floatValue] < 8.3) {
+            
+            CGRect alertFrame = [UIScreen mainScreen].applicationFrame;
+            
+            if (UIInterfaceOrientationIsLandscape([[UIApplication sharedApplication] statusBarOrientation])) {
+                // swap the values for the app frame since it is now in landscape
+                CGFloat temp = alertFrame.size.width;
+                alertFrame.size.width = alertFrame.size.height;
+                alertFrame.size.height = temp;
+            }
+            
+            alertController.view.frame =  alertFrame;
+        }
+        
+        for (int n = 0; n < count; n++) {
+            
+            UIAlertAction* action = [UIAlertAction actionWithTitle:[buttons objectAtIndex:n] style:UIAlertActionStyleDefault handler:^(UIAlertAction * action)
+                                     {
+                                         CDVPluginResult* result;
+                                         
+                                         if ([dialogType isEqualToString:DIALOG_TYPE_PROMPT]) {
+                                             
+                                             NSString* value0 = [[alertController.textFields objectAtIndex:0] text];
+                                             NSDictionary* info = @{
+                                                                    @"buttonIndex":@(n + 1),
+                                                                    @"input1":(value0 ? value0 : [NSNull null])
+                                                                    };
+                                             result = [CDVPluginResult resultWithStatus:CDVCommandStatus_OK messageAsDictionary:info];
+                                             
+                                         } else {
+                                             
+                                             result = [CDVPluginResult resultWithStatus:CDVCommandStatus_OK messageAsInt:(int)(n  + 1)];
+                                             
+                                         }
+                                         
+                                         [self.commandDelegate sendPluginResult:result callbackId:callbackId];
+                                         
+                                     }];
+            [alertController addAction:action];
+            
+        }
+        
+        if ([dialogType isEqualToString:DIALOG_TYPE_PROMPT]) {
+            
+            [alertController addTextFieldWithConfigurationHandler:^(UITextField *textField) {
+                textField.text = defaultText;
+            }];
+        }
+        
+        
+        
+        [self.viewController presentViewController:alertController animated:YES completion:nil];
+        
+    } else {
+#endif
+        CDVAlertView* alertView = [[CDVAlertView alloc]
+                                   initWithTitle:title
+                                   message:message
+                                   delegate:self
+                                   cancelButtonTitle:nil
+                                   otherButtonTitles:nil];
+        
+        alertView.callbackId = callbackId;
+        
+        
+        
+        for (int n = 0; n < count; n++) {
+            [alertView addButtonWithTitle:[buttons objectAtIndex:n]];
+        }
+        
+        if ([dialogType isEqualToString:DIALOG_TYPE_PROMPT]) {
+            alertView.alertViewStyle = UIAlertViewStylePlainTextInput;
+            UITextField* textField = [alertView textFieldAtIndex:0];
+            textField.text = defaultText;
+        }
+        
+        [alertView show];
+#ifdef __IPHONE_8_0
     }
-
-    [alertView show];
+#endif
+    
 }
 
 - (void)alert:(CDVInvokedUrlCommand*)command


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org