You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Lucene/Solr QA (JIRA)" <ji...@apache.org> on 2019/04/26 16:59:00 UTC
[jira] [Commented] (SOLR-13303) WrappedLongValuesSource should
always return `true` for advanceExact
[ https://issues.apache.org/jira/browse/SOLR-13303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16827122#comment-16827122 ]
Lucene/Solr QA commented on SOLR-13303:
---------------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 34s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} | {color:green} 0m 32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} | {color:green} 0m 32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} | {color:green} 0m 32s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 28s{color} | {color:green} queries in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 4m 5s{color} | {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-13303 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12961558/SOLR-13303.patch |
| Optional Tests | compile javac unit ratsources checkforbiddenapis validatesourcepatterns |
| uname | Linux lucene1-us-west 4.4.0-137-generic #163~14.04.1-Ubuntu SMP Mon Sep 24 17:14:57 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh |
| git revision | master / 35aeb7f |
| ant | version: Apache Ant(TM) version 1.9.3 compiled on July 24 2018 |
| Default Java | LTS |
| Test Results | https://builds.apache.org/job/PreCommit-SOLR-Build/388/testReport/ |
| modules | C: lucene/queries U: lucene/queries |
| Console output | https://builds.apache.org/job/PreCommit-SOLR-Build/388/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> WrappedLongValuesSource should always return `true` for advanceExact
> --------------------------------------------------------------------
>
> Key: SOLR-13303
> URL: https://issues.apache.org/jira/browse/SOLR-13303
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Affects Versions: 8.0
> Reporter: Andrzej Wislowski
> Priority: Major
> Attachments: SOLR-13303.patch
>
>
> Following https://issues.apache.org/jira/browse/SOLR-13126?focusedCommentId=16786635&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16786635
> WrappedLongValuesSource exposes an iterator and expects to jump over missing documents, while VS has an exists() method but still returns a value even if exists() is false. The wrapper code to convert VS to WrappedLongValuesSource checks whether or not the value exists, but instead it should always return `true`.
> This change is similar to the one made to WrappedLongValuesSource in https://issues.apache.org/jira/browse/SOLR-13126
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org