You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cayenne.apache.org by "Bryan Lewis (JIRA)" <ji...@apache.org> on 2009/06/30 01:31:47 UTC

[jira] Created: (CAY-1248) ClassCastException with OracleLOBBatchAction

ClassCastException with OracleLOBBatchAction
--------------------------------------------

                 Key: CAY-1248
                 URL: https://issues.apache.org/jira/browse/CAY-1248
             Project: Cayenne
          Issue Type: Bug
          Components: Cayenne Core Library
    Affects Versions: 3.0M6
         Environment: Oracle8
            Reporter: Bryan Lewis


DataDomainActionBuilder.batchAction calls delegate.batchAction():

    public SQLAction batchAction(BatchQuery query) {
        return new DataDomainBatchAction(domain, (BatchAction) delegate.batchAction(query));
    }

That delegate, OracleActionBuilder in our case, has some special handling:

    if (OracleAdapter.isSupportsOracleLOB() && OracleAdapter.updatesLOBColumns(query)) {
            return new OracleLOBBatchAction(query, getAdapter());

That class does not extend BatchAction (unlike the normal OracleBatchAction case) and the BatchAction cast fails.

The DataDomainActionBuilder is new code in 3.0.  Either it shouldn't cast to BatchAction, or OracleLOBBatchAction should extend BatchAction.

I've left this as a Major priority because it doesn't appear to be Oracle8-specific.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAY-1248) ClassCastException with OracleLOBBatchAction

Posted by "Bryan Lewis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAY-1248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725392#action_12725392 ] 

Bryan Lewis commented on CAY-1248:
----------------------------------

I've worked around it for our purposes by setting OracleAdapter.supportsOracleLOB to false, in OracleAdapter.initDriverInformation().  (I liked the TODO comment there... the static method did indeed make this messier to fix.)




> ClassCastException with OracleLOBBatchAction
> --------------------------------------------
>
>                 Key: CAY-1248
>                 URL: https://issues.apache.org/jira/browse/CAY-1248
>             Project: Cayenne
>          Issue Type: Bug
>          Components: Cayenne Core Library
>    Affects Versions: 3.0M6
>         Environment: Oracle8
>            Reporter: Bryan Lewis
>
> DataDomainActionBuilder.batchAction calls delegate.batchAction():
>     public SQLAction batchAction(BatchQuery query) {
>         return new DataDomainBatchAction(domain, (BatchAction) delegate.batchAction(query));
>     }
> That delegate, OracleActionBuilder in our case, has some special handling:
>     if (OracleAdapter.isSupportsOracleLOB() && OracleAdapter.updatesLOBColumns(query)) {
>             return new OracleLOBBatchAction(query, getAdapter());
> That class does not extend BatchAction (unlike the normal OracleBatchAction case) and the BatchAction cast fails.
> The DataDomainActionBuilder is new code in 3.0.  Either it shouldn't cast to BatchAction, or OracleLOBBatchAction should extend BatchAction.
> I've left this as a Major priority because it doesn't appear to be Oracle8-specific.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (CAY-1248) ClassCastException with OracleLOBBatchAction

Posted by "Andrey Razumovsky (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAY-1248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrey Razumovsky closed CAY-1248.
----------------------------------

       Resolution: Fixed
    Fix Version/s: 3.0 beta 1
         Assignee: Andrey Razumovsky

Already fixed [1]. BTW this was not in M6, only on trunk

[1]. http://cayenne.markmail.org/search/#query:list%3Aorg.apache.cayenne.dev+page:1+mid:3zcn2hxpnzoaxbd6+state:results

> ClassCastException with OracleLOBBatchAction
> --------------------------------------------
>
>                 Key: CAY-1248
>                 URL: https://issues.apache.org/jira/browse/CAY-1248
>             Project: Cayenne
>          Issue Type: Bug
>          Components: Cayenne Core Library
>    Affects Versions: 3.0M6
>         Environment: Oracle8
>            Reporter: Bryan Lewis
>            Assignee: Andrey Razumovsky
>             Fix For: 3.0 beta 1
>
>
> DataDomainActionBuilder.batchAction calls delegate.batchAction():
>     public SQLAction batchAction(BatchQuery query) {
>         return new DataDomainBatchAction(domain, (BatchAction) delegate.batchAction(query));
>     }
> That delegate, OracleActionBuilder in our case, has some special handling:
>     if (OracleAdapter.isSupportsOracleLOB() && OracleAdapter.updatesLOBColumns(query)) {
>             return new OracleLOBBatchAction(query, getAdapter());
> That class does not extend BatchAction (unlike the normal OracleBatchAction case) and the BatchAction cast fails.
> The DataDomainActionBuilder is new code in 3.0.  Either it shouldn't cast to BatchAction, or OracleLOBBatchAction should extend BatchAction.
> I've left this as a Major priority because it doesn't appear to be Oracle8-specific.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.