You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Jiawei Wang (Code Review)" <ge...@cloudera.org> on 2019/10/30 18:39:23 UTC
[Impala-ASF-CR] IMPALA-9105: Catalog debug page top-n table has a URL generation issue
Jiawei Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14589
Change subject: IMPALA-9105: Catalog debug page top-n table has a URL generation issue
......................................................................
IMPALA-9105: Catalog debug page top-n table has a URL generation issue
What's the problem:
Previously, catalogd debug page does not have 'fqtn' property.
Thus, the generated page table detail page cannot be opened.
Fix:
Correct the URL generation part.
Test:
Open the page and all the tables object can be correctly opened.
Change-Id: If7416c79baf2e78d6790995e97d9802ec7a8cc37
---
M www/catalog.tmpl
1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/14589/1
--
To view, visit http://gerrit.cloudera.org:8080/14589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If7416c79baf2e78d6790995e97d9802ec7a8cc37
Gerrit-Change-Number: 14589
Gerrit-PatchSet: 1
Gerrit-Owner: Jiawei Wang <ji...@cloudera.com>
[Impala-ASF-CR] IMPALA-9105: Catalog debug page top-n table has a URL generation issue
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14589 )
Change subject: IMPALA-9105: Catalog debug page top-n table has a URL generation issue
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14589/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14589/2//COMMIT_MSG@13
PS2, Line 13: br
typo? td?
--
To view, visit http://gerrit.cloudera.org:8080/14589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If7416c79baf2e78d6790995e97d9802ec7a8cc37
Gerrit-Change-Number: 14589
Gerrit-PatchSet: 2
Gerrit-Owner: Jiawei Wang <ji...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jiawei Wang <ji...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Thu, 31 Oct 2019 11:54:05 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9105: Catalog debug page top-n table has a URL generation issue
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14589 )
Change subject: IMPALA-9105: Catalog debug page top-n table has a URL generation issue
......................................................................
Patch Set 1:
(2 comments)
Thanks for fixing this by the way. I tried the patch locally and it works well. This patch looks good to me. It'd be better if we can explain the root cause in commit message. I'm ok to give a +2 if the cause is not easy to find.
http://gerrit.cloudera.org:8080/#/c/14589/1/www/catalog.tmpl
File www/catalog.tmpl:
http://gerrit.cloudera.org:8080/#/c/14589/1/www/catalog.tmpl@42
PS1, Line 42: <td>
Oops!
http://gerrit.cloudera.org:8080/#/c/14589/1/www/catalog.tmpl@47
PS1, Line 47: <a href="{{ __common__.host-url }}/catalog_object?object_type=TABLE&object_name={{name}}">{{name}}</a>
Is {{fqtn}} empty here causing the problem? Looks like we still use {{fqtn}} at line 194 and line 198. It'd be better if we can explain why it doesn't work in the commit message. Maybe the answer is in ImpalaHttpHandler::CatalogHandler().
--
To view, visit http://gerrit.cloudera.org:8080/14589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If7416c79baf2e78d6790995e97d9802ec7a8cc37
Gerrit-Change-Number: 14589
Gerrit-PatchSet: 1
Gerrit-Owner: Jiawei Wang <ji...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Thu, 31 Oct 2019 01:42:13 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9105: Catalog debug page top-n table has a URL generation issue
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14589 )
Change subject: IMPALA-9105: Catalog debug page top-n table has a URL generation issue
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4911/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If7416c79baf2e78d6790995e97d9802ec7a8cc37
Gerrit-Change-Number: 14589
Gerrit-PatchSet: 1
Gerrit-Owner: Jiawei Wang <ji...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 30 Oct 2019 19:24:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9105: Catalog debug page top-n table has a URL generation issue
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14589 )
Change subject: IMPALA-9105: Catalog debug page top-n table has a URL generation issue
......................................................................
IMPALA-9105: Catalog debug page top-n table has a URL generation issue
What's the problem:
Previously, catalogd debug page does not have 'fqtn' property. Because
CatalogServer::GetCatalogUsage() does not pass fqtn to the template.
Thus, the generated page table detail page cannot be opened. Also,
Someone might accedentially deleted <td> which makes the catalogd UI
top-K page unorganized.
Fix:
Correct the URL generation part.
Test:
Open the page and all the tables object can be correctly opened.
Change-Id: If7416c79baf2e78d6790995e97d9802ec7a8cc37
Reviewed-on: http://gerrit.cloudera.org:8080/14589
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M www/catalog.tmpl
1 file changed, 4 insertions(+), 3 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/14589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If7416c79baf2e78d6790995e97d9802ec7a8cc37
Gerrit-Change-Number: 14589
Gerrit-PatchSet: 5
Gerrit-Owner: Jiawei Wang <ji...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jiawei Wang <ji...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
[Impala-ASF-CR] IMPALA-9105: Catalog debug page top-n table has a URL generation issue
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14589 )
Change subject: IMPALA-9105: Catalog debug page top-n table has a URL generation issue
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If7416c79baf2e78d6790995e97d9802ec7a8cc37
Gerrit-Change-Number: 14589
Gerrit-PatchSet: 3
Gerrit-Owner: Jiawei Wang <ji...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jiawei Wang <ji...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Nov 2019 00:41:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9105: Catalog debug page top-n table has a URL generation issue
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14589 )
Change subject: IMPALA-9105: Catalog debug page top-n table has a URL generation issue
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If7416c79baf2e78d6790995e97d9802ec7a8cc37
Gerrit-Change-Number: 14589
Gerrit-PatchSet: 4
Gerrit-Owner: Jiawei Wang <ji...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jiawei Wang <ji...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Nov 2019 05:03:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9105: Catalog debug page top-n table has a URL generation issue
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14589 )
Change subject: IMPALA-9105: Catalog debug page top-n table has a URL generation issue
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5161/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/14589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If7416c79baf2e78d6790995e97d9802ec7a8cc37
Gerrit-Change-Number: 14589
Gerrit-PatchSet: 4
Gerrit-Owner: Jiawei Wang <ji...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jiawei Wang <ji...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Nov 2019 00:42:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9105: Catalog debug page top-n table has a URL generation issue
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14589 )
Change subject: IMPALA-9105: Catalog debug page top-n table has a URL generation issue
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If7416c79baf2e78d6790995e97d9802ec7a8cc37
Gerrit-Change-Number: 14589
Gerrit-PatchSet: 4
Gerrit-Owner: Jiawei Wang <ji...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jiawei Wang <ji...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Nov 2019 00:42:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9105: Catalog debug page top-n table has a URL generation issue
Posted by "Jiawei Wang (Code Review)" <ge...@cloudera.org>.
Jiawei Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14589 )
Change subject: IMPALA-9105: Catalog debug page top-n table has a URL generation issue
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/14589/1/www/catalog.tmpl
File www/catalog.tmpl:
http://gerrit.cloudera.org:8080/#/c/14589/1/www/catalog.tmpl@42
PS1, Line 42: <td>
> Oops!
Yeah, I think someone accidentally deleted this.
http://gerrit.cloudera.org:8080/#/c/14589/1/www/catalog.tmpl@47
PS1, Line 47: <a href="{{ __common__.host-url }}/catalog_object?object_type=TABLE&object_name={{name}}">{{name}}</a>
> Is {{fqtn}} empty here causing the problem? Looks like we still use {{fqtn}
Yes, fqtn empty caused the issue. The problem is that these "Top-n" tables are passed in a different function in CatalogServer::GetCatalogUsage. And we did not pass fqtn there.
--
To view, visit http://gerrit.cloudera.org:8080/14589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If7416c79baf2e78d6790995e97d9802ec7a8cc37
Gerrit-Change-Number: 14589
Gerrit-PatchSet: 1
Gerrit-Owner: Jiawei Wang <ji...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jiawei Wang <ji...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Thu, 31 Oct 2019 03:34:17 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9105: Catalog debug page top-n table has a URL generation issue
Posted by "Jiawei Wang (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Vihang Karajgaonkar, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14589
to look at the new patch set (#3).
Change subject: IMPALA-9105: Catalog debug page top-n table has a URL generation issue
......................................................................
IMPALA-9105: Catalog debug page top-n table has a URL generation issue
What's the problem:
Previously, catalogd debug page does not have 'fqtn' property. Because
CatalogServer::GetCatalogUsage() does not pass fqtn to the template.
Thus, the generated page table detail page cannot be opened. Also,
Someone might accedentially deleted <td> which makes the catalogd UI
top-K page unorganized.
Fix:
Correct the URL generation part.
Test:
Open the page and all the tables object can be correctly opened.
Change-Id: If7416c79baf2e78d6790995e97d9802ec7a8cc37
---
M www/catalog.tmpl
1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/14589/3
--
To view, visit http://gerrit.cloudera.org:8080/14589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If7416c79baf2e78d6790995e97d9802ec7a8cc37
Gerrit-Change-Number: 14589
Gerrit-PatchSet: 3
Gerrit-Owner: Jiawei Wang <ji...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jiawei Wang <ji...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
[Impala-ASF-CR] IMPALA-9105: Catalog debug page top-n table has a URL generation issue
Posted by "Jiawei Wang (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Vihang Karajgaonkar, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14589
to look at the new patch set (#2).
Change subject: IMPALA-9105: Catalog debug page top-n table has a URL generation issue
......................................................................
IMPALA-9105: Catalog debug page top-n table has a URL generation issue
What's the problem:
Previously, catalogd debug page does not have 'fqtn' property. Because
CatalogServer::GetCatalogUsage() does not pass fqtn to the template.
Thus, the generated page table detail page cannot be opened. Also,
Someone might accedentially deleted <br> which makes the catalogd UI
top-K page unorganized.
Fix:
Correct the URL generation part.
Test:
Open the page and all the tables object can be correctly opened.
Change-Id: If7416c79baf2e78d6790995e97d9802ec7a8cc37
---
M www/catalog.tmpl
1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/14589/2
--
To view, visit http://gerrit.cloudera.org:8080/14589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If7416c79baf2e78d6790995e97d9802ec7a8cc37
Gerrit-Change-Number: 14589
Gerrit-PatchSet: 2
Gerrit-Owner: Jiawei Wang <ji...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jiawei Wang <ji...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>