[GitHub] [iceberg] rdblue commented on a change in pull request #4061: Flink: Sink supports custom snapshot metadata

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #4061:
URL: https://github.com/apache/iceberg/pull/4061#discussion_r802011391



##########
File path: flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergFilesCommitter.java
##########
@@ -307,6 +310,9 @@ private void commitOperation(SnapshotUpdate<?> operation, int numDataFiles, int
                                String newFlinkJobId, long checkpointId) {
     LOG.info("Committing {} with {} data files and {} delete files to table {}", description, numDataFiles,
         numDeleteFiles, table);
+    if (customSnapshotMetadata != null) {
+      customSnapshotMetadata.forEach(operation::set);
+    } // custom snapshot metadata properties will be overridden if they conflict with reversed ones.

Review comment:
       Can you put this comment on its own line? Also, what do you mean by "reversed"?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org