[GitHub] [spark] LuciferYang commented on a diff in pull request #40898: [SPARK-43230][CONNECT] Simplify `DataFrameNaFunctions.fillna`

["LuciferYang (via GitHub)" <gi...@apache.org>]

LuciferYang commented on code in PR #40898:
URL: https://github.com/apache/spark/pull/40898#discussion_r1174797167


##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/client/CheckConnectJvmClientCompatibility.scala:
##########
@@ -145,6 +145,7 @@ object CheckConnectJvmClientCompatibility {
 
       // DataFrameNaFunctions
       ProblemFilters.exclude[Problem]("org.apache.spark.sql.DataFrameNaFunctions.this"),
+      ProblemFilters.exclude[Problem]("org.apache.spark.sql.DataFrameNaFunctions.fillValue"),

Review Comment:
   This behavior is expected now, but I think some refactoring work is needed to automatically filter similar checks, just like what `dev/mima` check does.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org