You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/08/24 08:42:31 UTC
[GitHub] [ozone] ferhui opened a new pull request, #3716: HDDS-7106. [DiskBalancer] Client-SCM interface (#3663)
ferhui opened a new pull request, #3716:
URL: https://github.com/apache/ozone/pull/3716
## What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
## What is the link to the Apache JIRA
(Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HDDS-XXXX. Fix a typo in YYY.)
Please replace this section with the link to the Apache JIRA)
## How was this patch tested?
(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #3716: HDDS-7106. [DiskBalancer] Client-SCM interface (#3663)
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #3716:
URL: https://github.com/apache/ozone/pull/3716#issuecomment-1225408304
> It is rebased on master branch, we can push it after CI passes.
Based on @errose28's [comment](https://github.com/apache/ozone/pull/3663#issuecomment-1215771924) from #3663, I think this should wait until release branch for 1.3 is cut.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #3716: HDDS-7106. [DiskBalancer] Client-SCM interface (#3663)
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #3716:
URL: https://github.com/apache/ozone/pull/3716#issuecomment-1225529920
> > Is the only purpose of this PR to run CI checks?
>
> Yes.
>
> > Those are also run in your fork here: https://github.com/ferhui/ozone/actions/runs/2917658837
>
> After It passes, will update the develop branch.
Fine, but I think it can be updated without PR next time. All other steps are the same: push to your fork, wait for CI, update feature branch in `apache/ozone`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ferhui commented on pull request #3716: HDDS-7106. [DiskBalancer] Client-SCM interface (#3663)
Posted by GitBox <gi...@apache.org>.
ferhui commented on PR #3716:
URL: https://github.com/apache/ozone/pull/3716#issuecomment-1225468999
@adoroszlai Hi, This PR aims to check whether develop branch is good. Because I did a rebase operation to let develop branch catches master.
Will *not* merge this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ferhui commented on pull request #3716: HDDS-7106. [DiskBalancer] Client-SCM interface (#3663)
Posted by GitBox <gi...@apache.org>.
ferhui commented on PR #3716:
URL: https://github.com/apache/ozone/pull/3716#issuecomment-1225385940
@symious It is rebased on master branch, we can push it after CI passes. Please check it again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai closed pull request #3716: HDDS-7106. [DiskBalancer] Client-SCM interface (#3663)
Posted by GitBox <gi...@apache.org>.
adoroszlai closed pull request #3716: HDDS-7106. [DiskBalancer] Client-SCM interface (#3663)
URL: https://github.com/apache/ozone/pull/3716
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ferhui commented on pull request #3716: HDDS-7106. [DiskBalancer] Client-SCM interface (#3663)
Posted by GitBox <gi...@apache.org>.
ferhui commented on PR #3716:
URL: https://github.com/apache/ozone/pull/3716#issuecomment-1226692190
@adoroszlai I learnt a lot from you, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #3716: HDDS-7106. [DiskBalancer] Client-SCM interface (#3663)
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #3716:
URL: https://github.com/apache/ozone/pull/3716#issuecomment-1225612195
> I am not sure about it, how to wait for CI if no PR?
Checks are run for both PR and commit ("push" event). To find the CI workflow for the commit in your fork:
1. Open the branch in your fork: https://github.com/ferhui/ozone/tree/HDDS-5713
2. Click on the "4921 commits" text -> leads to https://github.com/ferhui/ozone/commits/HDDS-5713
3. Click on the CI indicator (yellow circle, red x or green checkmark) for the latest commit
4. Click on "Details" for any check in the popup -> leads to https://github.com/ferhui/ozone/runs/7990725854?check_suite_focus=true
5. Click on "Summary" at the top left: https://github.com/ferhui/ozone/actions/runs/2917658837
This workflow run is almost the same as one in the PR, with two differences:
* It checks your commit, while the PR checks a special "merge your commit into master". (So if there are any newer commits in master after yours, those are included as well. If your branch is up-to-date with master, then there is no real difference.)
* It is always a complete run, while PR may skip some checks depending on the kind of change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #3716: HDDS-7106. [DiskBalancer] Client-SCM interface (#3663)
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #3716:
URL: https://github.com/apache/ozone/pull/3716#issuecomment-1225488007
@ferhui Is the only purpose of this PR to run CI checks? Those are also run in your fork here: https://github.com/ferhui/ozone/actions/runs/2917658837
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ferhui commented on pull request #3716: HDDS-7106. [DiskBalancer] Client-SCM interface (#3663)
Posted by GitBox <gi...@apache.org>.
ferhui commented on PR #3716:
URL: https://github.com/apache/ozone/pull/3716#issuecomment-1225572847
@adoroszlai Thanks for your explanation.
May I have a question?
>wait for CI
I am not sure about it, how to wait for CI if no PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ferhui commented on pull request #3716: HDDS-7106. [DiskBalancer] Client-SCM interface (#3663)
Posted by GitBox <gi...@apache.org>.
ferhui commented on PR #3716:
URL: https://github.com/apache/ozone/pull/3716#issuecomment-1225513637
> Is the only purpose of this PR to run CI checks?
Yes.
>Those are also run in your fork here: https://github.com/ferhui/ozone/actions/runs/2917658837
After It passes, will update the develop branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #3716: HDDS-7106. [DiskBalancer] Client-SCM interface (#3663)
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #3716:
URL: https://github.com/apache/ozone/pull/3716#issuecomment-1225656093
@ferhui All checks passed, closing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org