You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/10/01 20:03:00 UTC

[jira] [Commented] (ARROW-1625) [Serialization] Support OrderedDict properly

    [ https://issues.apache.org/jira/browse/ARROW-1625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16187514#comment-16187514 ] 

ASF GitHub Bot commented on ARROW-1625:
---------------------------------------

GitHub user pcmoritz opened a pull request:

    https://github.com/apache/arrow/pull/1152

    ARROW-1625: [Serialization] Support OrderedDict and defaultdict serialization

    If anybody has an idea on how to make Travis happy without making cloudpickle a runtime dependency (it is only needed for the tests) please let me know!

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pcmoritz/arrow pydict-exact2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/arrow/pull/1152.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1152
    
----
commit 799d983ef3eb735095949233fc57627cdf4fb110
Author: Philipp Moritz <pc...@gmail.com>
Date:   2017-09-29T18:39:01Z

    do not interpret OrderedDict as dict

commit db19ab9b4a796b00ba439a162e5362c1b0f8abc2
Author: Philipp Moritz <pc...@gmail.com>
Date:   2017-09-30T00:45:31Z

    add tests

commit 052b1aa9a023a67fa44eea271735f8d23ade0eaa
Author: Philipp Moritz <pc...@gmail.com>
Date:   2017-10-01T19:39:06Z

    I'd prefer this not to be a runtime dependency

----


> [Serialization] Support OrderedDict properly
> --------------------------------------------
>
>                 Key: ARROW-1625
>                 URL: https://issues.apache.org/jira/browse/ARROW-1625
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: Python
>            Reporter: Philipp Moritz
>              Labels: pull-request-available
>
> At the moment what happens when we serialize an OrderedDict and then deserialize it, it will become a normal dict! This can be reproduced with
> {code}
> import pyarrow
> import collections
> d = collections.OrderedDict([("hello", 1), ("world", 2)])
> type(pyarrow.serialize(d).deserialize())
> {code}
> which will return "dict". See also https://github.com/ray-project/ray/issues/1034.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)